chore(null): strict null checks for assessment-provider and deps #6274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds
assessment-builder
,assessment-provider
, and most individual assessmenttest-steps
to the strict null check config.The only particularly interesting conversion was in
assessments-requirements-filter
- I ended up converting a pattern that used a mutatingfilter
callback followed by amap
to use a singlereduce
call to implement afilterMap
pattern, so that typescript could see the relevant type information within the same scope instead of being split into several scopes.Motivation
#2869
Context
n/a
Pull request checklist
yarn null:autoadd
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.