Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): strict null checks for more injected/visualization files #6234

Merged
merged 11 commits into from
Dec 5, 2022

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Dec 2, 2022

Details

This PR continues from #6223 and fixes another few layers of injected/visualization files to be strict null check compatible. It substantially refactors accessibile-name-formatter and somewhat refactors landmark-formatter - I manually smoke tested those ad hoc tools to verify that they still worked after the changes

Motivation

#2869

Context

n/a

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn null:autoadd
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner December 2, 2022 22:20
Copy link
Contributor

@peterdur peterdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built, ran tests, visually verified accessible name behavior.
LGTM!

Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbjorge dbjorge merged commit aece58e into microsoft:main Dec 5, 2022
@dbjorge dbjorge deleted the null-20221201-2 branch December 5, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants