Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes strict null checks for a few different files. These files were selected by running
yarn null:find
, added totsconfig.strictNullChecks.json
one-by-one, judged on whether their resolutions were straightforward enough to not require their own PR (removed if complex), and addressed.I recommend going through this PR commit-by-commit, as each file from
yarn null:find
is scoped to a single commit.src/common/rule-based-view-model-provider.ts
: allow various methods to returnnull
src/background/stores/tab-store.ts
: updateTabStoreData
to accept undefined values forurl
,title
, andid
, as that is what is returned from thechrome.tabs
APIaccept undefined values for
description,
url, and
guidance` for RuleResults, as returned by axesrc/DetailsView/components/interactive-header.tsx
: update InteractiveHeader to excludeitems
(an optional param) instead of passingnull
originalResult
optional and default to undefined, as it is optional in the data returned from axeMotivation
#2869
Context
More PRs like this to follow, trying to keep PRs relatively small and well-chunked.
Pull request checklist
yarn null:autoadd
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.