Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(null): null strictness fixes for /src/scanner/ files requiring manual attention #3341

Merged
merged 5 commits into from
Sep 15, 2020
Merged

chore(null): null strictness fixes for /src/scanner/ files requiring manual attention #3341

merged 5 commits into from
Sep 15, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Sep 11, 2020

Description of changes

Cleanup for a few new strict-null-check cases

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner September 11, 2020 00:51
@dbjorge dbjorge merged commit a1f0455 into microsoft:master Sep 15, 2020
@dbjorge dbjorge deleted the null-fixes-0910 branch September 15, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanbirsingh karanbirsingh karanbirsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbjorge @karanbirsingh