Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): add strict null checks for first layer of src/common/ #2990

Merged
merged 10 commits into from
Jun 30, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 29, 2020

Description of changes

This PR adds all of the files matched by yarn null:find of form /src/common/**/*.ts to the strict null checks list.

Pull request checklist

  • Addresses an existing issue: part of Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner June 29, 2020 23:01
@dbjorge dbjorge merged commit e9c0126 into microsoft:master Jun 30, 2020
@dbjorge dbjorge deleted the null-fixes branch June 30, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants