Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wcag link and replace it with best practice in headings assessment guidance #2480

Merged
merged 2 commits into from
Apr 14, 2020
Merged

fix: remove wcag link and replace it with best practice in headings assessment guidance #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99874b9
fix guidance for heading
Shobhit1 Apr 12, 2020
ff83109
update snapshot
Shobhit1 Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/content/test/headings/guidance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ export const guidance = create(({ Markup, Link }) => (
<li>Programmatic heading levels should match their visual appearance (like size and boldness).</li>
</ul>

<h3>
Use exactly one top-level heading. (<Link.WCAG_1_3_1 />){' '}
</h3>
<h3>Use exactly one top-level heading. (best practice) </h3>
<ul>
<li>
Top-level (<Markup.Code>h1</Markup.Code>) headings should give an overall description of the page content.
Expand Down
10 changes: 1 addition & 9 deletions src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8745,15 +8745,7 @@ exports[`Guidance Content pages test/headings/guidance matches the snapshot 1`]
</li>
</ul>
<h3>
Use exactly one top-level heading. (
<a
class="ms-Link insights-link root-000"
href="https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships"
target="_blank"
>
WCAG 1.3.1
</a>
)
Use exactly one top-level heading. (best practice)
</h3>
<ul>
<li>
Expand Down