Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<hx role="none"> is reported as heading. #7362

Closed
shaminder1 opened this issue Jun 17, 2024 · 2 comments
Closed

<hx role="none"> is reported as heading. #7362

shaminder1 opened this issue Jun 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@shaminder1
Copy link

Describe the bug

headings tag with role="none "are tagged as headings,

To Reproduce
Steps to reproduce the behavior:

  1. Open Accessibility insights for web
  2. Turn on Headings in Adhoc Tools.
  3. Check if headings tag with role="none "are tagged as headings,

CodePen repro example

Expected behavior

Heading tags with role="none" should not be detected as programmatic headings.

Screenshots

image

Context (please complete the following information)

  • OS Name & Version:
  • AI-Web Version & Environment: Accessibility Insights for Web - Version 2.42.0 | Powered by
    axe-core
    4.8.4>
  • Browser Version: Chrome Version 125.0.6422.142 (Official Build) (32-bit)
  • Target Page:

Are you willing to submit a PR?

NA

Did you search for similar existing issues?

No
@shaminder1 shaminder1 added the bug Something isn't working label Jun 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Jun 17, 2024
@shaminder1
Copy link
Author

By default screen readers treat content contained in as normal text (without any semantic meaning). But AI tool identifies the same as heading.

@madalynrose madalynrose moved this from Needs triage to Accepted - vendor in Accessibility Insights Jun 17, 2024
@rohittarpara rohittarpara mentioned this issue Jun 26, 2024
Merged
7 tasks
v-viyada added a commit that referenced this issue Jun 26, 2024
@rohittarpara @v-viyada
fix: <hx role="none"> is reported as heading. (#7377)
2214fa4 
#### Details

Fixed the headings are tagged with role="none" in assessment and Adhoc
tools.

##### Motivation

Addresses Issue -
#7362

##### Context

Added role=none rule

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [X] Addresses an existing issue:
[https://github.com/microsoft/accessibility-insights-web/issues/7362](https://github.com/microsoft/accessibility-insights-web/issues/7362)
- [X] Ran `yarn fastpass`
- [X] Added/updated relevant unit test(s) (and ran `yarn test`)
- [X] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [X] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS

---------

Co-authored-by: Vikash Yadav <[email protected]>
@v-viyada v-viyada moved this from Accepted - vendor to Needs release in Accessibility Insights Jun 28, 2024
@v-viyada v-viyada removed the status: new This issue is new and requires triage by DRI. label Jun 28, 2024
@v-sharmachir
Copy link
Contributor

This is released in version 2.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shaminder1 @v-viyada @v-sharmachir