PR Review-Fixes

microsoft · May 2, 2024 · dbae7a1 · dbae7a1
1 parent 1e12aa6
commit dbae7a1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/src/DetailsView/components/save-assessment-button.tsx b/src/DetailsView/components/save-assessment-button.tsx
@@ -74,6 +74,9 @@ export const SaveAssessmentButton = NamedFC<SaveAssessmentButtonProps>(
                         >
                             <Stack.Item grow disableShrink>
                                 <Checkbox
+                                    checked={
+                                        !props.userConfigurationStoreData.showSaveAssessmentDialog
+                                    }
                                     label="Don't show again"
                                     onChange={handleDontShowAgainClick}
                                 />

diff --git a/src/common/components/visualization-toggle.tsx b/src/common/components/visualization-toggle.tsx
@@ -30,8 +30,8 @@ export class VisualizationToggle extends React.Component<VisualizationToggleProp
             componentRef: this.props.componentRef,
             onBlur: this.props.onBlur,
             onFocus: this.props.onFocus,
-            ...{ 'data-automation-id': this.props['data-automation-id'] },
-        };
+            'data-automation-id': this.props['data-automation-id'],
+        } as IToggleProps;
 
         return <Toggle {...props} />;
     }

diff --git a/src/reports/components/report-sections/collapsible-url-result-section.tsx b/src/reports/components/report-sections/collapsible-url-result-section.tsx
@@ -28,7 +28,6 @@ export const CollapsibleUrlResultSection = NamedFC<CollapsibleUrlResultSectionPr
             header: <ResultSectionTitle {...props} titleSize="heading" />,
             content,
             headingLevel: 3,
-            onExpandToggle: (event: React.MouseEvent<HTMLDivElement>) => {},
         });
 
         return <div className={styles.urlResultSection}>{CollapsibleContent}</div>;

diff --git a/src/reports/components/report-sections/report-collapsible-container.tsx b/src/reports/components/report-sections/report-collapsible-container.tsx
@@ -14,7 +14,7 @@ export interface ReportCollapsibleContainerProps {
     containerClassName?: string;
     buttonAriaLabel?: string;
     testKey?: string;
-    onExpandToggle: (event: React.MouseEvent<HTMLDivElement>) => void;
+    onExpandToggle?: (event: React.MouseEvent<HTMLDivElement>) => void;
 }
 
 const ReportCollapsibleContainer = NamedFC<ReportCollapsibleContainerProps>(

diff --git a/...ests/unit/tests/DetailsView/components/__snapshots__/save-assessment-button.test.tsx.snap b/...ests/unit/tests/DetailsView/components/__snapshots__/save-assessment-button.test.tsx.snap
@@ -36,6 +36,7 @@ exports[`SaveAssessmentButton on dialog enabled render snapshot of dialog 1`] =
           grow="true"
         >
           <mock-styledcheckboxbase
+            checked="false"
             label="Don't show again"
           />
         </mock-stackitem>