feat(mvp-ado-extension-behavior): Add optional inputs to task.json and config #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisli1
reviewed
Sep 7, 2021
| @@ -55,6 +56,21 @@ describe(ADOTaskConfig, () => { | |||
| }, | |||
| ); | |||
|
|
|||
| it.each` | |||
| inputOption | inputValue | expectedValue | getInputFunc | |||
| ${'failOnAccessibilityError'} | ${true} | ${true} | ${() => taskConfig.getFailOnAccessibilityError()} | |||
There was a problem hiding this comment.
It looks like there is only one test case in this .each test. Do you see this test having more test cases in the future?
There was a problem hiding this comment.
It could, I mostly wanted this to read similarly to the above test case because they are doing almost the same thing.
lisli1
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds the optional
failOnAccessibilityErrorandrepoServiceConnectionNameinputs to our task.json and task-config files.Motivation
We'll use these in future PRs for this feature.
Context
n/a
Pull request checklist
yarn test)<rootDir>/test-results/unit/coverageyarn precheckin)Accessibility Checks (pull_request)check should fail. All other checks should pass.