Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #29

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Update README.md #29

merged 3 commits into from
Feb 27, 2020

Conversation

manishsat
Copy link
Contributor

Added badge

Description of changes

(Give an overview. Add a technical description describing your changes.)

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@manishsat manishsat requested a review from a team as a code owner February 27, 2020 00:02
@codecov-io
Copy link

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files          17       17           
  Lines         342      342           
  Branches       17       17           
=======================================
  Hits          294      294           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7ae0e...6866f1b. Read the comment docs.

Copy link
Contributor

@AhmedAbdoOrtiga AhmedAbdoOrtiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the build, need to run: "yarn format"

@manishsat manishsat merged commit 67b7c5e into master Feb 27, 2020
@manishsat manishsat deleted the users/masatwan/badge branch February 27, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants