Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added resolutions in package.json file to resolve CVE-2024-29415 issue #2124

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

v-sharmachir
Copy link
Contributor

@v-sharmachir v-sharmachir commented Jul 10, 2024

Details

ip's latest version is vulnerable and unmaintained. Our repo don't use it directly but it ships as dependency from other packages like jest, etc and these packages already shifted from ip to ip-address package because of vulnerability and it is not maintained. This PR will remove the unwanted dependencies and ip reference from our code base and also resolve CVE-2024-29415 issue.

Motivation

CVE-2024-29415

Context

Pull request checklist

  • Addresses an existing issue: CVE-2024-29415
  • [na] Added relevant unit test for your changes. (yarn test)
  • [na] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@v-viyada v-viyada marked this pull request as ready for review July 10, 2024 18:09
@v-viyada v-viyada requested a review from a team as a code owner July 10, 2024 18:09
@v-viyada v-viyada merged commit 95e2d94 into main Jul 10, 2024
3 checks passed
@v-sharmachir v-sharmachir deleted the users/v-sharmachir/ip-cg-issue branch July 11, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants