Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): added react-router-dom to ignore list of dependabot updates #2028

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

v-viyada
Copy link
Contributor

@v-viyada v-viyada commented Mar 5, 2024

Details

react-router-dom is used for test website for testing Urls with hash fragments.
The feature hashType="noslash" used in test website is not supported from v6. Please refer remix-run/react-router#11076 for more details. As per this, this feature is not going to be supported in future version so we have to stick with v5 only

Also closed out dependabot PR #2024

Motivation
Context

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • [n/a] Added relevant unit test for your changes. (yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@v-viyada v-viyada marked this pull request as ready for review March 5, 2024 21:22
@v-viyada v-viyada requested a review from a team as a code owner March 5, 2024 21:22
@v-viyada v-viyada merged commit 071780f into main Mar 6, 2024
3 checks passed
@v-viyada v-viyada deleted the users/v-viyada/react-router-dom-ignore branch September 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants