Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump prettier from 3.1.1 to 3.2.4 #1984

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 18, 2024

Bumps prettier from 3.1.1 to 3.2.4.

Release notes

Sourced from prettier's releases.

3.2.4

  • Fix .eslintrc.json format #15947

🔗 Changelog

3.2.3

  • Format tsconfig.json file with jsonc parser #15927

🔗 Changelog

3.2.2

🔗 Changelog

3.2.1

🔗 Changelog

3.2.0

diff

🔗 Release note

Changelog

Sourced from prettier's changelog.

3.2.4

diff

Fix incorrect parser inference (#15947 by @​fisker)

Files like .eslintrc.json were incorrectly formatted as JSONC files.

// Input
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "jsonc" }
// Prettier 3.2.4
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "json" }

3.2.3

diff

Throw errors for invalid code (#15881 by @​fisker, @​Josh-Cena, @​auvred)

// Input
1++;
// Prettier 3.2.2
1++;
// Prettier 3.2.3
SyntaxError: Invalid left-hand side expression in unary operation (1:1)
> 1 | 1++;
| ^

// Input
try {} catch (error = 1){}
// Prettier 3.2.2
try {
} catch (error) {}
// Prettier 3.2.3
SyntaxError: Catch clause variable cannot have an initializer. (1:23)
</tr></table>

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.4.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.1.1...3.2.4)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner January 18, 2024 08:42
@dependabot dependabot bot added category: engineering dependencies Pull requests that update a dependency file labels Jan 18, 2024
@DaveTryon
Copy link
Contributor

Checks passed with Prettier 3.2.2, but fail with Prettier 3.2.3 and 3.2.4. We should identify the breaking change and file an issue in the prettier repo

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (808eb42) 94.52% compared to head (e65f18f) 94.52%.
Report is 1 commits behind head on main.

❗ Current head e65f18f differs from pull request most recent head dfba1e5. Consider uploading reports for the commit dfba1e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1984   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          38       38           
  Lines        1059     1059           
  Branches      145      145           
=======================================
  Hits         1001     1001           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The break here is due to a change in Prettier (see prettier/prettier#15942), where the decision was explicitly made to treat tsconfig.json as jsonc format. For the record, I disagree with that decision (especially in a patch update), but it doesn't seem like it's likely to be reversed. If it is, we'll need to repeat the process of running yarn format fix with the new version.

I've pushed an update after running yarn format fix

Tagging @v-viyada as we have tsconfig.json files in multiple repos and we'll probably have other dependabot PR's that fail for the same reason

@v-viyada v-viyada merged commit c03ab5b into main Jan 31, 2024
3 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/prettier-3.2.4 branch January 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants