Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refine the markdown #16

Merged
merged 10 commits into from
Feb 26, 2020
Merged

feat: refine the markdown #16

merged 10 commits into from
Feb 26, 2020

Conversation

haonliu
Copy link
Contributor

@haonliu haonliu commented Feb 26, 2020 •
edited
Loading

The output for 3 scenarios (pass, fail, error) will show as commented down below.

@haonliu haonliu requested a review from a team as a code owner February 26, 2020 00:45
@haonliu
Copy link
Contributor Author

haonliu commented Feb 26, 2020 •
edited
Loading

Accessibility Automated Checks Results

The Accessibility Insights Service ran a set of automated checks to help find some of the most common accessibility issues. The best way to evaluate web accessibility compliance is to complete a WCAG 2.1 compliance assessment.

DETAILS

Accessibility Insights Accessibility Insights: All applicable checks passed

  • 1 check(s) passed, and 1 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks.

This scan used axe-core 1.0.1 with the following browsers: browserSpec.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2020 •
edited
Loading

File Coverage
All files 89% ✅
src/index.ts 0% ❌
src/ioc/setup-ioc-container.ts 0% ❌
src/logger/log-level.ts 0% ❌

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 3760789

@haonliu
Copy link
Contributor Author

haonliu commented Feb 26, 2020 •
edited
Loading

Accessibility Automated Checks Results

The Accessibility Insights Service ran a set of automated checks to help find some of the most common accessibility issues. The best way to evaluate web accessibility compliance is to complete a WCAG 2.1 compliance assessment.

DETAILS

Accessibility Insights Accessibility Insights: Something went wrong

You can review the log to troubleshoot the issue. Fix it and re-run the workflow to run the automated accessibility checks again.

@haonliu
Copy link
Contributor Author

haonliu commented Feb 26, 2020 •
edited
Loading

Accessibility Automated Checks Results

The Accessibility Insights Service ran a set of automated checks to help find some of the most common accessibility issues. The best way to evaluate web accessibility compliance is to complete a WCAG 2.1 compliance assessment.

DETAILS

Accessibility Insights Accessibility Insights

  • 2 check(s) failed, 1 passed, and 1 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks.

Failed instances

  • 2 × color-contrast: color-contrast is important
  • 3 × duplicate-id: duplicate-id is even more important

This scan used axe-core 1.0.1 with the following browsers: browserSpec.

AhmedAbdoOrtiga
AhmedAbdoOrtiga suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@AhmedAbdoOrtiga AhmedAbdoOrtiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you move the mark down code in a separate folder or something

@devaradhanm
Copy link
Contributor

LGTM, just the minor comments. other text changes we could do after this pr is merged

@haonliu haonliu force-pushed the users/haonliu/markdown-imporvement branch from f9bd8ed to 799801d Compare February 26, 2020 01:34
@haonliu haonliu merged commit d72d92a into master Feb 26, 2020
@devaradhanm devaradhanm deleted the users/haonliu/markdown-imporvement branch February 27, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedAbdoOrtiga AhmedAbdoOrtiga AhmedAbdoOrtiga approved these changes

@devaradhanm devaradhanm devaradhanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haonliu @devaradhanm @AhmedAbdoOrtiga