Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update scan package and reported viewport size #1379

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

brocktaylor7
Copy link
Contributor

Details

This consumes the latest scan package that includes a fix for the viewport size. This also changes the report to report the new 1920x1080 viewport size that the scan package now defaults to.

Motivation

Fixes bugs and prepares us for release.

Context

This affects both the GH Action and ADO Extension equally, and documentation is updated for both

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • [n/a] Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • Described how this PR impacts both the ADO extension and the GitHub action

@brocktaylor7 brocktaylor7 requested a review from a team as a code owner November 3, 2022 20:32
Copy link
Contributor

@ThanyaLeif ThanyaLeif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brocktaylor7 brocktaylor7 merged commit fd45ac0 into main Nov 3, 2022
@brocktaylor7 brocktaylor7 deleted the brocktaylor/scan-package-and-resolution branch November 3, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants