feat(ado-gha-axe-core): remove check run, add workflow enforcer, add fail-on-accessibility-error #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR:
GHWorkflowEnforcer
progress reporter that operates the same way the newly renamedAdoWorkflowEnforcer
already works. Its job is to run last and fail the build if anything has failed along the way. This decouples failing the build from the logic of the other individual progress reporters, so that each of them can run without the build failing, which would abort the remaining tasks.fail-on-accessibility-error
input that defaults totrue
. This is also bringing the GH Action to parity with the ADO Extension. Without the check run, there was no way to not fail the build if there were accessibility issues. Where we don't have baselining yet on the GH action, this allows people to not fail the build when errors are found.self-test.yml
to use node16.Here are two test runs from my test action:
fail-on-accessibility-error
not set (defaults totrue
)fail-on-accessibility-error
set tofalse
:Motivation
Feature work
Context
The
repo-token
input will be removed in a future PR.Impact for ADO Extension: This renames the
WorkflowEnforcer
class in the ADO Extension to more easily distinguish it from the newGHWorkflowEnforcer
, but does not change any functionality.Pull request checklist
yarn test
)<rootDir>/test-results/unit/coverage
yarn precheckin
)