Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ado-gha-axe-core): remove check run, add workflow enforcer, add fail-on-accessibility-error #1219

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

brocktaylor7
Copy link
Contributor

Details

This PR:

  1. Removes the check run in preparation to remove the repo-token in a future PR.
  2. Adds a GHWorkflowEnforcer progress reporter that operates the same way the newly renamed AdoWorkflowEnforcer already works. Its job is to run last and fail the build if anything has failed along the way. This decouples failing the build from the logic of the other individual progress reporters, so that each of them can run without the build failing, which would abort the remaining tasks.
  3. Adds a fail-on-accessibility-error input that defaults to true. This is also bringing the GH Action to parity with the ADO Extension. Without the check run, there was no way to not fail the build if there were accessibility issues. Where we don't have baselining yet on the GH action, this allows people to not fail the build when errors are found.
  4. Updates the self-test.yml to use node16.

Here are two test runs from my test action:

Motivation

Feature work

Context

The repo-token input will be removed in a future PR.

Impact for ADO Extension: This renames the WorkflowEnforcer class in the ADO Extension to more easily distinguish it from the new GHWorkflowEnforcer, but does not change any functionality.

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • Described how this PR impacts both the ADO extension and the GitHub action

@brocktaylor7 brocktaylor7 requested a review from a team as a code owner June 27, 2022 21:27
@brocktaylor7 brocktaylor7 merged commit 063e802 into main Jun 28, 2022
@brocktaylor7 brocktaylor7 deleted the brocktaylor/remove-check-run branch June 28, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants