Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows.h include on case-sensitive systems #4428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fruzitent
Copy link

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

When cross compiling a Windows application with MinGW, there's a well-known problem with the missing "Windows.h" header due to filesystem case-sensitivity.
Throughout the project uppercase variant occurs 13 times in 13 files and lowercase one - 55 times in 51 files.
Even though only a single file needs to be changed for my needs, this commit ensures consistency by switching to lowercase everywhere.

@fruzitent
Copy link
Author

@microsoft-github-policy-service agree

@bpulliam
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fruzitent
Copy link
Author

Does this need a rebase to pass checks?

There is another PR with the same error #4367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants