Fix: Correct Binary Deployment for .NET8 Breaking Change Support #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kythant
approved these changes
Nov 28, 2023
|
/azp run |
Scottj1s
approved these changes
Nov 28, 2023
ShashankNay
added a commit
that referenced
this pull request
Nov 29, 2023
kythant
added a commit
that referenced
this pull request
Nov 30, 2023
#4000) Co-authored-by: Kyaw Thant <[email protected]>
bpulliam
pushed a commit
that referenced
this pull request
Dec 6, 2023
Scottj1s
pushed a commit
that referenced
this pull request
Dec 11, 2023
) * Merged PR 9926818: .NET 8 Breaking Changes and WindowsAppSDK IntegrationCopyFilesToStagingDir.ps1 .NET8 introduced a [conditional breaking change](dotnet/docs#35398) that influences how the runtime host looks for RID-specific assets. In NET8, support for non-portable RIDs (runtime identifiers specific to versions and distributions, such as win10-x86) is discontinued. The folder structure of the Microsoft.WindowsAppSDK NuGet is structured with assets marked using these non-portable RIDs:  The changes made to the `CopyFilesToStagingDir.ps1` script along with the project template changes should help support the .NET8 scenario. The selection of the project template's RIDs is conditional and based on the TFM chosen by the user. If NET8 is chosen, the RIDs become portable, enabling the runtime host to locate the RID-specific assets that were previously unattainable. * Fix: Correct Binary Deployment for .NET8 Breaking Change Support #3998 * initial commit --------- Co-authored-by: Shashank Nayak <[email protected]> Co-authored-by: Shashank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the wrong binary (Microsoft.WindowsAppRuntime.dll) was deployed instead of the intended Microsoft.WindowsAppRuntime.Bootstrap.dll. This correction ensures that the appropriate binaries are deployed for .NET8 support, particularly addressing the breaking changes in the .NET8 framework.