Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDBs for MRT Core are missing source server information #4633

Closed
evelynwu-msft opened this issue Aug 13, 2024 · 1 comment · Fixed by #4666
Closed

PDBs for MRT Core are missing source server information #4633

evelynwu-msft opened this issue Aug 13, 2024 · 1 comment · Fixed by #4666
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) area-MRTCore ResourceManager fix-released The fix has been in a release (experimental, preview, stable, or servicing). Status: Fixed internally The issue has been fixed but has not yet shipped in a release. team-Markup
Milestone

Comments

@evelynwu-msft
Copy link
Contributor

evelynwu-msft commented Aug 13, 2024

Describe the bug

The PDBs for MRT Core (both Microsoft.Windows.ApplicationModel.Resources.dll and MRM.dll) are missing source server information for the source files. As a result, when debugging MRT Core code developers are required to manually obtain the matching source code (e.g. cloning this repository) and point their debugger at it. Additionally, the internal AzDO repo is what's pointed to by the PDB rather than this Github repo, so even if the expected source server entries were present non-Microsoft devs would still be unable to take advantage of that.

Steps to reproduce the bug

  1. Install Debugging Tools for Windows
  2. Download the PDBs for MRT Core (e.g. c:\Program Files (x86)\Windows Kits\10\Debuggers\x64\srcsrv>symchk /v "C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.6-preview1_6000.219.2254.0_x64__8wekyb3d8bbwe\Microsoft.Windows.ApplicationModel.Resources.dll" /s https://msdl.microsoft.com/download/symbols /oc c:\symbols\)
  3. Extract the srcsrv stream from the PDBs downloaded in step 2: c:\Program Files (x86)\Windows Kits\10\Debuggers\x64\srcsrv>pdbstr -r -p:"c:\symbols\Microsoft.Windows.ApplicationModel.Resources.pdb" -i:c:\Microsoft.Windows.ApplicationModel.Resources.txt -s:srcsrv

Expected behavior

The srcsrv streams should contain source information entries for every source file in https://github.com/microsoft/WindowsAppSDK/tree/main/dev/MRTCore/mrt/.

Screenshots

No response

NuGet package version

Windows App SDK 1.6 Experimental 2: 1.6.240701003-experimental2

Packaging type

No response

Windows version

No response

IDE

No response

Additional context

The actual srcsrv streams for Microsoft.Windows.ApplicationModel.Resources.dll and MRM.dll.

For comparison, this is the stream for Microsoft.WindowsAppRuntime.Insights.Resource.dll which contains the expected information.

@evelynwu-msft
Copy link
Contributor Author

evelynwu-msft commented Aug 13, 2024

There's a very real possibility that the presence of a srcsrv stream overrides the Source Link information encoded in the stream sourcelink$1. (Unfortunately, the Source Link information also points at the internal AzDO server.)

@codendone codendone added area-Deployment Issues related to packaging, installation, runtime (e.g., SelfContained, Unpackaged) and removed needs-triage labels Aug 16, 2024
@DrusTheAxe DrusTheAxe added area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) area-MRTCore ResourceManager and removed area-Deployment Issues related to packaging, installation, runtime (e.g., SelfContained, Unpackaged) labels Aug 18, 2024
evelynwu-msft added a commit that referenced this issue Aug 21, 2024
…al AzDO mirror (#4666)

This repository is mirrored onto an internal Azure DevOps repository that is used for building Windows App SDK releases. This has the unfortunate side effect of embedding into the PDB symbols Source Link information that points at the internal AzDO repo rather than this public Github repo. This change addresses that by adding a custom target that corrects the repo URL that Source Link uses.

Fixes #4633.
evelynwu-msft added a commit that referenced this issue Aug 21, 2024
…al AzDO mirror (#4666)

This repository is mirrored onto an internal Azure DevOps repository that is used for building Windows App SDK releases. This has the unfortunate side effect of embedding into the PDB symbols Source Link information that points at the internal AzDO repo rather than this public Github repo. This change addresses that by adding a custom target that corrects the repo URL that Source Link uses.

Fixes #4633.

(cherry picked from commit a820af7)
bpulliam pushed a commit that referenced this issue Aug 21, 2024
…points to Github rather than internal AzDO mirror (#4670)

This repository is mirrored onto an internal Azure DevOps repository that is used for building Windows App SDK releases. This has the unfortunate side effect of embedding into the PDB symbols Source Link information that points at the internal AzDO repo rather than this public Github repo. This change addresses that by adding a custom target that corrects the repo URL that Source Link uses.

Fixes #4633.

(cherry picked from commit a820af7)
@codendone codendone added this to the 1.6 milestone Aug 22, 2024
@codendone codendone added Status: Fixed internally The issue has been fixed but has not yet shipped in a release. fix-released The fix has been in a release (experimental, preview, stable, or servicing). and removed Status: In PR labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) area-MRTCore ResourceManager fix-released The fix has been in a release (experimental, preview, stable, or servicing). Status: Fixed internally The issue has been fixed but has not yet shipped in a release. team-Markup
Projects
None yet
3 participants