Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented CG Transparency APIs. #576

Merged
merged 2 commits into from
Jun 27, 2016

Conversation

adein
Copy link
Collaborator

@adein adein commented Jun 22, 2016

Implemented CGContextBeginTransparencyLayer,
CGContextBeginTransparencyLayerWithRect, CGContextEndTransparencyLayer from #524

Testing was performed using the CGCatalog sample app, and comparing results in iOS to results in Windows. Unit tests not included as APIs are graphical.

Implemented CGContextBeginTransparencyLayer,
CGContextBeginTransparencyLayerWithRect, CGContextEndTransparencyLayer.
Testing was accomplished using the CGCatalog sample app.
@msftclas
Copy link

Hi @adein, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@rajsesh
Copy link
Contributor

rajsesh commented Jun 23, 2016

@bdrlamb is added to the review. #Closed

@rajsesh
Copy link
Contributor

rajsesh commented Jun 23, 2016

@mnithish is added to the review. #Closed

@rajsesh
Copy link
Contributor

rajsesh commented Jun 23, 2016

@jaredhms is added to the review. #Closed

@rajsesh
Copy link
Contributor

rajsesh commented Jun 23, 2016

@ashvarma is added to the review. #Closed

@rajsesh rajsesh self-assigned this Jun 23, 2016

// Note: Shadow or Alpha would be better test samples for this, but are not fully implemented yet in the bridge.
// TODO: Use Shadow or Alpha instead of BlendMode when supported by the bridge
// Enable shadow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please file a GitHub issue to track this, and reference it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #584

@jaredhms
Copy link
Contributor

:shipit:

@jaredhms
Copy link
Contributor

In CI build.

@jaredhms jaredhms merged commit c1d5951 into microsoft:master Jun 27, 2016
@adein adein deleted the feature/CGTransparency branch June 27, 2016 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants