Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's completely ok to give nil as errorCode pointer (2nd try)... #379

Merged
merged 4 commits into from
Mar 5, 2016
Merged

It's completely ok to give nil as errorCode pointer (2nd try)... #379

merged 4 commits into from
Mar 5, 2016

Conversation

mgoemmel
Copy link
Contributor

@mgoemmel mgoemmel commented Mar 1, 2016

...so we should be prepared for this.

@rajsesh
Copy link
Contributor

rajsesh commented Mar 1, 2016

nitty comment to use {} with the if statements.

if (outError) {
*outError=nil;
}

@mgoemmel
Copy link
Contributor Author

mgoemmel commented Mar 2, 2016

nitty comment to use {} with the if statements.

Fixed.

@consvc consvc added the Approved label Mar 2, 2016
@rajsesh
Copy link
Contributor

rajsesh commented Mar 2, 2016

Thanks again! One more step needed. You have to sign the CLA as mentioned here. You have to do it only once for all MS open source projects.

https://github.com/Microsoft/WinObjC/wiki/How-to-Contribute

@msftclas
Copy link

msftclas commented Mar 3, 2016

@mgoemmel, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@rajsesh rajsesh merged commit 90ec9bf into microsoft:master Mar 5, 2016
@rajsesh
Copy link
Contributor

rajsesh commented Mar 5, 2016

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants