Fix CT drawing tests on ARM #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,23 @@ | |||
|
|
|||
| enum class ImageComparisonResult : unsigned int { Unknown = 0, Incomparable, Different, Same }; | |||
|
|
|||
| enum struct ComparisonMode { Exact, Mask }; | |||
| struct rgbaPixel { | |||
There was a problem hiding this comment.
rgbaPixel [](start = 7, length = 9)
is there really literally no way to not move this into the header :P
| @@ -470,7 +470,7 @@ TEXT_DRAW_TEST_F(CTLine, BasicDrawingTest, WhiteBackgroundTest<PixelByPixelImage | |||
| CTRunDraw(run, context, {}); | |||
| } | |||
|
|
|||
| class Fonts : public WhiteBackgroundTest<PixelByPixelImageComparator<ComparisonMode::Mask>>, | |||
| class Fonts : public WhiteBackgroundTest<PixelByPixelImageComparator<PixelComparisonModeMask<2300>>>, | |||
There was a problem hiding this comment.
2300 [](start = 93, length = 4)
document why 2300, that's a heck of a lot
There was a problem hiding this comment.
Yes. Given our reference images are 512x256, this is ~1.5%. The bigger concern is that we are not accounting for cases such as lines being completely at a different offset, etc. We need a more "fuzzy" proximity comparison than a pixel count. But that is an exercise for a different time.
In reply to: 97449301 [](ancestors = 97449301)
|
|
rajsesh
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes more tests to be more lenient, and changes the templates for the image comparison to work with the Gtest macros
Fixes #1772
This change is