Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return of non-GDI-compatible family/subfamily names from CTFont… #1778

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

ms-jihua
Copy link
Contributor

@ms-jihua ms-jihua commented Jan 24, 2017

…Copy(Family)Name et al

Fixes #1758


This change is Reviewable

@msft-Jeyaram
Copy link
Contributor

This was the root cause of #1751
Please close that with this.

@ms-jihua
Copy link
Contributor Author

@msft-Jeyaram I'm confused what issue #1751 is actually describing - if it's describing an issue in NSLayoutManager with:
CTLineRef fitLine = static_cast(CFArrayGetValueAtIndex(CTFrameGetLines(frame.get()), 0));
then that issue still repros, and this was not the root cause (I may have also just opened a dupe at #1779)

@msft-Jeyaram
Copy link
Contributor

@ms-jihua I updated the bug #1751 .
This might not as well be related, but I have seen the crash upon attempting to obtain
static_cast(CFArrayGetValueAtIndex(CTFrameGetLines(frame.get()), 0)); and the frame is empty.

Are you able to repo as per #1751 steps?

@ms-jihua
Copy link
Contributor Author

@msft-Jeyaram I am not able to repro the #1751 stack. I get #1758 on develop and #1779 after this change.

@ms-jihua ms-jihua merged commit 955b1c8 into microsoft:develop Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants