Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not roam NSUserDefaults (or CFPreferences) #1169

Merged
merged 3 commits into from
Oct 18, 2016
Merged

Do not roam NSUserDefaults (or CFPreferences) #1169

merged 3 commits into from
Oct 18, 2016

Conversation

rajsesh
Copy link
Contributor

@rajsesh rajsesh commented Oct 18, 2016 

Save NSUserDefaults to local app data, not roaming app data.
App preferences writes with kCFPreferencesAnyHost, which means we cannot
use the host parameter to differentiate roaming vs local.

The correct way to roam would be through ubiquitous store (which would
have to be covered separately based on need).

Fix #1167

Raj Seshasankaran added 2 commits October 17, 2016 19:33
Save NSUserDefaults to local app data, not roaming app data.
478026d 
App preferences writes with kCFPreferencesAnyHost, which means we cannot
use the host parameter to differentiate roaming vs local.

The correct way to roam would be through ubiquitous store (which would
have to be covered separately based on need).

Fix microsoft#1167
revert unwanted edits
3ab54ed
@rajsesh
Copy link
Contributor Author

rajsesh commented Oct 18, 2016

@DHowett-MSFT is added to the review. #Closed

@rajsesh
Copy link
Contributor Author

rajsesh commented Oct 18, 2016

@bbowman is added to the review. #Closed

DHowett-MSFT
DHowett-MSFT reviewed Oct 18, 2016
View reviewed changes
Frameworks/CoreFoundation/Base.subproj/CFPlatform.c
@@ -505,8 +505,8 @@ CF_EXPORT CFMutableStringRef _CFCreateApplicationRepositoryPath(CFAllocatorRef a
CFMutableStringRef result = NULL;
CFStringRef str = NULL;

// WINOBJC: make sure that nFolder is CSIDL_APPDATA or CSIDL_LOCAL_APPDATA and return the app data folder for the app.
Wrappers::HString path = GetAppDataPath(nFolder == CSIDL_LOCAL_APPDATA);
//WinOBJC- In Reference platform, CFPreferences does not roam, so ignore nFolder
Copy link

@DHowett-MSFT DHowett-MSFT Oct 18, 2016 •
edited by rajsesh
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: keep the style of the above comment (WINOBJC:) #Pending

@DHowett-MSFT
Copy link

:shipit:

@rajsesh rajsesh merged commit 88971d2 into microsoft:develop Oct 18, 2016
@rajsesh rajsesh deleted the nsuserdefaults branch November 17, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT left review comments

Assignees
No one assigned
Labels
Area-Foundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajsesh @DHowett-MSFT @msftclas