Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete NSScanner stubs #2083

Closed
rajsesh opened this issue Feb 24, 2017 · 0 comments
Closed

complete NSScanner stubs #2083

rajsesh opened this issue Feb 24, 2017 · 0 comments
Assignees
@ms-jihua
Labels
Area-Foundation Task
Milestone
1704

Comments

@rajsesh
Copy link
Contributor

rajsesh commented Feb 24, 2017 •
edited
Loading

locale
copyWithZone:
localizedScannerWithString:
scanDecimal:
scanHexDouble:
scanHexFloat:
localizedScannerWithString:
@rajsesh rajsesh added this to the 1705 milestone Feb 24, 2017
@rajsesh rajsesh mentioned this issue Mar 29, 2017
Closed
@rajsesh rajsesh assigned ms-jihua and unassigned aballway Mar 29, 2017
@rajsesh rajsesh modified the milestones: 1704, 1705 Mar 29, 2017
ms-jihua added a commit to ms-jihua/WinObjC that referenced this issue Apr 20, 2017
@ms-jihua
Complete implementation of NSScanner
658f544 
- Implemented the following functions/properties:
	- locale
	- copyWithZone:
	- localizedScannerWithString:
	- scanDecimal:
	- scanHexDouble:
	- scanHexFloat:
- Added unit tests for NSScanner (there were none, including for previously implemented features)
- Fixed a number of edge cases that were incorrect

Fixes microsoft#2083
@ms-jihua ms-jihua mentioned this issue Apr 20, 2017
Merged
ms-jihua added a commit to ms-jihua/WinObjC that referenced this issue Apr 22, 2017
@ms-jihua
Complete implementation of NSScanner
3477caa 
- Implemented the following functions/properties:
	- locale
	- copyWithZone:
	- localizedScannerWithString:
	- scanDecimal:
	- scanHexDouble:
	- scanHexFloat:
- Added unit tests for NSScanner (there were none, including for previously implemented features)
- Fixed a number of edge cases that were incorrect

Fixes microsoft#2083
ms-jihua added a commit to ms-jihua/WinObjC that referenced this issue Apr 24, 2017
@ms-jihua
Complete implementation of NSScanner
20730a3 
- Implemented the following functions/properties:
	- locale
	- copyWithZone:
	- localizedScannerWithString:
	- scanDecimal:
	- scanHexDouble:
	- scanHexFloat:
- Added unit tests for NSScanner (there were none, including for previously implemented features)
- Fixed a number of edge cases that were incorrect

Fixes microsoft#2083
ms-jihua added a commit to ms-jihua/WinObjC that referenced this issue Apr 27, 2017
@ms-jihua
Complete implementation of NSScanner
57b643e 
- Implemented the following functions/properties:
	- locale
	- copyWithZone:
	- localizedScannerWithString:
	- scanDecimal:
	- scanHexDouble:
	- scanHexFloat:
- Added unit tests for NSScanner (there were none, including for previously implemented features)
- Fixed a number of edge cases that were incorrect

Fixes microsoft#2083
ms-jihua added a commit that referenced this issue Apr 27, 2017
@ms-jihua
Complete implementation of NSScanner (#2582)
dcdc18d 
* Complete implementation of NSScanner
- Implemented the following functions/properties:
	- locale
	- copyWithZone:
	- localizedScannerWithString:
	- scanDecimal:
	- scanHexDouble:
	- scanHexFloat:
- Added unit tests for NSScanner (there were none, including for previously implemented features)
- Fixed a number of edge cases that were incorrect

Fixes #2083

* - Rewrote most NSScanner scan<Numeric> or <HexNumeric> functions using CRT functions
- Changed NSScanner to prefetch all characters in the string at init
- Added tests that check for differing behaviors between 32-bit and 64-bit types
- Misc CR feedback

* - CR feedback
- Renamed the states in scanHexDouble to reflect the current expected state rather than previous state

* rebased, made NSInteger safer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ms-jihua ms-jihua

Labels
Area-Foundation Task
Projects
None yet
Milestone
1704
Development

No branches or pull requests
3 participants
@aballway @rajsesh @ms-jihua