Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CpsExtension sample to Dev 17, extending existing rule, fixes #376

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Updating CpsExtension sample to Dev 17, extending existing rule, fixes #376

merged 4 commits into from
Apr 24, 2024

Conversation

adrianvmsft
Copy link
Member

@adrianvmsft adrianvmsft commented Apr 19, 2024 •
edited
Loading

  • Update the project to Dev 17
  • Adding rule showing how to add a custom property to a Compile item in SDK-style project
  • Fixing an issue that was causing a Non Fatal Exception (NFE displayed as yellow bar) due to MEF failing to instantiate the CustomDebugger class due to using the ImportingConstructor attribute from the wrong namespace
  • Adding a workaround to copy the rule files to the output folder (being skipped by MSBuild)
  • Fixing an issue that was causing extra assemblies to be embedded within the vsix
  • Updating documentation

drewnoakes
drewnoakes approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

samples/CpsExtension/CpsExtension.Vsix/CpsExtension.Vsix.csproj Show resolved Hide resolved
samples/CpsExtension/CpsExtension.Vsix/Properties/launchSettings.json Show resolved Hide resolved
samples/CpsExtension/CpsExtension.Vsix/source.extension.vsixmanifest Show resolved Hide resolved
@adrianvmsft adrianvmsft merged commit ceb5f28 into microsoft:master Apr 24, 2024
2 checks passed
@adrianvmsft adrianvmsft deleted the UpdateCpsExtensionSample branch April 24, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifengl lifengl lifengl approved these changes

@drewnoakes drewnoakes drewnoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianvmsft @drewnoakes @lifengl