Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up GitHub Actions for PR build #11

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Set up GitHub Actions for PR build #11

merged 6 commits into from
Feb 22, 2023

Conversation

skylarnam
Copy link
Contributor

  • Add a yml file for a PR build step.
  • This only includes the build and test step.

@skylarnam skylarnam changed the title Add a yml file for PR build Set up GitHub Actions for PR build Feb 21, 2023
@tydunkel
Copy link
Member

Is it possible to share any of the build steps, or will we need to maintain the builds separately?

@skylarnam
Copy link
Contributor Author

skylarnam commented Feb 22, 2023 •
edited
Loading

Will we be refactoring later to share yaml?

Do you think we could do that? Seems like the CI yaml we have and GitHub actions yaml have different formats.

tydunkel
tydunkel approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@tydunkel tydunkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/actions-pr.yml Outdated
- name: Install .NET Core SDK
uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify just to use the global.json version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@skylarnam skylarnam merged commit 6d336b2 into main Feb 22, 2023
@skylarnam skylarnam deleted the dev/sknam/add-azure-pipelines-for-build-check branch February 22, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tydunkel tydunkel tydunkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skylarnam @tydunkel