Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TemplateStringsArray immutable. #9561

Merged
merged 4 commits into from
Jul 21, 2016
Merged

Make TemplateStringsArray immutable. #9561

merged 4 commits into from
Jul 21, 2016

Conversation

DanielRosenwasser
Copy link
Member

Both the raw array as well as the cooked array are frozen according to https://tc39.github.io/ecma262/2016/index.html#sec-gettemplateobject

@DanielRosenwasser
Copy link
Member Author

I think this should also be ported to release-2.0.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 7, 2016

@DanielRosenwasser can you look at the failing tests.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 7, 2016

👍

@DanielRosenwasser DanielRosenwasser added the Breaking Change Would introduce errors in existing code label Jul 8, 2016
@DanielRosenwasser DanielRosenwasser merged commit 6e4dd75 into master Jul 21, 2016
@DanielRosenwasser DanielRosenwasser deleted the tsaImmutable branch July 21, 2016 05:20
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 21, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change Would introduce errors in existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielRosenwasser @mhegazy @msftclas