-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 188: Autocomplete for imports and triple slash reference paths #9353
Merged
+1,800
−130
Merged
Changes from 40 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
c06b02a
Adding completions for import and reference directives
riknoll ccf27d1
Minor fix
riknoll dbdd989
Import completions for require calls
riknoll 801b493
PR feedback
riknoll f644da7
Merge branch 'master' into import_completions_pr
riknoll 5c24b35
Refactoring node_modules enumeration code
riknoll ffc165e
Fixing behavior of resolvePath
riknoll 5c87c5a
Removing forEach reference
riknoll 84a10e4
Some PR feedback
riknoll ed2da32
Handling more compiler options and minor refactor
riknoll 0b16180
Import completions with rootdirs compiler option
riknoll dbf19f1
Adding import completions for typings
riknoll fdbc23e
Add completions for types triple slash directives
riknoll 4ca7e95
Merge remote-tracking branch 'origin/master' into import_completions_…
riknoll 9e797b4
Use getDirectories and condition node modules resolution on moduleRes…
riknoll 4ec8b2b
Refactoring import completions into their own api
riknoll 98a162b
Replacement spans for import completions
riknoll 35cd480
Fixing import completion spans to only include the end of the directo…
riknoll a5d73bf
No more filtering results
riknoll 8b5a3d9
Refactoring API to remove duplicate spans
riknoll 293ca60
Renamed span to textSpan to better follow other language service APIs
riknoll ca28823
Fixing shim and normalizing paths
riknoll 0f22079
Remove trailing slashes, remove mostly useless IO, fix script element…
riknoll ecdbdb3
Fixing the filtering of nested module completions
riknoll e11d5e9
Cleaning up test cases and adding a few more
riknoll 8a976f1
Moving some utility functions around
riknoll cc35bd5
Merge remote-tracking branch 'origin/master' into import_completions_pr
riknoll 2f4a855
Use rooted paths in the fourslash virtual file system
riknoll 310bce4
Removing resolvePath from language service host
riknoll cf7feb3
Responding to PR feedback
riknoll 473be82
Merge remote-tracking branch 'origin/master' into import_completions_pr
riknoll 00facc2
Removing hasProperty check
riknoll 0ebd196
Fixing regex for triple slash references
riknoll c71c5a8
Using for..of instead of forEach
riknoll 34847f0
Making language service host changes optional
riknoll 276b56d
More PR feedback
riknoll fb6ff42
Reuse effective type roots code in language service
riknoll b9b79af
Recombining import completions and regular completion APIs
riknoll 7261866
Cleaning up the completion code and tests
riknoll c742d16
Merge remote-tracking branch 'origin/master' into import_completions_pr
riknoll 8728b98
Adding comment and removing unnecessary object creation
riknoll a26d310
Merge remote-tracking branch 'origin/master' into import_completions_pr
riknoll 8f0c7ef
Pass the right host to getEffectiveTyperoots
riknoll 548e143
Merge remote-tracking branch 'origin/master' into import_completions_pr
riknoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was copying the behavior where we access the modules elsewhere in the checker (see
resolveExternalModuleNameWorker()
)