Merge JSDoc of assignments from function expressions #9010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //// return s.length; | ||
| ////} | ||
| ////assig/*34*/ned/*35*/(/*36*/"hey"); | ||
|
|
There was a problem hiding this comment.
Can you move this into a separate file? These tests are specific enough and it would lend well to pinpointing future issues if they start failing.
There was a problem hiding this comment.
I'll see if I can break it up even more.
There was a problem hiding this comment.
done. I split it in half -- one for testing function declarations and one for function expressions. There's still a lot of redundancy in there, but testing => vs function might someday expose a bug. I guess.
|
Looks good |
And renumber.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7586
@RyanCavanaugh I'm not sure this is the correct direction for this fix. Can you take a look?