Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration expressions #8595

Merged
4 commits merged into from
May 17, 2016
Merged

Declaration expressions #8595

4 commits merged into from
May 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2016

Fixes #4481

Broken into 2 commits. The second commit, which does deep searching for declarations, may have a performance impact.

@msftclas
Copy link

Hi @andy-ms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andy Hanson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

////console.log(function inner() {})


// Search for properties defined in the constructor, but not other constructor paramters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is not accurate.

@ghost ghost force-pushed the declaration_expressions branch from ca1e787 to 67beb00 Compare May 13, 2016 19:57
@ghost ghost assigned mhegazy May 17, 2016
@mhegazy
Copy link
Contributor

mhegazy commented May 17, 2016

👍

@ghost ghost merged commit cb6e444 into master May 17, 2016
@ghost ghost deleted the declaration_expressions branch May 17, 2016 19:36
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants