Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8482: Add Object.values and Object.entries #8538

Merged
merged 9 commits into from
May 10, 2016
Merged

Fix 8482: Add Object.values and Object.entries #8538

merged 9 commits into from
May 10, 2016

Conversation

yuit
Copy link
Contributor

@yuit yuit commented May 9, 2016

Fix #8482

@mhegazy
Copy link
Contributor

mhegazy commented May 9, 2016

should we add lib.es2017.d.ts?

@yuit
Copy link
Contributor Author

yuit commented May 9, 2016

@mhegazy we probably should but then I think we should add target es2017 then?

@mhegazy
Copy link
Contributor

mhegazy commented May 10, 2016

we do not have an es2016 target yet.

@mhegazy
Copy link
Contributor

mhegazy commented May 10, 2016

👍

@@ -0,0 +1,9 @@
// @target: es6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// @lib: ess6,es2017.object would make this file compile without errors, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@sandersn
Copy link
Member

👍 after adding a test case

@yuit yuit merged commit b68e939 into master May 10, 2016
@yuit yuit deleted the fix8482 branch May 10, 2016 21:22
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants