feat: allow explicit ScriptKind extraFileExtensions #60178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
When configuring the language service host with extra file extensions, the file extension is only regarded as supported if its `Deferred` or like JS. If the host can delare a specific ScriptKind such as `TSX` for a file then it will be stripped out with getSupportedExtensions. This then later causes the programs rootFiles to not include the extra file extension, and thus be excluded from the program. If using `Deferred` then the file when parsed will be treated as TS and fail to compile when using (J)TSX syntax. In majority of cases the script kind will be known by the consumer and they can set the explicit script kind for the extra file extension. Adjust the logic for `getSupportedExtensions` to include any extra file extension that are not built in. This way all explicit extra file extensions added will be included in the project/programs root files and an explicit `scriptKind` can be set. resolves: microsoft#60125
blake-newman
force-pushed
the
blake.newman/prevent-extra-file-extensions-being-stripped-out
branch
from
c275e28
to
f8cc8c7
Compare
|
@microsoft-github-policy-service agree company="Attest Technologies Limited" |
|
The TypeScript team hasn't accepted the linked issue #60125. If you can get it accepted, this PR will have a better chance of being reviewed. |
blake-newman
commented
Oct 10, 2024
| @@ -595,7 +603,8 @@ Info seq [hh:mm:ss:mss] Creating ConfiguredProject: /user/username/projects/pro | |||
| Info seq [hh:mm:ss:mss] FileWatcher:: Added:: WatchInfo: /user/username/projects/project/tsconfig.json 2000 undefined Project: /user/username/projects/project/tsconfig.json WatchType: Config file | |||
| Info seq [hh:mm:ss:mss] Config: /user/username/projects/project/tsconfig.json : { | |||
| "rootNames": [ | |||
| "/user/username/projects/project/f1.ts" | |||
| "/user/username/projects/project/f1.ts", | |||
| "/user/username/projects/project/f2.html" | |||
There was a problem hiding this comment.
This seems to be legit, based on the issue. Extensions marked as anything but Deferred where not considered as part of the root of project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the language service host with extra file extensions, the file extension is only regarded as supported if its
Deferredor like JS. If the host can delare a specific ScriptKind such asTSXfor a file then it will be stripped out with getSupportedExtensions.This then later causes the programs rootFiles to not include the extra file extension, and thus be excluded from the program.
If using
Deferredthen the file when parsed will be treated as TS and fail to compile when using (J)TSX syntax. In majority of cases the script kind will be known by the consumer and they can set the explicit script kind for the extra file extension.Adjust the logic for
getSupportedExtensionsto include any extra file extension that are not built in. This way all explicit extra file extensions added will be included in the project/programs root files and an explicitscriptKindcan be set.Fixes #60125