[WIP] Experimental Slim `AstNode` API #59992

rbuckton · 2024-09-17T19:20:07Z

This adds an experimental "slim" API for AST nodes that is intended to be highly monomorphic while maintaining the existing public API. This will also allow for gradual adoption of the new slim API internally.

This is a very early proof-of-concept designed to test the ramifications of this change and whether they will be beneficial to compiler performance long-term. The general principle of the change is that compiler internals will no longer depend on the highly polymorphic Node type, and instead depend on a slimmer AstNode class with a fixed layout that is roughly the following:

class AstNode<N extends Node> {
  // lazy-initialized extra fields for a node (id, original, emitNode, transformFlags, 
  // modifierFlagsCache, etc.)
  private _extra: AstNodeExtraFields | undefined;
  
  // Constructor used to produce a `Node` facade for the public API
  private _nodeConstructor: (new (ast: AstNode<N>) => N) | undefined;
  
  // Lazy-initialized `Node` facade for the public API
  private _node: N | undefined;

  kind: N["kind"];
  data: N["data"];
  parent: AstNode | undefined;
  flags: NodeFlags;
  pos: number;
  end: number;

  constructor(kind: N["kind"], data: N["data"], nodeConstructor: new (ast: AstNode<N>) => N) {
    ...
  }

  // lazy-initializes the `Node` facade for this AstNode
  get node() { ... }

  // lazy-initialized properties of an AstNode
  get id() { ... }
  set id(value) { ... }
  get original() { ... }
  set original(value) { ... }
  get emitNode() { ... }
  set emitNode(value) { ... }
  get transformFlags() { ... }
  set transformFlags(value) { ... }
}

This "slim" node is designed to be small and allow for monomorphic access to the most common shared properties of our AST nodes. In place of the existing Node type, the public API would surface a facade based on something like this definition of Node:

class Node<K extends SyntaxKind, T extends AstData> {
  /** @internal */ readonly ast: AstNode<Node<K, T>>;

  constructor(ast: AstNode<Node<K, T>>) {
    this.ast = ast;
  }

  /** @internal */ get data(): T { return this.ast.data; }

  get kind(): K { return this.ast.kind; }
  get pos() { return this.ast.pos; }
  get end() { return this.ast.end; }
  get flags() { return this.ast.flags; }
  get parent() { return this.ast.parent; }
  get id() { return this.ast.id; }
  // etc.
}

Node-specific fields will live in objects held by the data property, such as this class that describes a BinaryExpression:

class AstBinaryExpressionData extends AstData {
  left!: AstNode<Expression>;
  operatorToken!: AstNode<BinaryOperatorToken>;
  right!: AstNode<Expression>;
  // etc.
}

While the BinaryExpression we provide today would be replaced by a facade:

class BinaryExpression extends Node<SyntaxKind.BinaryExpression, AstBinaryExpressionData> {
  declare _expressionBrand: any;
  declare _declarationBrand: any;
  declare _jsdocContainerBrand: any;

  /** @internal */ declare readonly ast: AstBinaryExpression;

  get left() { return this.ast.data.left?.node; }
  set left(value) { this.ast.data.left = value?.ast; }
  get operatorToken() { return this.ast.data.operatorToken?.node; }
  set operatorToken(value) { this.ast.data.operatorToken = value?.ast; }
  get right() { return this.ast.data.right?.node; }
  set right(value) { this.ast.data.right = value?.ast; }
  // etc.
}

type AstBinaryExpression = AstNode<BinaryExpression>;

Work on this PR is expected to progress in stages. Until work has progressed far enough along, we expect performance numbers to be much worse before they get better due to the overhead from the compiler internals relying on the facade vs the slim node.

There will hopefully be some additional benefits to this change if it shows promise:

Removes use of objectAllocator for node constructors
Moves all language service Node extensions to the compiler (e.g., no more NodeObject)
Common structure of AstNode could allow for more efficient encodings of pos/end/flags/etc.
Potentially easy to swap out internally with shared structs in the future.

TODO

Initial "slim" AstNode implementation
Minimal AstNode version of NodeFactory and ParenthesizerRules
Redirect NodeFactory and ParenthesizerRules to leverage AstNode-versions
Migrate parser.ts to use AstNode
Migrate binder.ts to use AstNode
Migrate checker.ts to use AstNode
Migrate transformers to use AstNode
Migrate emitter.ts to use AstNode
Migrate language service to use AstNode

Related #59190
Related #58928
Related #51682
Related #51913

typescript-bot · 2024-09-17T19:20:25Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

rbuckton · 2024-09-17T19:23:07Z

@typescript-bot perf test
@typescript-bot test top400
@typescript-bot test tsserver top100
@typescript-bot user test this
@typescript-bot user test tsserver

typescript-bot · 2024-09-17T19:23:11Z

Hey @rbuckton, this PR is in an unmergable state, so is missing a merge commit to run against; please resolve conflicts and try again.

rbuckton · 2024-09-17T20:20:15Z

@typescript-bot perf test
@typescript-bot test top400
@typescript-bot test tsserver top100
@typescript-bot user test this
@typescript-bot user test tsserver

typescript-bot · 2024-09-17T20:20:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results
`test top400`	✅ Started	✅ Results
`test tsserver top100`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`user test tsserver`	✅ Started	✅ Results

typescript-bot · 2024-09-17T20:40:22Z

@rbuckton Here are the results of running the user tests with tsserver comparing main and refs/pull/59992/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2024-09-17T20:46:24Z

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/59992/merge:

Everything looks good!

typescript-bot · 2024-09-17T21:19:04Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,087k (± 0.76%)}	_{263,539k (± 0.02%)}	_{🔻+70,452k (+36.49%)}	_263,476k	_263,599k	_{p=0.005 n=6}
_{Parse Time}	_{1.31s (± 0.93%)}	_1.77s	_{🔻+0.46s (+35.46%)}	_~	_~	_{p=0.003 n=6}
_{Bind Time}	_0.71s	_{1.13s (± 0.36%)}	_{🔻+0.42s (+58.92%)}	_1.12s	_1.13s	_{p=0.002 n=6}
_{Check Time}	_{9.54s (± 0.38%)}	_{11.72s (± 0.47%)}	_{🔻+2.18s (+22.83%)}	_11.63s	_11.78s	_{p=0.005 n=6}
_{Emit Time}	_{2.73s (± 0.95%)}	_{4.05s (± 0.31%)}	_{🔻+1.32s (+48.53%)}	_4.03s	_4.06s	_{p=0.005 n=6}
_{Total Time}	_{14.28s (± 0.15%)}	_{18.67s (± 0.26%)}	_{🔻+4.38s (+30.68%)}	_18.59s	_18.72s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,737k (± 0.00%)}	_{1,670,641k (± 0.01%)}	_{🔻+447,904k (+36.63%)}	_1,670,496k	_1,670,735k	_{p=0.005 n=6}
_{Parse Time}	_{7.93s (± 0.52%)}	_{11.97s (± 0.58%)}	_{🔻+4.04s (+50.95%)}	_11.88s	_12.03s	_{p=0.005 n=6}
_{Bind Time}	_{2.22s (± 0.54%)}	_{4.09s (± 0.45%)}	_{🔻+1.87s (+84.03%)}	_4.06s	_4.11s	_{p=0.005 n=6}
_{Check Time}	_{36.45s (± 0.29%)}	_{50.23s (± 0.33%)}	_{🔻+13.78s (+37.81%)}	_50.02s	_50.43s	_{p=0.005 n=6}
_{Emit Time}	_{17.90s (± 0.31%)}	_{26.21s (± 0.38%)}	_{🔻+8.32s (+46.47%)}	_26.08s	_26.32s	_{p=0.005 n=6}
_{Total Time}	_{64.49s (± 0.18%)}	_{92.51s (± 0.18%)}	_{🔻+28.01s (+43.43%)}	_92.28s	_92.66s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,520,551	_2,520,551	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,995	_935,995	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,350,355k (± 0.00%)}	_{2,729,076k (± 0.00%)}	_{🔻+378,721k (+16.11%)}	_2,728,900k	_2,729,237k	_{p=0.005 n=6}
_{Parse Time}	_{11.02s (± 0.51%)}	_{14.85s (± 0.29%)}	_{🔻+3.83s (+34.79%)}	_14.80s	_14.92s	_{p=0.005 n=6}
_{Bind Time}	_{2.56s (± 0.80%)}	_{4.47s (± 0.33%)}	_{🔻+1.91s (+74.66%)}	_4.45s	_4.49s	_{p=0.005 n=6}
_{Check Time}	_{86.26s (± 0.34%)}	_{105.84s (± 2.23%)}	_{🔻+19.58s (+22.70%)}	_104.54s	_110.63s	_{p=0.005 n=6}
_{Emit Time}	_{0.33s (± 2.71%)}	_0.34s	_{+0.01s (+ 3.03%)}	_~	_~	_{p=0.028 n=6}
_{Total Time}	_{100.17s (± 0.35%)}	_{125.51s (± 1.90%)}	_{🔻+25.34s (+25.30%)}	_124.24s	_130.36s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,428,855	_{🔻+182,903 (+14.68%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,478	_{🔻+13,265 (+ 5.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,397,953k (± 0.05%)}	_{3,390,884k (± 0.02%)}	_{🔻+992,932k (+41.41%)}	_3,389,986k	_3,391,681k	_{p=0.005 n=6}
_{Parse Time}	_{6.07s (± 0.44%)}	_{10.22s (± 0.47%)}	_{🔻+4.15s (+68.36%)}	_10.18s	_10.29s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 1.00%)}	_{4.34s (± 0.58%)}	_{🔻+2.08s (+92.32%)}	_4.30s	_4.37s	_{p=0.005 n=6}
_{Check Time}	_{41.37s (± 0.73%)}	_{57.08s (± 0.98%)}	_{🔻+15.71s (+37.97%)}	_56.36s	_57.66s	_{p=0.005 n=6}
_{Emit Time}	_{3.61s (± 3.38%)}	_{5.02s (± 0.87%)}	_{🔻+1.41s (+39.17%)}	_4.95s	_5.08s	_{p=0.005 n=6}
_{Total Time}	_{53.31s (± 0.35%)}	_{76.68s (± 0.67%)}	_{🔻+23.37s (+43.83%)}	_75.96s	_77.25s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,428,855	_{🔻+182,903 (+14.68%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,478	_{🔻+13,265 (+ 5.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,472,518k (± 0.01%)}	_{3,514,815k (± 2.44%)}	_{🔻+1,042,297k (+42.16%)}	_3,479,298k	_3,690,236k	_{p=0.005 n=6}
_{Parse Time}	_{7.89s (± 0.59%)}	_{13.01s (± 0.55%)}	_{🔻+5.12s (+64.95%)}	_12.92s	_13.11s	_{p=0.005 n=6}
_{Bind Time}	_{2.53s (± 0.72%)}	_{5.31s (± 0.71%)}	_{🔻+2.78s (+110.09%)}	_5.26s	_5.37s	_{p=0.005 n=6}
_{Check Time}	_{51.21s (± 0.93%)}	_{71.22s (± 0.19%)}	_{🔻+20.02s (+39.09%)}	_71.06s	_71.41s	_{p=0.005 n=6}
_{Emit Time}	_{4.52s (± 3.40%)}	_{6.18s (± 0.32%)}	_{🔻+1.67s (+36.85%)}	_6.15s	_6.20s	_{p=0.005 n=6}
_{Total Time}	_{66.14s (± 0.55%)}	_{95.76s (± 0.16%)}	_{🔻+29.61s (+44.77%)}	_95.50s	_95.91s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_331,296	_{🔻+71,411 (+27.48%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_119,398	_{🔻+13,258 (+12.49%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,581k (± 0.01%)}	_{680,639k (± 0.01%)}	_{🔻+245,058k (+56.26%)}	_680,542k	_680,759k	_{p=0.005 n=6}
_{Parse Time}	_{4.24s (± 0.53%)}	_{6.45s (± 0.51%)}	_{🔻+2.21s (+52.08%)}	_6.42s	_6.49s	_{p=0.005 n=6}
_{Bind Time}	_{1.61s (± 0.47%)}	_{2.93s (± 0.84%)}	_{🔻+1.32s (+82.18%)}	_2.91s	_2.97s	_{p=0.005 n=6}
_{Check Time}	_{22.42s (± 0.19%)}	_{33.36s (± 0.28%)}	_{🔻+10.94s (+48.79%)}	_33.24s	_33.48s	_{p=0.005 n=6}
_{Emit Time}	_{1.88s (± 0.78%)}	_{3.34s (± 0.69%)}	_{🔻+1.46s (+77.73%)}	_3.31s	_3.37s	_{p=0.005 n=6}
_{Total Time}	_{30.14s (± 0.17%)}	_{46.08s (± 0.26%)}	_{🔻+15.93s (+52.85%)}	_45.94s	_46.29s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,239k (± 0.02%)}	_{495,006k (± 0.01%)}	_{🔻+124,767k (+33.70%)}	_494,975k	_495,074k	_{p=0.005 n=6}
_{Parse Time}	_{2.75s (± 0.99%)}	_{3.90s (± 0.56%)}	_{🔻+1.15s (+41.90%)}	_3.86s	_3.92s	_{p=0.005 n=6}
_{Bind Time}	_{1.55s (± 1.03%)}	_{2.37s (± 0.64%)}	_{🔻+0.82s (+52.74%)}	_2.34s	_2.38s	_{p=0.005 n=6}
_{Check Time}	_{15.73s (± 0.18%)}	_{21.10s (± 0.24%)}	_{🔻+5.37s (+34.12%)}	_21.04s	_21.15s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.03s (± 0.23%)}	_{27.36s (± 0.15%)}	_{🔻+7.33s (+36.61%)}	_27.30s	_27.40s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,071,638	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,060,266	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,175,799k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{17.11s (± 0.25%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{5.30s (± 0.44%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{99.16s (± 0.59%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{28.12s (± 7.42%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{149.69s (± 1.17%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,157	_277,157	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,949	_112,949	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,908k (± 0.01%)}	_{539,573k (± 0.01%)}	_{🔻+112,665k (+26.39%)}	_539,532k	_539,626k	_{p=0.005 n=6}
_{Parse Time}	_{3.96s (± 0.43%)}	_{5.30s (± 0.40%)}	_{🔻+1.34s (+33.74%)}	_5.26s	_5.32s	_{p=0.005 n=6}
_{Bind Time}	_{1.74s (± 1.12%)}	_{2.70s (± 0.80%)}	_{🔻+0.96s (+55.03%)}	_2.67s	_2.72s	_{p=0.005 n=6}
_{Check Time}	_{17.67s (± 0.29%)}	_{22.83s (± 0.24%)}	_{🔻+5.16s (+29.22%)}	_22.77s	_22.90s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.37s (± 0.32%)}	_{30.82s (± 0.24%)}	_{🔻+7.45s (+31.88%)}	_30.76s	_30.93s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,582	_531,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,676	_181,676	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,664k (± 0.01%)}	_{548,851k (± 0.01%)}	_{🔻+85,187k (+18.37%)}	_548,810k	_548,878k	_{p=0.005 n=6}
_{Parse Time}	_{2.60s (± 0.31%)}	_{3.59s (± 0.23%)}	_{🔻+0.98s (+37.77%)}	_3.58s	_3.60s	_{p=0.004 n=6}
_{Bind Time}	_0.93s	_{1.53s (± 0.53%)}	_{🔻+0.60s (+64.16%)}	_1.52s	_1.54s	_{p=0.003 n=6}
_{Check Time}	_{15.41s (± 0.24%)}	_{17.97s (± 0.21%)}	_{🔻+2.56s (+16.61%)}	_17.93s	_18.02s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.95s (± 0.19%)}	_{23.09s (± 0.14%)}	_{🔻+4.14s (+21.84%)}	_23.04s	_23.13s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,297ms (± 0.52%)}	_{3,187ms (± 0.35%)}	_{🔻+890ms (+38.74%)}	_3,165ms	_3,196ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,164ms (± 0.45%)}	_{6,581ms (± 0.67%)}	_{🔻+1,417ms (+27.44%)}	_6,544ms	_6,660ms	_{p=0.005 n=6}
_{Req 3 - references}	_{263ms (± 0.96%)}	_{361ms (± 0.46%)}	_{🔻+98ms (+37.26%)}	_359ms	_363ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{227ms (± 0.36%)}	_{296ms (± 0.35%)}	_{🔻+69ms (+30.37%)}	_294ms	_297ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 7.01%)}	_{85ms (± 7.92%)}	_~	_81ms	_98ms	_{p=0.684 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,415ms (± 1.47%)}	_{3,359ms (± 0.47%)}	_{🔻+944ms (+39.08%)}	_3,341ms	_3,388ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,922ms (± 0.44%)}	_{5,046ms (± 1.41%)}	_{🔻+1,124ms (+28.67%)}	_4,943ms	_5,122ms	_{p=0.005 n=6}
_{Req 3 - references}	_{274ms (± 1.26%)}	_{397ms (± 2.17%)}	_{🔻+123ms (+44.88%)}	_390ms	_413ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{232ms (± 3.02%)}	_{306ms (± 1.47%)}	_{🔻+74ms (+32.04%)}	_297ms	_309ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 8.85%)}	_{84ms (± 1.00%)}	_~	_83ms	_85ms	_{p=0.220 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,193ms (± 0.23%)}	_{7,215ms (± 3.09%)}	_{🔻+2,022ms (+38.95%)}	_7,067ms	_7,516ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,120ms (± 0.37%)}	_{1,263ms (± 0.96%)}	_{🔻+143ms (+12.79%)}	_1,248ms	_1,276ms	_{p=0.005 n=6}
_{Req 3 - references}	_{86ms (± 4.89%)}	_{108ms (± 3.74%)}	_{🔻+22ms (+25.93%)}	_104ms	_112ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{441ms (± 0.24%)}	_{502ms (± 0.96%)}	_{🔻+62ms (+14.00%)}	_496ms	_508ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{840ms (± 1.43%)}	_{895ms (± 1.17%)}	_{🔻+56ms (+ 6.63%)}	_875ms	_903ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{188.86ms (± 0.19%)}	_{212.21ms (± 0.22%)}	_{🔻+23.35ms (+12.36%)}	_208.70ms	_219.53ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.34ms (± 0.12%)}	_{248.96ms (± 0.14%)}	_{🔻+16.62ms (+ 7.15%)}	_247.54ms	_254.80ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.71ms (± 0.14%)}	_{243.82ms (± 0.15%)}	_{🔻+16.11ms (+ 7.07%)}	_242.51ms	_248.92ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.97ms (± 0.14%)}	_{243.14ms (± 0.15%)}	_{🔻+16.18ms (+ 7.13%)}	_241.61ms	_250.40ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-09-17T22:05:44Z

As expected, the facade is significantly slower, though it is quite a bit slower than I was hoping. Hopefully we'll start seeing better numbers once I finish migrating the parser.

typescript-bot · 2024-09-17T22:23:22Z

@rbuckton Here are the results of running the top 200 repos with tsserver comparing main and refs/pull/59992/merge:

Something interesting changed - please have a look.

Details

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

backstage/backstage

Raw error text: RepoResults8/backstage.backstage.rawError.txt in the artifact folder
Replay commands: RepoResults8/backstage.backstage.replay.txt in the artifact folder

Last few requests

{"seq":134,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/scripts/templates/knex-migration.stub.js","line":29,"offset":4,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":135,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/scripts/templates/knex-migration.stub.js","line":29,"offset":4,"entryNames":["@abstract"]}}
{"seq":136,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/scripts/list-backend-feature.js"],"openFiles":[]}}
{"seq":137,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/eslint-plugin/index.js","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

#!/bin/bash

git clone https://github.com/backstage/backstage --recurse-submodules
git -C "./backstage" reset --hard 6f8d71b74ca53b6a62d0ff6325f7849d3b48a822
# Install packages (exact steps are below, but it might be easier to follow the repo readme)
yarn --cwd "./backstage" install --no-immutable --mode=skip-build
yarn --cwd "./backstage/storybook" install --no-immutable --mode=skip-build
yarn --cwd "./backstage/microsite" install --no-immutable --mode=skip-build
downloadUrl=$(curl -s "https://typescript.visualstudio.com/TypeScript/_apis/build/builds/163602/artifacts?artifactName=RepoResults8&api-version=7.0" | jq -r ".resource.downloadUrl")
wget -O RepoResults8.zip "$downloadUrl"
unzip -p RepoResults8.zip RepoResults8/backstage.backstage.replay.txt > backstage.backstage.replay.txt
npm install --no-save @typescript/server-replay

To run the repro:

# `npx tsreplay --help` to learn about helpful switches for debugging, logging, etc.
npx tsreplay ./backstage ./backstage.backstage.replay.txt <PATH_TO_tsserver.js>

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

n8n-io/n8n

Raw error text: RepoResults3/n8n-io.n8n.rawError.txt in the artifact folder
Replay commands: RepoResults3/n8n-io.n8n.replay.txt in the artifact folder

Last few requests

{"seq":995,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/editor-ui/src/Interface.ts","line":1583,"offset":18,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":"'"}}
{"seq":996,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/editor-ui/src/Interface.ts","line":1589,"offset":4}}
{"seq":997,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/nodes-base/credentials/CarbonBlackApi.credentials.ts"],"openFiles":[]}}
{"seq":998,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/design-system/src/plugin.ts","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

#!/bin/bash

git clone https://github.com/n8n-io/n8n --recurse-submodules
git -C "./n8n" reset --hard 989f69d1f4f63d3f0c35341d310bc78914137677
pnpm --dir "./n8n" install --no-frozen-lockfile --prefer-offline --ignore-scripts --reporter=silent
downloadUrl=$(curl -s "https://typescript.visualstudio.com/TypeScript/_apis/build/builds/163602/artifacts?artifactName=RepoResults3&api-version=7.0" | jq -r ".resource.downloadUrl")
wget -O RepoResults3.zip "$downloadUrl"
unzip -p RepoResults3.zip RepoResults3/n8n-io.n8n.replay.txt > n8n-io.n8n.replay.txt
npm install --no-save @typescript/server-replay

To run the repro:

# `npx tsreplay --help` to learn about helpful switches for debugging, logging, etc.
npx tsreplay ./n8n ./n8n-io.n8n.replay.txt <PATH_TO_tsserver.js>

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

remotion-dev/remotion

Raw error text: RepoResults14/remotion-dev.remotion.rawError.txt in the artifact folder
Replay commands: RepoResults14/remotion-dev.remotion.replay.txt in the artifact folder

Last few requests

{"seq":256,"type":"request","command":"navbar","arguments":{"file":"@PROJECT_ROOT@/packages/cli/remotionb-cli.js"}}
{"seq":257,"type":"request","command":"updateOpen","arguments":{"changedFiles":[{"fileName":"@PROJECT_ROOT@/packages/cli/remotionb-cli.js","textChanges":[{"newText":" //comment","start":{"line":1,"offset":19},"end":{"line":1,"offset":19}}]}],"closedFiles":[],"openFiles":[]}}
{"seq":258,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/compositor-linux-x64-gnu/index.js"],"openFiles":[]}}
{"seq":259,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/astro-example/test.js","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

#!/bin/bash

git clone https://github.com/remotion-dev/remotion --recurse-submodules
git -C "./remotion" reset --hard 6acfd716dc5e3bad7efd4414a7392455694ed00b
pnpm --dir "./remotion" install --no-frozen-lockfile --prefer-offline --ignore-scripts --reporter=silent
downloadUrl=$(curl -s "https://typescript.visualstudio.com/TypeScript/_apis/build/builds/163602/artifacts?artifactName=RepoResults14&api-version=7.0" | jq -r ".resource.downloadUrl")
wget -O RepoResults14.zip "$downloadUrl"
unzip -p RepoResults14.zip RepoResults14/remotion-dev.remotion.replay.txt > remotion-dev.remotion.replay.txt
npm install --no-save @typescript/server-replay

To run the repro:

# `npx tsreplay --help` to learn about helpful switches for debugging, logging, etc.
npx tsreplay ./remotion ./remotion-dev.remotion.replay.txt <PATH_TO_tsserver.js>

elastic/kibana

Raw error text: RepoResults14/elastic.kibana.rawError.txt in the artifact folder
Replay commands: RepoResults14/elastic.kibana.replay.txt in the artifact folder

Last few requests

{"seq":96,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/kbn-cli-dev-mode/jest.integration.config.js","line":11,"offset":12}}
{"seq":97,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/kbn-cli-dev-mode/jest.integration.config.js","line":11,"offset":12}}
{"seq":98,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/kbn-telemetry-tools/jest.config.js"],"openFiles":[]}}
{"seq":99,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/x-pack/test/upgrade_assistant_integration/config.js","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

#!/bin/bash

git clone https://github.com/elastic/kibana --recurse-submodules
git -C "./kibana" reset --hard 48f6f945bef098cd5ef667b7e6a01dd2182b6698
downloadUrl=$(curl -s "https://typescript.visualstudio.com/TypeScript/_apis/build/builds/163602/artifacts?artifactName=RepoResults14&api-version=7.0" | jq -r ".resource.downloadUrl")
wget -O RepoResults14.zip "$downloadUrl"
unzip -p RepoResults14.zip RepoResults14/elastic.kibana.replay.txt > elastic.kibana.replay.txt
npm install --no-save @typescript/server-replay

To run the repro:

# `npx tsreplay --help` to learn about helpful switches for debugging, logging, etc.
npx tsreplay ./kibana ./elastic.kibana.replay.txt <PATH_TO_tsserver.js>

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

withfig/autocomplete

Raw error text: RepoResults10/withfig.autocomplete.rawError.txt in the artifact folder
Replay commands: RepoResults10/withfig.autocomplete.replay.txt in the artifact folder

Last few requests

{"seq":274,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/ykman.ts","line":1137,"offset":19,"entryNames":["configModeGenerator"]}}
{"seq":275,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/ykman.ts","line":1174,"offset":23}}
{"seq":276,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/ykman.ts","line":1183,"offset":29,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":"\""}}
{"seq":277,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/ykman.ts","line":1252,"offset":15}}

Repro steps

#!/bin/bash

git clone https://github.com/withfig/autocomplete --recurse-submodules
git -C "./autocomplete" reset --hard 35977c9b68cecd1755b6c9c09d85f8d567ddedb9
pnpm --dir "./autocomplete" install --no-frozen-lockfile --prefer-offline --ignore-scripts --reporter=silent
downloadUrl=$(curl -s "https://typescript.visualstudio.com/TypeScript/_apis/build/builds/163602/artifacts?artifactName=RepoResults10&api-version=7.0" | jq -r ".resource.downloadUrl")
wget -O RepoResults10.zip "$downloadUrl"
unzip -p RepoResults10.zip RepoResults10/withfig.autocomplete.replay.txt > withfig.autocomplete.replay.txt
npm install --no-save @typescript/server-replay

To run the repro:

# `npx tsreplay --help` to learn about helpful switches for debugging, logging, etc.
npx tsreplay ./autocomplete ./withfig.autocomplete.replay.txt <PATH_TO_tsserver.js>

typescript-bot · 2024-09-17T22:28:46Z

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59992/merge:

Everything looks good!

rbuckton · 2024-09-18T13:56:29Z

@typescript-bot perf test

typescript-bot · 2024-09-18T13:56:33Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-09-18T14:56:14Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,850k (± 0.90%)}	_{264,879k (± 0.72%)}	_{🔻+70,030k (+35.94%)}	_263,605k	_267,413k	_{p=0.005 n=6}
_{Parse Time}	_{1.57s (± 1.12%)}	_{2.11s (± 1.35%)}	_{🔻+0.54s (+34.72%)}	_2.06s	_2.14s	_{p=0.004 n=6}
_{Bind Time}	_{0.85s (± 1.61%)}	_{1.32s (± 0.48%)}	_{🔻+0.47s (+54.39%)}	_1.31s	_1.33s	_{p=0.004 n=6}
_{Check Time}	_{11.38s (± 0.20%)}	_{13.89s (± 0.53%)}	_{🔻+2.51s (+22.06%)}	_13.76s	_13.96s	_{p=0.005 n=6}
_{Emit Time}	_{3.24s (± 0.45%)}	_{4.84s (± 0.95%)}	_{🔻+1.60s (+49.36%)}	_4.76s	_4.88s	_{p=0.005 n=6}
_{Total Time}	_{17.04s (± 0.29%)}	_{22.16s (± 0.58%)}	_{🔻+5.12s (+30.02%)}	_21.93s	_22.28s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,749k (± 0.01%)}	_{1,670,645k (± 0.00%)}	_{🔻+447,896k (+36.63%)}	_1,670,595k	_1,670,728k	_{p=0.005 n=6}
_{Parse Time}	_{7.89s (± 0.74%)}	_{11.92s (± 0.59%)}	_{🔻+4.04s (+51.24%)}	_11.85s	_12.04s	_{p=0.005 n=6}
_{Bind Time}	_{2.21s (± 0.40%)}	_{4.04s (± 0.29%)}	_{🔻+1.83s (+82.73%)}	_4.02s	_4.05s	_{p=0.005 n=6}
_{Check Time}	_{36.22s (± 0.39%)}	_{49.78s (± 0.38%)}	_{🔻+13.55s (+37.42%)}	_49.51s	_50.08s	_{p=0.005 n=6}
_{Emit Time}	_{17.88s (± 0.51%)}	_{26.06s (± 0.49%)}	_{🔻+8.18s (+45.75%)}	_25.87s	_26.18s	_{p=0.005 n=6}
_{Total Time}	_{64.19s (± 0.22%)}	_{91.80s (± 0.34%)}	_{🔻+27.61s (+43.02%)}	_91.33s	_92.25s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,156	_2,529,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,017	_936,017	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,302k (± 0.00%)}	_{2,745,907k (± 0.01%)}	_{🔻+381,605k (+16.14%)}	_2,745,531k	_2,746,195k	_{p=0.005 n=6}
_{Parse Time}	_{11.16s (± 0.29%)}	_{15.08s (± 1.60%)}	_{🔻+3.92s (+35.14%)}	_14.87s	_15.56s	_{p=0.005 n=6}
_{Bind Time}	_{2.61s (± 0.40%)}	_{4.55s (± 0.32%)}	_{🔻+1.94s (+74.49%)}	_4.52s	_4.56s	_{p=0.004 n=6}
_{Check Time}	_{86.33s (± 0.70%)}	_{106.45s (± 2.04%)}	_{🔻+20.12s (+23.30%)}	_104.84s	_110.25s	_{p=0.005 n=6}
_{Emit Time}	_{0.33s (± 1.24%)}	_{0.34s (± 3.42%)}	_{🔻+0.01s (+ 4.06%)}	_0.33s	_0.36s	_{p=0.025 n=6}
_{Total Time}	_{100.43s (± 0.59%)}	_{126.42s (± 1.65%)}	_{🔻+25.99s (+25.88%)}	_124.79s	_130.15s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,428,767	_{🔻+182,815 (+14.67%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,448	_{🔻+13,235 (+ 5.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,397,820k (± 0.03%)}	_{3,388,854k (± 0.01%)}	_{🔻+991,034k (+41.33%)}	_3,388,250k	_3,389,346k	_{p=0.005 n=6}
_{Parse Time}	_{6.11s (± 0.59%)}	_{10.28s (± 0.42%)}	_{🔻+4.16s (+68.06%)}	_10.22s	_10.33s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 0.78%)}	_{4.30s (± 1.04%)}	_{🔻+2.04s (+90.07%)}	_4.24s	_4.35s	_{p=0.005 n=6}
_{Check Time}	_{41.39s (± 0.52%)}	_{57.04s (± 0.72%)}	_{🔻+15.66s (+37.83%)}	_56.58s	_57.47s	_{p=0.005 n=6}
_{Emit Time}	_{3.56s (± 2.29%)}	_{5.04s (± 0.63%)}	_{🔻+1.48s (+41.53%)}	_4.99s	_5.08s	_{p=0.005 n=6}
_{Total Time}	_{53.34s (± 0.54%)}	_{76.67s (± 0.53%)}	_{🔻+23.33s (+43.75%)}	_76.22s	_77.09s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,428,767	_{🔻+182,815 (+14.67%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,448	_{🔻+13,235 (+ 5.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,472,614k (± 0.02%)}	_{3,477,928k (± 0.01%)}	_{🔻+1,005,314k (+40.66%)}	_3,477,333k	_3,478,364k	_{p=0.005 n=6}
_{Parse Time}	_{7.89s (± 0.44%)}	_{13.00s (± 0.39%)}	_{🔻+5.11s (+64.79%)}	_12.92s	_13.08s	_{p=0.005 n=6}
_{Bind Time}	_{2.52s (± 0.65%)}	_{5.28s (± 0.56%)}	_{🔻+2.76s (+109.25%)}	_5.25s	_5.32s	_{p=0.005 n=6}
_{Check Time}	_{51.26s (± 0.83%)}	_{70.59s (± 0.72%)}	_{🔻+19.33s (+37.70%)}	_69.84s	_71.21s	_{p=0.005 n=6}
_{Emit Time}	_{4.35s (± 1.74%)}	_{6.28s (± 3.26%)}	_{🔻+1.93s (+44.33%)}	_6.11s	_6.68s	_{p=0.005 n=6}
_{Total Time}	_{66.02s (± 0.58%)}	_{95.15s (± 0.40%)}	_{🔻+29.13s (+44.11%)}	_94.55s	_95.59s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_331,208	_{🔻+71,323 (+27.44%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_119,368	_{🔻+13,228 (+12.46%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,589k (± 0.02%)}	_{680,131k (± 0.01%)}	_{🔻+244,543k (+56.14%)}	_680,073k	_680,256k	_{p=0.005 n=6}
_{Parse Time}	_{3.41s (± 0.49%)}	_{5.20s (± 1.10%)}	_{🔻+1.79s (+52.59%)}	_5.16s	_5.31s	_{p=0.005 n=6}
_{Bind Time}	_{1.29s (± 1.26%)}	_{2.33s (± 1.21%)}	_{🔻+1.04s (+80.15%)}	_2.29s	_2.37s	_{p=0.004 n=6}
_{Check Time}	_{18.16s (± 0.39%)}	_{26.83s (± 0.39%)}	_{🔻+8.68s (+47.80%)}	_26.74s	_26.96s	_{p=0.005 n=6}
_{Emit Time}	_{1.53s (± 2.19%)}	_{2.72s (± 0.86%)}	_{🔻+1.19s (+78.00%)}	_2.69s	_2.75s	_{p=0.005 n=6}
_{Total Time}	_{24.39s (± 0.37%)}	_{37.09s (± 0.18%)}	_{🔻+12.70s (+52.09%)}	_36.99s	_37.18s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,253k (± 0.02%)}	_{495,011k (± 0.01%)}	_{🔻+124,758k (+33.70%)}	_494,946k	_495,052k	_{p=0.005 n=6}
_{Parse Time}	_{3.44s (± 1.21%)}	_{4.88s (± 0.90%)}	_{🔻+1.44s (+41.69%)}	_4.82s	_4.95s	_{p=0.005 n=6}
_{Bind Time}	_{1.95s (± 1.07%)}	_{2.94s (± 0.91%)}	_{🔻+0.99s (+50.51%)}	_2.90s	_2.97s	_{p=0.005 n=6}
_{Check Time}	_{19.42s (± 0.50%)}	_{26.01s (± 0.11%)}	_{🔻+6.58s (+33.90%)}	_25.96s	_26.04s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.81s (± 0.32%)}	_{33.82s (± 0.08%)}	_{🔻+9.01s (+36.31%)}	_33.79s	_33.87s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,074,141	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,060,933	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,177,732k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{17.15s (± 0.25%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{5.33s (± 0.83%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{99.32s (± 0.26%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{27.18s (± 0.28%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{148.98s (± 0.19%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,157	_277,157	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,949	_112,949	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,931k (± 0.02%)}	_{539,845k (± 0.02%)}	_{🔻+112,914k (+26.45%)}	_539,746k	_539,977k	_{p=0.005 n=6}
_{Parse Time}	_{3.95s (± 0.69%)}	_{5.29s (± 0.25%)}	_{🔻+1.34s (+33.91%)}	_5.28s	_5.31s	_{p=0.004 n=6}
_{Bind Time}	_{1.72s (± 1.36%)}	_{2.71s (± 0.31%)}	_{🔻+1.00s (+58.16%)}	_2.71s	_2.73s	_{p=0.004 n=6}
_{Check Time}	_{17.63s (± 0.46%)}	_{22.92s (± 0.38%)}	_{🔻+5.28s (+29.95%)}	_22.80s	_23.00s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.30s (± 0.26%)}	_{30.92s (± 0.24%)}	_{🔻+7.62s (+32.68%)}	_30.83s	_31.00s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,594	_531,594	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,677	_181,677	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,716k (± 0.02%)}	_{548,893k (± 0.01%)}	_{🔻+85,177k (+18.37%)}	_548,843k	_548,929k	_{p=0.005 n=6}
_{Parse Time}	_{2.60s (± 0.58%)}	_{3.60s (± 0.48%)}	_{🔻+0.99s (+38.22%)}	_3.58s	_3.62s	_{p=0.005 n=6}
_{Bind Time}	_0.93s	_{1.51s (± 0.50%)}	_{🔻+0.58s (+62.19%)}	_1.50s	_1.52s	_{p=0.003 n=6}
_{Check Time}	_{15.40s (± 0.39%)}	_{17.98s (± 0.26%)}	_{🔻+2.57s (+16.68%)}	_17.91s	_18.01s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.94s (± 0.32%)}	_{23.08s (± 0.26%)}	_{🔻+4.15s (+21.91%)}	_23.00s	_23.14s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,293ms (± 0.22%)}	_{3,148ms (± 0.29%)}	_{🔻+855ms (+37.29%)}	_3,134ms	_3,158ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,177ms (± 0.33%)}	_{6,572ms (± 0.41%)}	_{🔻+1,396ms (+26.96%)}	_6,551ms	_6,623ms	_{p=0.005 n=6}
_{Req 3 - references}	_{262ms (± 0.20%)}	_{391ms (± 0.67%)}	_{🔻+129ms (+49.05%)}	_387ms	_394ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{227ms (± 0.60%)}	_{288ms (± 1.72%)}	_{🔻+61ms (+26.99%)}	_283ms	_293ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 6.68%)}	_{81ms (± 0.63%)}	_~	_81ms	_82ms	_{p=0.365 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,401ms (± 1.03%)}	_{3,341ms (± 0.39%)}	_{🔻+940ms (+39.14%)}	_3,327ms	_3,357ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,920ms (± 0.60%)}	_{5,042ms (± 1.36%)}	_{🔻+1,122ms (+28.63%)}	_4,907ms	_5,095ms	_{p=0.005 n=6}
_{Req 3 - references}	_{274ms (± 1.47%)}	_{403ms (± 3.11%)}	_{🔻+129ms (+47.23%)}	_387ms	_419ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{232ms (± 2.85%)}	_{299ms (± 2.81%)}	_{🔻+67ms (+29.09%)}	_289ms	_307ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 7.87%)}	_{80ms (± 3.31%)}	_~	_77ms	_83ms	_{p=0.064 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,181ms (± 0.25%)}	_{7,148ms (± 2.35%)}	_{🔻+1,967ms (+37.97%)}	_7,040ms	_7,470ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,131ms (± 1.25%)}	_{1,263ms (± 0.92%)}	_{🔻+132ms (+11.63%)}	_1,250ms	_1,277ms	_{p=0.005 n=6}
_{Req 3 - references}	_{87ms (± 2.49%)}	_{106ms (± 3.04%)}	_{🔻+19ms (+21.73%)}	_104ms	_112ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{441ms (± 0.12%)}	_{492ms (± 3.29%)}	_{🔻+51ms (+11.56%)}	_469ms	_511ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{844ms (± 0.91%)}	_{892ms (± 0.89%)}	_{🔻+48ms (+ 5.65%)}	_880ms	_902ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{158.56ms (± 0.19%)}	_{176.19ms (± 0.16%)}	_{🔻+17.63ms (+11.12%)}	_175.13ms	_179.84ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.96ms (± 0.12%)}	_{248.54ms (± 0.13%)}	_{🔻+16.58ms (+ 7.15%)}	_247.30ms	_254.45ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.82ms (± 0.16%)}	_{243.73ms (± 0.15%)}	_{🔻+15.91ms (+ 6.98%)}	_242.52ms	_250.14ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.03ms (± 0.15%)}	_{242.86ms (± 0.14%)}	_{🔻+15.83ms (+ 6.97%)}	_241.54ms	_248.37ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-09-18T15:11:31Z

Being less aggressive with respect to optional chaining in the facade accessors didn't seem to have much of an impact. I suspect the biggest impact is that the per-node constructors are resulting in far more megamorphic ICs. I might be able to address this by duplicating all of the accessors on Node on each of the individual subtypes so that the accessors are monomorphic. I'll push up an experimental commit to test that this afternoon, but I think the major perf improvements will come from migrating the internals to use the monomorphic slim AST.

rbuckton · 2024-09-18T15:29:11Z

@typescript-bot perf test

typescript-bot · 2024-09-18T15:29:14Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-09-18T16:28:47Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,603k (± 0.94%)}	_{265,714k (± 0.58%)}	_{🔻+72,111k (+37.25%)}	_264,930k	_268,878k	_{p=0.005 n=6}
_{Parse Time}	_{1.57s (± 0.94%)}	_{2.15s (± 0.38%)}	_{🔻+0.58s (+37.01%)}	_2.14s	_2.16s	_{p=0.005 n=6}
_{Bind Time}	_{0.85s (± 0.96%)}	_{1.39s (± 1.06%)}	_{🔻+0.54s (+63.09%)}	_1.37s	_1.41s	_{p=0.005 n=6}
_{Check Time}	_{11.37s (± 0.65%)}	_{14.36s (± 0.36%)}	_{🔻+2.99s (+26.32%)}	_14.27s	_14.42s	_{p=0.005 n=6}
_{Emit Time}	_{3.23s (± 0.69%)}	_{5.06s (± 3.15%)}	_{🔻+1.83s (+56.73%)}	_4.99s	_5.39s	_{p=0.005 n=6}
_{Total Time}	_{17.02s (± 0.45%)}	_{22.97s (± 0.76%)}	_{🔻+5.95s (+34.92%)}	_22.78s	_23.30s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,741k (± 0.00%)}	_{1,672,763k (± 0.00%)}	_{🔻+450,023k (+36.80%)}	_1,672,723k	_1,672,804k	_{p=0.005 n=6}
_{Parse Time}	_{6.67s (± 0.44%)}	_{10.24s (± 0.51%)}	_{🔻+3.58s (+53.64%)}	_10.18s	_10.30s	_{p=0.005 n=6}
_{Bind Time}	_{1.86s (± 0.28%)}	_{3.51s (± 0.39%)}	_{🔻+1.65s (+88.64%)}	_3.50s	_3.53s	_{p=0.004 n=6}
_{Check Time}	_{31.19s (± 0.22%)}	_{45.35s (± 0.48%)}	_{🔻+14.16s (+45.40%)}	_45.15s	_45.66s	_{p=0.005 n=6}
_{Emit Time}	_{15.08s (± 0.31%)}	_{22.79s (± 0.74%)}	_{🔻+7.71s (+51.15%)}	_22.53s	_22.95s	_{p=0.005 n=6}
_{Total Time}	_{54.80s (± 0.19%)}	_{81.90s (± 0.22%)}	_{🔻+27.10s (+49.46%)}	_81.77s	_82.25s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,156	_2,529,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,017	_936,017	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,315k (± 0.00%)}	_{2,747,791k (± 0.01%)}	_{🔻+383,476k (+16.22%)}	_2,747,489k	_2,747,957k	_{p=0.005 n=6}
_{Parse Time}	_{11.15s (± 0.32%)}	_{15.37s (± 0.71%)}	_{🔻+4.22s (+37.86%)}	_15.19s	_15.52s	_{p=0.005 n=6}
_{Bind Time}	_{2.60s (± 0.40%)}	_{4.62s (± 0.29%)}	_{🔻+2.02s (+77.42%)}	_4.60s	_4.64s	_{p=0.005 n=6}
_{Check Time}	_{86.35s (± 0.39%)}	_{106.59s (± 0.73%)}	_{🔻+20.24s (+23.44%)}	_105.87s	_107.93s	_{p=0.005 n=6}
_{Emit Time}	_{0.33s (± 1.68%)}	_{0.34s (± 1.19%)}	_{🔻+0.02s (+ 5.13%)}	_0.34s	_0.35s	_{p=0.003 n=6}
_{Total Time}	_{100.43s (± 0.32%)}	_{126.93s (± 0.57%)}	_{🔻+26.50s (+26.38%)}	_126.19s	_128.08s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,455,886	_{🔻+209,934 (+16.85%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,450	_{🔻+13,237 (+ 5.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,064k (± 0.04%)}	_{3,483,558k (± 0.02%)}	_{🔻+1,085,494k (+45.27%)}	_3,482,941k	_3,484,290k	_{p=0.005 n=6}
_{Parse Time}	_{6.12s (± 1.08%)}	_{10.60s (± 0.30%)}	_{🔻+4.48s (+73.11%)}	_10.57s	_10.66s	_{p=0.005 n=6}
_{Bind Time}	_{2.27s (± 0.77%)}	_{4.46s (± 0.46%)}	_{🔻+2.19s (+96.69%)}	_4.43s	_4.49s	_{p=0.005 n=6}
_{Check Time}	_{41.07s (± 0.33%)}	_{59.74s (± 0.60%)}	_{🔻+18.68s (+45.48%)}	_59.27s	_60.17s	_{p=0.005 n=6}
_{Emit Time}	_{3.65s (± 3.29%)}	_{5.42s (± 5.13%)}	_{🔻+1.77s (+48.58%)}	_5.21s	_5.82s	_{p=0.005 n=6}
_{Total Time}	_{53.13s (± 0.36%)}	_{80.24s (± 0.34%)}	_{🔻+27.11s (+51.02%)}	_79.73s	_80.47s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,455,886	_{🔻+209,934 (+16.85%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_277,450	_{🔻+13,237 (+ 5.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,472,200k (± 0.04%)}	_{3,570,912k (± 0.01%)}	_{🔻+1,098,711k (+44.44%)}	_3,570,533k	_3,571,320k	_{p=0.005 n=6}
_{Parse Time}	_{7.84s (± 0.67%)}	_{13.35s (± 0.54%)}	_{🔻+5.50s (+70.14%)}	_13.28s	_13.47s	_{p=0.005 n=6}
_{Bind Time}	_{2.54s (± 0.35%)}	_{5.47s (± 1.05%)}	_{🔻+2.93s (+115.42%)}	_5.39s	_5.54s	_{p=0.005 n=6}
_{Check Time}	_{51.55s (± 0.41%)}	_{74.03s (± 0.64%)}	_{🔻+22.47s (+43.59%)}	_73.10s	_74.36s	_{p=0.005 n=6}
_{Emit Time}	_{4.44s (± 1.45%)}	_{6.55s (± 3.87%)}	_{🔻+2.11s (+47.60%)}	_6.40s	_7.06s	_{p=0.005 n=6}
_{Total Time}	_{66.38s (± 0.25%)}	_{99.40s (± 0.23%)}	_{🔻+33.02s (+49.75%)}	_99.01s	_99.65s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_334,435	_{🔻+74,550 (+28.69%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_119,370	_{🔻+13,230 (+12.46%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,627k (± 0.01%)}	_{696,228k (± 0.02%)}	_{🔻+260,602k (+59.82%)}	_696,069k	_696,392k	_{p=0.005 n=6}
_{Parse Time}	_{3.42s (± 0.44%)}	_{5.33s (± 0.56%)}	_{🔻+1.90s (+55.57%)}	_5.30s	_5.38s	_{p=0.005 n=6}
_{Bind Time}	_{1.29s (± 1.17%)}	_{2.47s (± 0.59%)}	_{🔻+1.19s (+92.10%)}	_2.45s	_2.49s	_{p=0.005 n=6}
_{Check Time}	_{18.18s (± 0.29%)}	_{28.34s (± 0.35%)}	_{🔻+10.15s (+55.85%)}	_28.17s	_28.48s	_{p=0.005 n=6}
_{Emit Time}	_{1.53s (± 1.35%)}	_{2.91s (± 0.92%)}	_{🔻+1.38s (+90.61%)}	_2.86s	_2.94s	_{p=0.005 n=6}
_{Total Time}	_{24.42s (± 0.24%)}	_{39.04s (± 0.29%)}	_{🔻+14.63s (+59.90%)}	_38.91s	_39.24s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,263k (± 0.02%)}	_{496,547k (± 0.00%)}	_{🔻+126,284k (+34.11%)}	_496,524k	_496,574k	_{p=0.005 n=6}
_{Parse Time}	_{2.28s (± 0.33%)}	_{3.32s (± 0.54%)}	_{🔻+1.04s (+45.72%)}	_3.30s	_3.35s	_{p=0.005 n=6}
_{Bind Time}	_{1.30s (± 2.15%)}	_{2.04s (± 0.59%)}	_{🔻+0.74s (+56.78%)}	_2.03s	_2.06s	_{p=0.004 n=6}
_{Check Time}	_{13.36s (± 0.25%)}	_{18.68s (± 0.21%)}	_{🔻+5.31s (+39.77%)}	_18.61s	_18.72s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.94s (± 0.37%)}	_{24.04s (± 0.22%)}	_{🔻+7.10s (+41.92%)}	_23.96s	_24.11s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,077,145	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,061,608	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,179,554k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{17.20s (± 0.42%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{5.30s (± 0.28%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{99.15s (± 0.43%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{27.18s (± 0.72%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{148.83s (± 0.34%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,157	_277,157	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,949	_112,949	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,038k (± 0.01%)}	_{541,537k (± 0.01%)}	_{🔻+114,499k (+26.81%)}	_541,398k	_541,582k	_{p=0.005 n=6}
_{Parse Time}	_{4.90s (± 0.33%)}	_{6.83s (± 0.45%)}	_{🔻+1.93s (+39.33%)}	_6.79s	_6.88s	_{p=0.005 n=6}
_{Bind Time}	_{2.13s (± 0.91%)}	_{3.49s (± 0.15%)}	_{🔻+1.36s (+63.82%)}	_3.48s	_3.49s	_{p=0.004 n=6}
_{Check Time}	_{21.89s (± 0.30%)}	_{29.51s (± 0.47%)}	_{🔻+7.62s (+34.83%)}	_29.35s	_29.69s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.92s (± 0.29%)}	_{39.83s (± 0.38%)}	_{🔻+10.91s (+37.72%)}	_39.65s	_40.03s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,594	_531,594	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,677	_181,677	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,730k (± 0.01%)}	_{550,468k (± 0.01%)}	_{🔻+86,738k (+18.70%)}	_550,439k	_550,507k	_{p=0.005 n=6}
_{Parse Time}	_{3.12s (± 1.06%)}	_{4.35s (± 0.58%)}	_{🔻+1.23s (+39.35%)}	_4.31s	_4.38s	_{p=0.005 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.87s (± 0.94%)}	_{🔻+0.75s (+67.92%)}	_1.84s	_1.89s	_{p=0.004 n=6}
_{Check Time}	_{18.27s (± 0.13%)}	_{21.65s (± 0.21%)}	_{🔻+3.38s (+18.52%)}	_21.61s	_21.73s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.50s (± 0.21%)}	_{27.86s (± 0.20%)}	_{🔻+5.36s (+23.85%)}	_27.80s	_27.96s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,294ms (± 0.93%)}	_{3,253ms (± 0.10%)}	_{🔻+959ms (+41.82%)}	_3,248ms	_3,257ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,161ms (± 0.29%)}	_{6,743ms (± 0.51%)}	_{🔻+1,582ms (+30.65%)}	_6,694ms	_6,779ms	_{p=0.005 n=6}
_{Req 3 - references}	_{264ms (± 1.67%)}	_{388ms (± 3.81%)}	_{🔻+125ms (+47.28%)}	_375ms	_407ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{227ms (± 0.65%)}	_{293ms (± 0.14%)}	_{🔻+66ms (+28.91%)}	_292ms	_293ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 5.91%)}	_{86ms (± 7.20%)}	_~	_82ms	_94ms	_{p=0.121 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,404ms (± 0.85%)}	_{3,434ms (± 0.15%)}	_{🔻+1,030ms (+42.87%)}	_3,430ms	_3,442ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,912ms (± 0.20%)}	_{5,339ms (± 0.40%)}	_{🔻+1,427ms (+36.48%)}	_5,320ms	_5,378ms	_{p=0.005 n=6}
_{Req 3 - references}	_{274ms (± 0.15%)}	_{422ms (± 0.92%)}	_{🔻+148ms (+54.05%)}	_414ms	_424ms	_{p=0.003 n=6}
_{Req 4 - navto}	_{227ms (± 0.33%)}	_{291ms (± 2.59%)}	_{🔻+64ms (+28.25%)}	_282ms	_305ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 8.13%)}	_{82ms (± 7.76%)}	_~	_78ms	_94ms	_{p=0.226 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,366ms (± 4.95%)}	_{8,652ms (± 0.32%)}	_{🔻+2,286ms (+35.91%)}	_8,619ms	_8,685ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,683ms (± 1.44%)}	_{1,732ms (±10.96%)}	_~	_1,549ms	_1,922ms	_{p=1.000 n=6}
_{Req 3 - references}	_{129ms (± 2.79%)}	_{154ms (± 8.96%)}	_{🔻+25ms (+18.94%)}	_127ms	_167ms	_{p=0.024 n=6}
_{Req 4 - navto}	_{603ms (± 1.30%)}	_{710ms (± 6.62%)}	_{🔻+107ms (+17.75%)}	_615ms	_741ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,270ms (± 0.51%)}	_{1,285ms (± 8.77%)}	_~	_1,055ms	_1,343ms	_{p=0.066 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{158.16ms (± 0.17%)}	_{180.07ms (± 0.17%)}	_{🔻+21.92ms (+13.86%)}	_179.06ms	_184.18ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.33ms (± 0.15%)}	_{254.84ms (± 0.13%)}	_{🔻+22.51ms (+ 9.69%)}	_253.52ms	_260.12ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.46ms (± 0.14%)}	_{248.16ms (± 0.13%)}	_{🔻+20.69ms (+ 9.10%)}	_246.67ms	_251.64ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{277.16ms (± 0.28%)}	_{304.16ms (± 0.32%)}	_{🔻+27.00ms (+ 9.74%)}	_295.62ms	_307.79ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-09-18T18:02:05Z

@typescript-bot perf test

typescript-bot · 2024-09-18T18:02:08Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-09-18T18:57:55Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,282k (± 0.74%)}	_{270,314k (± 0.57%)}	_{🔻+77,032k (+39.85%)}	_269,464k	_273,439k	_{p=0.005 n=6}
_{Parse Time}	_{1.56s (± 1.24%)}	_{1.66s (± 0.45%)}	_{🔻+0.10s (+ 6.40%)}	_1.65s	_1.67s	_{p=0.004 n=6}
_{Bind Time}	_{0.86s (± 0.73%)}	_{1.55s (± 0.75%)}	_{🔻+0.69s (+80.43%)}	_1.54s	_1.57s	_{p=0.004 n=6}
_{Check Time}	_{11.40s (± 0.14%)}	_{14.16s (± 1.58%)}	_{🔻+2.77s (+24.29%)}	_13.78s	_14.35s	_{p=0.005 n=6}
_{Emit Time}	_{3.22s (± 0.95%)}	_{5.04s (± 4.13%)}	_{🔻+1.82s (+56.65%)}	_4.89s	_5.33s	_{p=0.005 n=6}
_{Total Time}	_{17.03s (± 0.23%)}	_{22.42s (± 1.31%)}	_{🔻+5.39s (+31.65%)}	_21.88s	_22.76s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,713k (± 0.00%)}	_{1,725,853k (± 0.00%)}	_{🔻+503,140k (+41.15%)}	_1,725,780k	_1,725,948k	_{p=0.005 n=6}
_{Parse Time}	_{7.94s (± 0.85%)}	_{9.67s (± 0.42%)}	_{🔻+1.73s (+21.74%)}	_9.62s	_9.72s	_{p=0.005 n=6}
_{Bind Time}	_{2.23s (± 0.77%)}	_{5.77s (± 0.61%)}	_{🔻+3.54s (+158.94%)}	_5.72s	_5.81s	_{p=0.005 n=6}
_{Check Time}	_{36.45s (± 0.48%)}	_{50.49s (± 0.32%)}	_{🔻+14.04s (+38.52%)}	_50.28s	_50.74s	_{p=0.005 n=6}
_{Emit Time}	_{17.86s (± 0.32%)}	_{26.43s (± 0.31%)}	_{🔻+8.57s (+47.97%)}	_26.33s	_26.53s	_{p=0.005 n=6}
_{Total Time}	_{64.47s (± 0.34%)}	_{92.35s (± 0.26%)}	_{🔻+27.88s (+43.24%)}	_91.97s	_92.63s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,156	_2,529,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,017	_936,017	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,411k (± 0.00%)}	_{2,787,320k (± 0.00%)}	_{🔻+422,910k (+17.89%)}	_2,787,264k	_2,787,399k	_{p=0.005 n=6}
_{Parse Time}	_{13.79s (± 0.27%)}	_{16.55s (± 0.23%)}	_{🔻+2.76s (+20.04%)}	_16.51s	_16.62s	_{p=0.005 n=6}
_{Bind Time}	_{3.20s (± 0.86%)}	_{7.10s (± 0.28%)}	_{🔻+3.90s (+121.87%)}	_7.07s	_7.13s	_{p=0.005 n=6}
_{Check Time}	_{105.85s (± 0.38%)}	_{129.36s (± 0.22%)}	_{🔻+23.51s (+22.21%)}	_128.98s	_129.71s	_{p=0.005 n=6}
_{Emit Time}	_{0.39s (± 3.08%)}	_{0.41s (± 2.52%)}	_{🔻+0.02s (+ 5.51%)}	_0.40s	_0.43s	_{p=0.018 n=6}
_{Total Time}	_{123.23s (± 0.36%)}	_{153.42s (± 0.20%)}	_{🔻+30.19s (+24.50%)}	_153.04s	_153.86s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,552	_1,434,615	_{🔻+188,063 (+15.09%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,445	_278,258	_{🔻+13,813 (+ 5.22%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,459,084k (± 5.93%)}	_{3,489,219k (± 0.01%)}	_{🔻+1,030,135k (+41.89%)}	_3,488,782k	_3,489,769k	_{p=0.005 n=6}
_{Parse Time}	_{7.63s (± 0.48%)}	_{10.19s (± 0.60%)}	_{🔻+2.56s (+33.57%)}	_10.11s	_10.28s	_{p=0.005 n=6}
_{Bind Time}	_{2.81s (± 0.42%)}	_{7.03s (± 0.91%)}	_{🔻+4.22s (+150.33%)}	_6.96s	_7.13s	_{p=0.005 n=6}
_{Check Time}	_{50.94s (± 1.44%)}	_{71.55s (± 0.69%)}	_{🔻+20.61s (+40.45%)}	_70.93s	_72.07s	_{p=0.005 n=6}
_{Emit Time}	_{4.46s (± 4.40%)}	_{6.59s (± 4.85%)}	_{🔻+2.13s (+47.67%)}	_6.34s	_7.05s	_{p=0.005 n=6}
_{Total Time}	_{65.85s (± 1.07%)}	_{95.38s (± 0.26%)}	_{🔻+29.53s (+44.84%)}	_95.12s	_95.75s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,552	_1,434,615	_{🔻+188,063 (+15.09%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,445	_278,258	_{🔻+13,813 (+ 5.22%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,474,074k (± 0.03%)}	_{3,578,729k (± 0.01%)}	_{🔻+1,104,655k (+44.65%)}	_3,578,410k	_3,579,132k	_{p=0.005 n=6}
_{Parse Time}	_{6.28s (± 0.75%)}	_{8.34s (± 0.45%)}	_{🔻+2.06s (+32.86%)}	_8.31s	_8.41s	_{p=0.005 n=6}
_{Bind Time}	_{2.04s (± 0.51%)}	_{5.63s (± 0.93%)}	_{🔻+3.59s (+175.39%)}	_5.58s	_5.72s	_{p=0.005 n=6}
_{Check Time}	_{41.66s (± 0.57%)}	_{57.38s (± 0.72%)}	_{🔻+15.72s (+37.72%)}	_56.86s	_57.93s	_{p=0.005 n=6}
_{Emit Time}	_{3.52s (± 1.77%)}	_{5.31s (± 4.49%)}	_{🔻+1.78s (+50.61%)}	_5.13s	_5.78s	_{p=0.005 n=6}
_{Total Time}	_{53.53s (± 0.56%)}	_{76.66s (± 0.49%)}	_{🔻+23.13s (+43.20%)}	_76.25s	_77.14s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,902	_333,924	_{🔻+74,022 (+28.48%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,141	_119,820	_{🔻+13,679 (+12.89%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,632k (± 0.03%)}	_{700,413k (± 0.01%)}	_{🔻+264,781k (+60.78%)}	_700,298k	_700,455k	_{p=0.005 n=6}
_{Parse Time}	_{3.43s (± 1.07%)}	_{4.28s (± 0.50%)}	_{🔻+0.85s (+24.94%)}	_4.26s	_4.31s	_{p=0.005 n=6}
_{Bind Time}	_{1.29s (± 0.94%)}	_{2.99s (± 0.91%)}	_{🔻+1.69s (+131.06%)}	_2.96s	_3.02s	_{p=0.005 n=6}
_{Check Time}	_{18.13s (± 0.45%)}	_{27.28s (± 0.38%)}	_{🔻+9.15s (+50.45%)}	_27.15s	_27.40s	_{p=0.005 n=6}
_{Emit Time}	_{1.53s (± 1.37%)}	_{2.81s (± 0.65%)}	_{🔻+1.28s (+83.77%)}	_2.79s	_2.83s	_{p=0.005 n=6}
_{Total Time}	_{24.38s (± 0.33%)}	_{37.36s (± 0.28%)}	_{🔻+12.98s (+53.23%)}	_37.22s	_37.52s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,241k (± 0.02%)}	_{509,399k (± 0.00%)}	_{🔻+139,158k (+37.59%)}	_509,365k	_509,419k	_{p=0.005 n=6}
_{Parse Time}	_{2.29s (± 0.51%)}	_{2.68s (± 0.91%)}	_{🔻+0.38s (+16.73%)}	_2.65s	_2.72s	_{p=0.005 n=6}
_{Bind Time}	_{1.32s (± 1.30%)}	_{2.40s (± 0.97%)}	_{🔻+1.07s (+81.34%)}	_2.37s	_2.43s	_{p=0.005 n=6}
_{Check Time}	_{13.39s (± 0.16%)}	_{18.06s (± 0.36%)}	_{🔻+4.67s (+34.89%)}	_17.96s	_18.16s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.00s (± 0.13%)}	_{23.13s (± 0.44%)}	_{🔻+6.13s (+36.06%)}	_23.00s	_23.30s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,077,266	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,061,668	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,179,782k (± 0.00%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{13.98s (± 0.48%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{4.36s (± 0.30%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{81.72s (± 0.35%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{22.20s (± 0.37%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{122.27s (± 0.24%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,157	_277,157	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,949	_112,949	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,912k (± 0.02%)}	_{553,555k (± 0.01%)}	_{🔻+126,643k (+29.66%)}	_553,499k	_553,630k	_{p=0.005 n=6}
_{Parse Time}	_{3.96s (± 0.21%)}	_{4.53s (± 0.90%)}	_{🔻+0.57s (+14.41%)}	_4.47s	_4.58s	_{p=0.005 n=6}
_{Bind Time}	_{1.72s (± 0.32%)}	_{2.96s (± 0.41%)}	_{🔻+1.25s (+72.79%)}	_2.95s	_2.98s	_{p=0.004 n=6}
_{Check Time}	_{17.63s (± 0.17%)}	_{23.10s (± 0.33%)}	_{🔻+5.47s (+31.00%)}	_23.00s	_23.18s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.30s (± 0.11%)}	_{30.58s (± 0.23%)}	_{🔻+7.28s (+31.24%)}	_30.51s	_30.68s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,594	_531,594	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,677	_181,677	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,710k (± 0.01%)}	_{561,753k (± 0.02%)}	_{🔻+98,043k (+21.14%)}	_561,601k	_561,867k	_{p=0.005 n=6}
_{Parse Time}	_{3.12s (± 0.82%)}	_{3.61s (± 0.57%)}	_{🔻+0.49s (+15.59%)}	_3.58s	_3.64s	_{p=0.005 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{2.25s (± 0.78%)}	_{🔻+1.13s (+101.95%)}	_2.22s	_2.27s	_{p=0.003 n=6}
_{Check Time}	_{18.21s (± 0.28%)}	_{21.31s (± 0.29%)}	_{🔻+3.11s (+17.06%)}	_21.22s	_21.38s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.44s (± 0.27%)}	_{27.17s (± 0.22%)}	_{🔻+4.73s (+21.06%)}	_27.07s	_27.24s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,860ms (± 9.43%)}	_{3,641ms (± 3.07%)}	_{🔻+781ms (+27.32%)}	_3,583ms	_3,869ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{6,631ms (±10.45%)}	_{9,031ms (± 9.89%)}	_{🔻+2,401ms (+36.21%)}	_7,867ms	_9,870ms	_{p=0.005 n=6}
_{Req 3 - references}	_{392ms (± 1.69%)}	_{512ms (±10.46%)}	_{🔻+120ms (+30.47%)}	_464ms	_580ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{337ms (± 2.33%)}	_{427ms (± 7.66%)}	_{🔻+90ms (+26.61%)}	_360ms	_442ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{118ms (± 7.77%)}	_{136ms (± 6.85%)}	_{🔻+17ms (+14.51%)}	_118ms	_146ms	_{p=0.016 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,126ms (±11.90%)}	_{4,074ms (± 8.45%)}	_{🔻+948ms (+30.32%)}	_3,825ms	_4,724ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,373ms (±10.23%)}	_{6,795ms (±11.77%)}	_{🔻+1,422ms (+26.46%)}	_6,009ms	_7,613ms	_{p=0.005 n=6}
_{Req 3 - references}	_{390ms (± 8.91%)}	_{570ms (± 9.48%)}	_{🔻+180ms (+46.21%)}	_518ms	_643ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{338ms (± 2.42%)}	_{411ms (± 8.96%)}	_{🔻+74ms (+21.78%)}	_362ms	_438ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{115ms (± 5.83%)}	_{113ms (± 8.56%)}	_~	_94ms	_119ms	_{p=0.329 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,476ms (± 6.25%)}	_{8,568ms (± 5.63%)}	_{🔻+2,092ms (+32.31%)}	_8,112ms	_9,015ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,689ms (± 0.58%)}	_{1,763ms (±10.37%)}	_~	_1,525ms	_1,894ms	_{p=0.378 n=6}
_{Req 3 - references}	_{128ms (± 2.84%)}	_{152ms (± 3.15%)}	_{🔻+24ms (+18.88%)}	_146ms	_156ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{600ms (± 2.64%)}	_{691ms (± 1.39%)}	_{🔻+91ms (+15.10%)}	_684ms	_709ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,257ms (± 1.17%)}	_{1,305ms (± 0.55%)}	_{+48ms (+ 3.79%)}	_1,297ms	_1,317ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{189.74ms (± 0.19%)}	_{210.37ms (± 0.18%)}	_{🔻+20.63ms (+10.87%)}	_207.35ms	_214.11ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{285.00ms (± 0.27%)}	_{306.29ms (± 0.30%)}	_{🔻+21.29ms (+ 7.47%)}	_298.29ms	_309.65ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{277.37ms (± 0.27%)}	_{297.86ms (± 0.33%)}	_{🔻+20.50ms (+ 7.39%)}	_289.74ms	_301.95ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{278.46ms (± 0.29%)}	_{299.06ms (± 0.34%)}	_{🔻+20.59ms (+ 7.40%)}	_290.15ms	_304.24ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-09-20T20:17:43Z

@typescript-bot perf test

typescript-bot · 2024-09-20T20:17:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-09-20T21:07:57Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,675k (± 0.92%)}	_{271,009k (± 0.74%)}	_{🔻+77,334k (+39.93%)}	_269,506k	_273,665k	_{p=0.005 n=6}
_{Parse Time}	_{1.56s (± 0.52%)}	_{1.70s (± 0.88%)}	_{🔻+0.14s (+ 8.96%)}	_1.69s	_1.73s	_{p=0.004 n=6}
_{Bind Time}	_{0.86s (± 1.20%)}	_{1.56s (± 0.52%)}	_{🔻+0.70s (+81.71%)}	_1.55s	_1.57s	_{p=0.004 n=6}
_{Check Time}	_{11.38s (± 0.48%)}	_{13.96s (± 0.51%)}	_{🔻+2.58s (+22.66%)}	_13.87s	_14.07s	_{p=0.005 n=6}
_{Emit Time}	_{3.23s (± 0.91%)}	_{5.06s (± 3.68%)}	_{🔻+1.82s (+56.34%)}	_4.92s	_5.31s	_{p=0.005 n=6}
_{Total Time}	_{17.04s (± 0.55%)}	_{22.28s (± 1.05%)}	_{🔻+5.25s (+30.79%)}	_22.07s	_22.60s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,733k (± 0.00%)}	_{1,725,860k (± 0.00%)}	_{🔻+503,127k (+41.15%)}	_1,725,803k	_1,725,911k	_{p=0.005 n=6}
_{Parse Time}	_{6.67s (± 0.71%)}	_{8.31s (± 0.56%)}	_{🔻+1.65s (+24.73%)}	_8.24s	_8.37s	_{p=0.005 n=6}
_{Bind Time}	_{1.86s (± 0.28%)}	_{4.89s (± 0.36%)}	_{🔻+3.02s (+162.25%)}	_4.86s	_4.91s	_{p=0.004 n=6}
_{Check Time}	_{31.19s (± 0.15%)}	_{43.46s (± 0.31%)}	_{🔻+12.27s (+39.33%)}	_43.28s	_43.63s	_{p=0.005 n=6}
_{Emit Time}	_{15.02s (± 1.01%)}	_{22.53s (± 0.65%)}	_{🔻+7.51s (+49.96%)}	_22.33s	_22.64s	_{p=0.005 n=6}
_{Total Time}	_{54.74s (± 0.32%)}	_{79.19s (± 0.31%)}	_{🔻+24.44s (+44.65%)}	_78.83s	_79.52s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,472	_2,529,472	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,018	_936,018	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,794k (± 0.00%)}	_{2,787,683k (± 0.00%)}	_{🔻+422,889k (+17.88%)}	_2,787,649k	_2,787,743k	_{p=0.005 n=6}
_{Parse Time}	_{11.17s (± 0.16%)}	_{13.42s (± 0.21%)}	_{🔻+2.25s (+20.14%)}	_13.40s	_13.47s	_{p=0.005 n=6}
_{Bind Time}	_{2.61s (± 0.31%)}	_{5.81s (± 0.47%)}	_{🔻+3.20s (+122.51%)}	_5.78s	_5.86s	_{p=0.005 n=6}
_{Check Time}	_{86.33s (± 0.43%)}	_{105.85s (± 0.22%)}	_{🔻+19.52s (+22.61%)}	_105.50s	_106.14s	_{p=0.005 n=6}
_{Emit Time}	_0.33s	_{0.35s (± 3.35%)}	_{🔻+0.02s (+ 5.56%)}	_0.33s	_0.36s	_{p=0.009 n=6}
_{Total Time}	_{100.45s (± 0.36%)}	_{125.44s (± 0.19%)}	_{🔻+24.99s (+24.87%)}	_125.05s	_125.69s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,550	_1,560,508	_{🔻+313,958 (+25.19%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,444	_293,720	_{🔻+29,276 (+11.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,746k (± 0.03%)}	_{3,507,887k (± 0.02%)}	_{🔻+1,109,141k (+46.24%)}	_3,506,214k	_3,508,490k	_{p=0.005 n=6}
_{Parse Time}	_{6.10s (± 0.60%)}	_{8.10s (± 0.61%)}	_{🔻+2.00s (+32.80%)}	_8.03s	_8.16s	_{p=0.005 n=6}
_{Bind Time}	_{2.27s (± 0.87%)}	_{5.65s (± 0.32%)}	_{🔻+3.38s (+149.26%)}	_5.63s	_5.68s	_{p=0.005 n=6}
_{Check Time}	_{41.22s (± 0.91%)}	_{60.31s (± 0.75%)}	_{🔻+19.09s (+46.31%)}	_59.60s	_60.96s	_{p=0.005 n=6}
_{Emit Time}	_{3.62s (± 4.27%)}	_{5.37s (± 0.52%)}	_{🔻+1.75s (+48.32%)}	_5.33s	_5.41s	_{p=0.005 n=6}
_{Total Time}	_{53.23s (± 0.80%)}	_{79.44s (± 0.55%)}	_{🔻+26.21s (+49.25%)}	_78.77s	_80.06s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,550	_1,560,508	_{🔻+313,958 (+25.19%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,444	_293,720	_{🔻+29,276 (+11.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,473,341k (± 0.01%)}	_{3,608,594k (± 0.01%)}	_{🔻+1,135,254k (+45.90%)}	_3,607,830k	_3,609,111k	_{p=0.005 n=6}
_{Parse Time}	_{7.91s (± 0.80%)}	_{10.28s (± 0.41%)}	_{🔻+2.38s (+30.04%)}	_10.22s	_10.35s	_{p=0.005 n=6}
_{Bind Time}	_{2.54s (± 0.70%)}	_{6.95s (± 0.70%)}	_{🔻+4.41s (+173.82%)}	_6.89s	_7.02s	_{p=0.005 n=6}
_{Check Time}	_{51.62s (± 0.81%)}	_{74.63s (± 0.39%)}	_{🔻+23.02s (+44.59%)}	_74.13s	_74.89s	_{p=0.005 n=6}
_{Emit Time}	_{4.47s (± 3.19%)}	_{6.64s (± 0.86%)}	_{🔻+2.16s (+48.42%)}	_6.54s	_6.70s	_{p=0.005 n=6}
_{Total Time}	_{66.56s (± 0.56%)}	_{98.49s (± 0.36%)}	_{🔻+31.93s (+47.98%)}	_97.86s	_98.82s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,902	_419,353	_{🔻+159,451 (+61.35%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,141	_127,296	_{🔻+21,155 (+19.93%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,647k (± 0.01%)}	_{744,542k (± 0.07%)}	_{🔻+308,895k (+70.91%)}	_744,155k	_745,554k	_{p=0.005 n=6}
_{Parse Time}	_{4.25s (± 0.80%)}	_{5.33s (± 0.44%)}	_{🔻+1.07s (+25.19%)}	_5.30s	_5.36s	_{p=0.005 n=6}
_{Bind Time}	_{1.59s (± 1.56%)}	_{3.72s (± 0.14%)}	_{🔻+2.13s (+134.00%)}	_3.71s	_3.72s	_{p=0.004 n=6}
_{Check Time}	_{22.44s (± 0.42%)}	_{34.81s (± 0.65%)}	_{🔻+12.37s (+55.13%)}	_34.41s	_35.08s	_{p=0.005 n=6}
_{Emit Time}	_{1.88s (± 0.88%)}	_{4.34s (±10.18%)}	_{🔻+2.46s (+131.38%)}	_3.46s	_4.64s	_{p=0.005 n=6}
_{Total Time}	_{30.16s (± 0.34%)}	_{48.19s (± 0.73%)}	_{🔻+18.03s (+59.80%)}	_47.62s	_48.53s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,248k (± 0.01%)}	_{509,340k (± 0.01%)}	_{🔻+139,091k (+37.57%)}	_509,288k	_509,458k	_{p=0.005 n=6}
_{Parse Time}	_{2.75s (± 1.41%)}	_{3.24s (± 0.41%)}	_{🔻+0.48s (+17.62%)}	_3.23s	_3.26s	_{p=0.004 n=6}
_{Bind Time}	_{1.57s (± 0.66%)}	_{2.85s (± 0.98%)}	_{🔻+1.29s (+82.13%)}	_2.82s	_2.90s	_{p=0.004 n=6}
_{Check Time}	_{15.71s (± 0.21%)}	_{21.09s (± 0.44%)}	_{🔻+5.39s (+34.31%)}	_20.97s	_21.21s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.03s (± 0.24%)}	_{27.19s (± 0.41%)}	_{🔻+7.16s (+35.75%)}	_27.04s	_27.35s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,093,690	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,066,256	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,191,489k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{11.65s (± 0.41%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{3.68s (± 2.13%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{70.82s (± 0.23%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{18.93s (± 0.95%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{105.08s (± 0.26%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,196	_277,196	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,950	_112,950	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,009k (± 0.01%)}	_{553,479k (± 0.01%)}	_{🔻+126,470k (+29.62%)}	_553,409k	_553,537k	_{p=0.005 n=6}
_{Parse Time}	_{4.91s (± 0.60%)}	_{5.63s (± 0.26%)}	_{🔻+0.73s (+14.78%)}	_5.61s	_5.65s	_{p=0.005 n=6}
_{Bind Time}	_{2.15s (± 0.76%)}	_{3.69s (± 0.70%)}	_{🔻+1.54s (+71.59%)}	_3.67s	_3.73s	_{p=0.005 n=6}
_{Check Time}	_{21.73s (± 0.32%)}	_{28.53s (± 0.64%)}	_{🔻+6.80s (+31.31%)}	_28.33s	_28.75s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.79s (± 0.25%)}	_{37.86s (± 0.49%)}	_{🔻+9.07s (+31.51%)}	_37.62s	_38.11s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,943	_539,943	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,263	_181,263	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,352k (± 0.01%)}	_{587,368k (± 0.01%)}	_{🔻+104,016k (+21.52%)}	_587,327k	_587,454k	_{p=0.005 n=6}
_{Parse Time}	_{3.23s (± 0.47%)}	_{3.67s (± 0.76%)}	_{🔻+0.44s (+13.64%)}	_3.63s	_3.70s	_{p=0.005 n=6}
_{Bind Time}	_{1.16s (± 0.65%)}	_{2.40s (± 0.44%)}	_{🔻+1.23s (+106.17%)}	_2.38s	_2.41s	_{p=0.005 n=6}
_{Check Time}	_{18.38s (± 0.34%)}	_{21.46s (± 0.31%)}	_{🔻+3.08s (+16.78%)}	_21.37s	_21.56s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.77s (± 0.30%)}	_{27.53s (± 0.31%)}	_{🔻+4.76s (+20.91%)}	_27.39s	_27.65s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,299ms (± 0.56%)}	_{3,023ms (± 0.29%)}	_{🔻+723ms (+31.46%)}	_3,011ms	_3,032ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,169ms (± 0.37%)}	_{6,595ms (± 0.33%)}	_{🔻+1,426ms (+27.58%)}	_6,567ms	_6,630ms	_{p=0.005 n=6}
_{Req 3 - references}	_{261ms (± 0.91%)}	_{398ms (± 0.54%)}	_{🔻+137ms (+52.30%)}	_395ms	_401ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{228ms (± 0.54%)}	_{296ms (± 0.30%)}	_{🔻+69ms (+30.11%)}	_295ms	_297ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 3.91%)}	_{89ms (± 9.62%)}	_~	_81ms	_97ms	_{p=0.415 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,397ms (± 1.20%)}	_{3,222ms (± 0.43%)}	_{🔻+825ms (+34.43%)}	_3,203ms	_3,240ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,919ms (± 0.21%)}	_{5,153ms (± 0.30%)}	_{🔻+1,234ms (+31.50%)}	_5,125ms	_5,168ms	_{p=0.005 n=6}
_{Req 3 - references}	_{271ms (± 0.86%)}	_{431ms (± 2.08%)}	_{🔻+159ms (+58.72%)}	_413ms	_437ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{234ms (± 3.23%)}	_295ms	_{🔻+61ms (+25.98%)}	_~	_~	_{p=0.003 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 8.62%)}	_{79ms (± 1.04%)}	_~	_78ms	_80ms	_{p=0.063 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,493ms (± 6.00%)}	_{8,274ms (± 0.65%)}	_{🔻+1,781ms (+27.44%)}	_8,218ms	_8,340ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,689ms (± 0.62%)}	_{1,692ms (±11.64%)}	_~	_1,505ms	_1,911ms	_{p=1.000 n=6}
_{Req 3 - references}	_{131ms (± 3.24%)}	_{147ms (± 7.82%)}	_~	_124ms	_153ms	_{p=0.063 n=6}
_{Req 4 - navto}	_{592ms (± 1.57%)}	_{698ms (± 1.86%)}	_{🔻+106ms (+17.87%)}	_686ms	_722ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,258ms (± 1.19%)}	_{1,325ms (± 1.65%)}	_{🔻+67ms (+ 5.35%)}	_1,291ms	_1,351ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{158.42ms (± 0.19%)}	_{170.68ms (± 0.18%)}	_{🔻+12.26ms (+ 7.74%)}	_169.67ms	_175.04ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.43ms (± 0.15%)}	_{256.35ms (± 0.13%)}	_{🔻+23.92ms (+10.29%)}	_255.05ms	_263.13ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{278.42ms (± 0.29%)}	_{300.36ms (± 0.28%)}	_{🔻+21.94ms (+ 7.88%)}	_293.01ms	_302.91ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.48ms (± 0.15%)}	_{245.01ms (± 0.13%)}	_{🔻+17.53ms (+ 7.70%)}	_243.41ms	_249.77ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-10-01T19:11:34Z

@typescript-bot perf test

typescript-bot · 2024-10-01T19:11:37Z

Hey @rbuckton, this PR is in an unmergable state, so is missing a merge commit to run against; please resolve conflicts and try again.

rbuckton · 2024-10-01T20:05:29Z

@typescript-bot perf test

typescript-bot · 2024-10-01T20:05:33Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-10-01T20:55:02Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,816k (± 0.73%)}	_{273,023k (± 0.09%)}	_{🔻+77,207k (+39.43%)}	_272,672k	_273,282k	_{p=0.005 n=6}
_{Parse Time}	_{1.62s (± 1.28%)}	_{1.74s (± 2.40%)}	_{🔻+0.12s (+ 7.42%)}	_1.67s	_1.77s	_{p=0.005 n=6}
_{Bind Time}	_{0.87s (± 1.03%)}	_{1.37s (± 0.75%)}	_{🔻+0.50s (+57.85%)}	_1.36s	_1.39s	_{p=0.005 n=6}
_{Check Time}	_{11.76s (± 0.49%)}	_{12.31s (± 0.86%)}	_{🔻+0.55s (+ 4.65%)}	_12.22s	_12.52s	_{p=0.005 n=6}
_{Emit Time}	_{3.30s (± 0.76%)}	_{4.26s (± 5.80%)}	_{🔻+0.97s (+29.32%)}	_4.08s	_4.62s	_{p=0.005 n=6}
_{Total Time}	_{17.55s (± 0.37%)}	_{19.68s (± 1.26%)}	_{🔻+2.14s (+12.19%)}	_19.45s	_19.99s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,797k (± 0.01%)}	_{1,726,906k (± 0.00%)}	_{🔻+502,109k (+41.00%)}	_1,726,824k	_1,726,947k	_{p=0.005 n=6}
_{Parse Time}	_{8.09s (± 0.83%)}	_{9.73s (± 0.39%)}	_{🔻+1.64s (+20.28%)}	_9.69s	_9.79s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 0.65%)}	_{5.21s (± 0.43%)}	_{🔻+2.95s (+130.21%)}	_5.17s	_5.23s	_{p=0.005 n=6}
_{Check Time}	_{37.69s (± 0.48%)}	_{43.74s (± 0.37%)}	_{🔻+6.05s (+16.05%)}	_43.60s	_43.95s	_{p=0.005 n=6}
_{Emit Time}	_{18.19s (± 0.50%)}	_{22.27s (± 0.43%)}	_{🔻+4.09s (+22.47%)}	_22.09s	_22.35s	_{p=0.005 n=6}
_{Total Time}	_{66.23s (± 0.41%)}	_{80.96s (± 0.26%)}	_{🔻+14.72s (+22.23%)}	_80.67s	_81.19s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,522,038	_2,522,038	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,053	_936,053	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,352,836k (± 0.01%)}	_{2,770,805k (± 0.00%)}	_{🔻+417,968k (+17.76%)}	_2,770,695k	_2,771,022k	_{p=0.005 n=6}
_{Parse Time}	_{11.20s (± 0.53%)}	_{13.10s (± 0.53%)}	_{🔻+1.91s (+17.05%)}	_12.98s	_13.19s	_{p=0.005 n=6}
_{Bind Time}	_{2.61s (± 1.29%)}	_{5.13s (± 0.90%)}	_{🔻+2.52s (+96.30%)}	_5.08s	_5.19s	_{p=0.005 n=6}
_{Check Time}	_{92.14s (± 2.04%)}	_{102.32s (± 2.36%)}	_{🔻+10.17s (+11.04%)}	_100.68s	_106.76s	_{p=0.005 n=6}
_{Emit Time}	_{0.34s (± 3.04%)}	_{0.35s (± 1.81%)}	_~	_0.34s	_0.36s	_{p=0.388 n=6}
_{Total Time}	_{106.30s (± 1.77%)}	_{120.90s (± 2.05%)}	_{🔻+14.60s (+13.74%)}	_119.28s	_125.42s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,610,348	_{🔻+352,242 (+28.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_296,415	_{🔻+30,149 (+11.32%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,094k (± 0.03%)}	_{4,641,312k (±11.71%)}	_{🔻+1,495,218k (+47.53%)}	_3,530,774k	_4,865,086k	_{p=0.005 n=6}
_{Parse Time}	_{6.54s (± 0.52%)}	_{8.50s (± 1.69%)}	_{🔻+1.97s (+30.12%)}	_8.31s	_8.62s	_{p=0.005 n=6}
_{Bind Time}	_{2.31s (± 0.71%)}	_{5.60s (± 2.24%)}	_{🔻+3.29s (+142.70%)}	_5.42s	_5.80s	_{p=0.005 n=6}
_{Check Time}	_{43.00s (± 0.22%)}	_{56.82s (± 1.12%)}	_{🔻+13.82s (+32.14%)}	_56.33s	_58.06s	_{p=0.005 n=6}
_{Emit Time}	_{3.55s (± 3.18%)}	_{4.96s (± 1.33%)}	_{🔻+1.41s (+39.62%)}	_4.86s	_5.02s	_{p=0.005 n=6}
_{Total Time}	_{55.39s (± 0.27%)}	_{75.87s (± 0.78%)}	_{🔻+20.48s (+36.98%)}	_75.39s	_77.02s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,610,348	_{🔻+352,242 (+28.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_296,415	_{🔻+30,149 (+11.32%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,619,344k (±11.20%)}	_{4,979,198k (± 0.03%)}	_{🔻+2,359,854k (+90.09%)}	_4,977,693k	_4,981,846k	_{p=0.005 n=6}
_{Parse Time}	_{8.24s (± 2.21%)}	_{10.88s (± 0.35%)}	_{🔻+2.64s (+32.03%)}	_10.83s	_10.93s	_{p=0.005 n=6}
_{Bind Time}	_{2.65s (± 2.01%)}	_{6.84s (± 1.86%)}	_{🔻+4.19s (+158.08%)}	_6.71s	_7.04s	_{p=0.005 n=6}
_{Check Time}	_{53.55s (± 0.49%)}	_{69.86s (± 0.54%)}	_{🔻+16.31s (+30.46%)}	_69.48s	_70.47s	_{p=0.005 n=6}
_{Emit Time}	_{4.47s (± 4.88%)}	_{6.23s (± 0.92%)}	_{🔻+1.76s (+39.30%)}	_6.13s	_6.29s	_{p=0.005 n=6}
_{Total Time}	_{68.91s (± 0.69%)}	_{93.79s (± 0.50%)}	_{🔻+24.88s (+36.11%)}	_93.35s	_94.60s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,785	_459,520	_{🔻+197,735 (+75.53%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_128,536	_{🔻+22,028 (+20.68%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,764k (± 0.01%)}	_{762,686k (± 0.01%)}	_{🔻+323,923k (+73.83%)}	_762,489k	_762,783k	_{p=0.005 n=6}
_{Parse Time}	_{3.56s (± 0.95%)}	_{4.37s (± 1.04%)}	_{🔻+0.81s (+22.74%)}	_4.32s	_4.44s	_{p=0.005 n=6}
_{Bind Time}	_{1.30s (± 0.76%)}	_{2.82s (± 0.78%)}	_{🔻+1.52s (+117.20%)}	_2.79s	_2.85s	_{p=0.005 n=6}
_{Check Time}	_{18.89s (± 0.61%)}	_{27.16s (± 0.39%)}	_{🔻+8.27s (+43.76%)}	_27.03s	_27.31s	_{p=0.005 n=6}
_{Emit Time}	_{1.55s (± 1.11%)}	_{2.70s (± 0.79%)}	_{🔻+1.15s (+73.90%)}	_2.67s	_2.73s	_{p=0.005 n=6}
_{Total Time}	_{25.31s (± 0.51%)}	_{37.05s (± 0.46%)}	_{🔻+11.74s (+46.40%)}	_36.81s	_37.27s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,064k (± 0.02%)}	_{508,685k (± 0.02%)}	_{🔻+137,621k (+37.09%)}	_508,523k	_508,791k	_{p=0.005 n=6}
_{Parse Time}	_{2.89s (± 1.26%)}	_{3.32s (± 1.02%)}	_{🔻+0.43s (+14.99%)}	_3.29s	_3.37s	_{p=0.005 n=6}
_{Bind Time}	_{1.60s (± 1.61%)}	_{2.88s (± 0.75%)}	_{🔻+1.27s (+79.42%)}	_2.84s	_2.90s	_{p=0.005 n=6}
_{Check Time}	_{16.35s (± 0.40%)}	_{19.47s (± 0.25%)}	_{🔻+3.12s (+19.08%)}	_19.39s	_19.52s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.85s (± 0.23%)}	_{25.67s (± 0.23%)}	_{🔻+4.82s (+23.14%)}	_25.61s	_25.74s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,110,478	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,072,234	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,202,485k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{14.05s (± 0.61%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{4.42s (± 0.33%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{87.16s (± 3.18%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{24.81s (± 9.62%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{130.45s (± 2.74%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,484	_279,484	_~	_~	_~	_{p=1.000 n=6}
_Types	_114,024	_114,024	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,358k (± 0.02%)}	_{554,686k (± 0.01%)}	_{🔻+125,328k (+29.19%)}	_554,648k	_554,734k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 0.44%)}	_{3.74s (± 0.39%)}	_{🔻+0.42s (+12.66%)}	_3.72s	_3.75s	_{p=0.005 n=6}
_{Bind Time}	_{1.45s (± 0.92%)}	_{2.03s (± 0.65%)}	_{🔻+0.58s (+40.05%)}	_2.01s	_2.04s	_{p=0.004 n=6}
_{Check Time}	_{15.11s (± 0.36%)}	_{15.70s (± 0.23%)}	_{+0.59s (+ 3.93%)}	_15.65s	_15.74s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.88s (± 0.23%)}	_{21.47s (± 0.25%)}	_{🔻+1.59s (+ 8.01%)}	_21.39s	_21.53s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,560	_540,560	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,448	_181,448	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,314k (± 0.01%)}	_{587,285k (± 0.01%)}	_{🔻+102,971k (+21.26%)}	_587,222k	_587,368k	_{p=0.005 n=6}
_{Parse Time}	_{3.36s (± 1.32%)}	_{3.82s (± 0.73%)}	_{🔻+0.46s (+13.73%)}	_3.79s	_3.87s	_{p=0.005 n=6}
_{Bind Time}	_{1.18s (± 1.28%)}	_{2.20s (± 0.34%)}	_{🔻+1.02s (+86.83%)}	_2.19s	_2.21s	_{p=0.004 n=6}
_{Check Time}	_{19.12s (± 0.15%)}	_{20.98s (± 0.24%)}	_{🔻+1.86s (+ 9.71%)}	_20.90s	_21.05s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{23.66s (± 0.29%)}	_{27.00s (± 0.14%)}	_{🔻+3.34s (+14.10%)}	_26.96s	_27.05s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,309ms (± 0.45%)}	_{2,881ms (± 0.29%)}	_{🔻+571ms (+24.73%)}	_2,871ms	_2,892ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,288ms (± 0.22%)}	_{5,880ms (± 0.34%)}	_{🔻+593ms (+11.21%)}	_5,846ms	_5,897ms	_{p=0.005 n=6}
_{Req 3 - references}	_{268ms (± 1.02%)}	_{308ms (± 3.07%)}	_{🔻+40ms (+15.08%)}	_302ms	_327ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{228ms (± 0.58%)}	_{273ms (± 1.75%)}	_{🔻+45ms (+19.58%)}	_265ms	_277ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 7.15%)}	_{69ms (± 2.38%)}	_{🟩-13ms (-16.26%)}	_68ms	_72ms	_{p=0.004 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,464ms (± 0.32%)}	_{3,110ms (± 0.48%)}	_{🔻+646ms (+26.24%)}	_3,093ms	_3,127ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,968ms (± 0.27%)}	_{4,356ms (± 0.14%)}	_{🔻+388ms (+ 9.77%)}	_4,349ms	_4,364ms	_{p=0.005 n=6}
_{Req 3 - references}	_{284ms (± 0.26%)}	_{347ms (± 0.26%)}	_{🔻+63ms (+22.11%)}	_346ms	_348ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{227ms (± 0.18%)}	_{283ms (± 0.58%)}	_{🔻+56ms (+24.54%)}	_281ms	_285ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 0.60%)}	_{77ms (± 1.33%)}	_{🟩-8ms (- 9.38%)}	_76ms	_78ms	_{p=0.004 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,237ms (± 0.53%)}	_{6,712ms (± 0.47%)}	_{🔻+1,475ms (+28.16%)}	_6,667ms	_6,749ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,143ms (± 0.59%)}	_{1,116ms (± 0.45%)}	_{-28ms (- 2.42%)}	_1,109ms	_1,122ms	_{p=0.005 n=6}
_{Req 3 - references}	_{84ms (± 4.59%)}	_{93ms (± 1.58%)}	_{🔻+10ms (+11.58%)}	_92ms	_95ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{450ms (± 0.73%)}	_{431ms (± 0.36%)}	_{🟩-19ms (- 4.22%)}	_429ms	_433ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,450	_3,450	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{851ms (± 1.91%)}	_{884ms (± 0.36%)}	_{+33ms (+ 3.86%)}	_880ms	_889ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{159.87ms (± 0.20%)}	_{167.62ms (± 0.17%)}	_{🔻+7.74ms (+ 4.84%)}	_166.63ms	_171.90ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{234.48ms (± 0.20%)}	_{258.88ms (± 0.13%)}	_{🔻+24.41ms (+10.41%)}	_257.27ms	_262.96ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.55ms (± 0.15%)}	_{247.47ms (± 0.14%)}	_{🔻+17.92ms (+ 7.81%)}	_245.93ms	_250.53ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.05ms (± 0.15%)}	_{246.89ms (± 0.15%)}	_{🔻+17.84ms (+ 7.79%)}	_245.27ms	_250.95ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-10-02T14:46:12Z

@typescript-bot perf test

typescript-bot · 2024-10-02T14:46:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-10-02T15:32:00Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,826k (± 0.72%)}	_{271,626k (± 0.75%)}	_{🔻+75,800k (+38.71%)}	_268,746k	_273,113k	_{p=0.005 n=6}
_{Parse Time}	_{1.61s (± 0.94%)}	_{1.75s (± 1.32%)}	_{🔻+0.15s (+ 9.14%)}	_1.72s	_1.78s	_{p=0.005 n=6}
_{Bind Time}	_{0.86s (± 2.14%)}	_{1.36s (± 1.38%)}	_{🔻+0.50s (+57.86%)}	_1.33s	_1.38s	_{p=0.005 n=6}
_{Check Time}	_{11.70s (± 0.38%)}	_{12.33s (± 1.67%)}	_{🔻+0.63s (+ 5.37%)}	_12.21s	_12.73s	_{p=0.005 n=6}
_{Emit Time}	_{3.34s (± 3.07%)}	_{4.35s (± 4.58%)}	_{🔻+1.01s (+30.29%)}	_4.08s	_4.52s	_{p=0.005 n=6}
_{Total Time}	_{17.50s (± 0.45%)}	_{19.79s (± 1.59%)}	_{🔻+2.28s (+13.05%)}	_19.38s	_20.33s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,807k (± 0.00%)}	_{1,726,563k (± 0.01%)}	_{🔻+501,756k (+40.97%)}	_1,726,397k	_1,726,658k	_{p=0.005 n=6}
_{Parse Time}	_{8.13s (± 0.42%)}	_{9.82s (± 0.40%)}	_{🔻+1.70s (+20.86%)}	_9.77s	_9.87s	_{p=0.005 n=6}
_{Bind Time}	_{2.27s (± 0.56%)}	_{4.47s (± 0.70%)}	_{🔻+2.20s (+96.84%)}	_4.44s	_4.52s	_{p=0.005 n=6}
_{Check Time}	_{37.83s (± 0.19%)}	_{38.56s (± 0.40%)}	_{+0.73s (+ 1.93%)}	_38.41s	_38.80s	_{p=0.005 n=6}
_{Emit Time}	_{18.27s (± 0.71%)}	_{19.95s (± 1.08%)}	_{🔻+1.69s (+ 9.23%)}	_19.59s	_20.22s	_{p=0.005 n=6}
_{Total Time}	_{66.49s (± 0.17%)}	_{72.80s (± 0.27%)}	_{🔻+6.31s (+ 9.49%)}	_72.50s	_73.09s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,535,973	_2,535,973	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,535	_935,535	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,369,503k (± 0.01%)}	_{2,790,944k (± 0.01%)}	_{🔻+421,442k (+17.79%)}	_2,790,735k	_2,791,202k	_{p=0.005 n=6}
_{Parse Time}	_{11.37s (± 0.39%)}	_{13.29s (± 0.64%)}	_{🔻+1.92s (+16.92%)}	_13.19s	_13.40s	_{p=0.005 n=6}
_{Bind Time}	_{2.66s (± 0.57%)}	_{4.54s (± 0.27%)}	_{🔻+1.89s (+71.19%)}	_4.54s	_4.57s	_{p=0.004 n=6}
_{Check Time}	_{91.84s (± 1.04%)}	_{98.91s (± 4.39%)}	_{🔻+7.08s (+ 7.70%)}	_94.86s	_104.59s	_{p=0.005 n=6}
_{Emit Time}	_{0.35s (± 1.16%)}	_{0.35s (± 1.16%)}	_~	_0.35s	_0.36s	_{p=1.000 n=6}
_{Total Time}	_{106.21s (± 0.86%)}	_{117.11s (± 3.70%)}	_{🔻+10.89s (+10.26%)}	_112.95s	_122.71s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,610,360	_{🔻+352,254 (+28.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_296,415	_{🔻+30,149 (+11.32%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,026,235k (± 9.68%)}	_{4,422,498k (±15.51%)}	_{🔻+1,396,262k (+46.14%)}	_3,535,287k	_4,866,950k	_{p=0.005 n=6}
_{Parse Time}	_{6.54s (± 1.04%)}	_{8.50s (± 2.14%)}	_{🔻+1.97s (+30.07%)}	_8.27s	_8.66s	_{p=0.005 n=6}
_{Bind Time}	_{2.34s (± 1.24%)}	_{4.63s (± 1.18%)}	_{🔻+2.29s (+97.79%)}	_4.57s	_4.69s	_{p=0.005 n=6}
_{Check Time}	_{42.98s (± 0.47%)}	_{49.38s (± 0.59%)}	_{🔻+6.41s (+14.91%)}	_48.91s	_49.71s	_{p=0.005 n=6}
_{Emit Time}	_{3.48s (± 3.51%)}	_{4.85s (± 1.92%)}	_{🔻+1.37s (+39.51%)}	_4.76s	_4.98s	_{p=0.005 n=6}
_{Total Time}	_{55.34s (± 0.66%)}	_{67.37s (± 0.60%)}	_{🔻+12.04s (+21.75%)}	_66.82s	_67.73s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,610,360	_{🔻+352,254 (+28.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_296,415	_{🔻+30,149 (+11.32%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,645,072k (±10.90%)}	_{4,981,678k (± 0.02%)}	_{🔻+2,336,606k (+88.34%)}	_4,980,514k	_4,983,208k	_{p=0.005 n=6}
_{Parse Time}	_{8.22s (± 2.45%)}	_{10.80s (± 0.46%)}	_{🔻+2.58s (+31.42%)}	_10.73s	_10.86s	_{p=0.005 n=6}
_{Bind Time}	_{2.65s (± 2.00%)}	_{5.63s (± 1.13%)}	_{🔻+2.98s (+112.37%)}	_5.51s	_5.68s	_{p=0.005 n=6}
_{Check Time}	_{53.28s (± 0.46%)}	_{61.07s (± 0.28%)}	_{🔻+7.79s (+14.62%)}	_60.81s	_61.29s	_{p=0.005 n=6}
_{Emit Time}	_{4.58s (± 6.11%)}	_{6.03s (± 1.87%)}	_{🔻+1.44s (+31.44%)}	_5.87s	_6.22s	_{p=0.005 n=6}
_{Total Time}	_{68.74s (± 0.58%)}	_{83.54s (± 0.28%)}	_{🔻+14.80s (+21.54%)}	_83.26s	_83.88s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,785	_459,532	_{🔻+197,747 (+75.54%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_128,536	_{🔻+22,028 (+20.68%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,761k (± 0.01%)}	_{762,267k (± 0.01%)}	_{🔻+323,506k (+73.73%)}	_762,168k	_762,375k	_{p=0.005 n=6}
_{Parse Time}	_{4.38s (± 0.97%)}	_{5.43s (± 0.71%)}	_{🔻+1.05s (+24.08%)}	_5.37s	_5.48s	_{p=0.005 n=6}
_{Bind Time}	_{1.63s (± 0.72%)}	_{2.99s (± 0.72%)}	_{🔻+1.37s (+83.83%)}	_2.96s	_3.02s	_{p=0.005 n=6}
_{Check Time}	_{23.38s (± 0.35%)}	_{28.86s (± 0.42%)}	_{🔻+5.48s (+23.45%)}	_28.66s	_28.99s	_{p=0.005 n=6}
_{Emit Time}	_{1.92s (± 0.72%)}	_{3.28s (± 1.43%)}	_{🔻+1.35s (+70.22%)}	_3.20s	_3.33s	_{p=0.005 n=6}
_{Total Time}	_{31.31s (± 0.41%)}	_{40.55s (± 0.31%)}	_{🔻+9.24s (+29.53%)}	_40.34s	_40.68s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,158k (± 0.05%)}	_{508,568k (± 0.01%)}	_{🔻+137,410k (+37.02%)}	_508,462k	_508,638k	_{p=0.005 n=6}
_{Parse Time}	_{2.91s (± 1.16%)}	_{3.33s (± 0.99%)}	_{🔻+0.43s (+14.62%)}	_3.30s	_3.37s	_{p=0.005 n=6}
_{Bind Time}	_{1.59s (± 1.01%)}	_{2.42s (± 1.17%)}	_{🔻+0.83s (+52.36%)}	_2.37s	_2.45s	_{p=0.005 n=6}
_{Check Time}	_{16.37s (± 0.30%)}	_{16.82s (± 0.35%)}	_{+0.45s (+ 2.73%)}	_16.77s	_16.90s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.87s (± 0.26%)}	_{22.57s (± 0.12%)}	_{🔻+1.70s (+ 8.16%)}	_22.54s	_22.61s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,111,189	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,072,452	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,203,322k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{14.05s (± 0.50%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{4.44s (± 0.77%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{85.62s (± 1.57%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{23.36s (± 8.15%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{127.47s (± 2.51%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,140	_285,140	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,774	_115,774	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{434,848k (± 0.02%)}	_{560,241k (± 0.01%)}	_{🔻+125,393k (+28.84%)}	_560,202k	_560,293k	_{p=0.005 n=6}
_{Parse Time}	_{3.30s (± 0.49%)}	_{3.76s (± 0.15%)}	_{🔻+0.46s (+13.85%)}	_3.75s	_3.76s	_{p=0.004 n=6}
_{Bind Time}	_{1.46s (± 0.57%)}	_{2.04s (± 0.37%)}	_{🔻+0.57s (+39.14%)}	_2.03s	_2.05s	_{p=0.004 n=6}
_{Check Time}	_{15.28s (± 0.23%)}	_{15.89s (± 0.23%)}	_{🔻+0.61s (+ 4.00%)}	_15.84s	_15.93s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.04s (± 0.19%)}	_{21.69s (± 0.19%)}	_{🔻+1.64s (+ 8.19%)}	_21.63s	_21.72s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,858k (± 0.01%)}	_{586,623k (± 0.01%)}	_{🔻+102,766k (+21.24%)}	_586,507k	_586,707k	_{p=0.005 n=6}
_{Parse Time}	_{3.36s (± 0.64%)}	_{3.78s (± 0.52%)}	_{🔻+0.42s (+12.35%)}	_3.75s	_3.81s	_{p=0.005 n=6}
_{Bind Time}	_{1.17s (± 1.13%)}	_{1.96s (± 0.85%)}	_{🔻+0.79s (+67.28%)}	_1.94s	_1.98s	_{p=0.005 n=6}
_{Check Time}	_{19.03s (± 0.47%)}	_{19.84s (± 0.52%)}	_{🔻+0.81s (+ 4.23%)}	_19.68s	_19.95s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.57s (± 0.38%)}	_{25.57s (± 0.41%)}	_{🔻+2.00s (+ 8.50%)}	_25.41s	_25.71s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,320ms (± 0.22%)}	_{2,879ms (± 0.26%)}	_{🔻+559ms (+24.08%)}	_2,868ms	_2,888ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,282ms (± 0.50%)}	_{5,865ms (± 0.42%)}	_{🔻+584ms (+11.05%)}	_5,840ms	_5,898ms	_{p=0.005 n=6}
_{Req 3 - references}	_{265ms (± 0.78%)}	_{314ms (± 3.59%)}	_{🔻+50ms (+18.78%)}	_303ms	_326ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{229ms (± 0.66%)}	_{275ms (± 1.23%)}	_{🔻+46ms (+20.20%)}	_269ms	_277ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 6.31%)}	_{69ms (± 2.38%)}	_{🟩-14ms (-16.43%)}	_68ms	_72ms	_{p=0.004 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,460ms (± 0.82%)}	_{3,103ms (± 0.43%)}	_{🔻+643ms (+26.14%)}	_3,085ms	_3,119ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,972ms (± 0.42%)}	_{4,365ms (± 0.38%)}	_{🔻+393ms (+ 9.89%)}	_4,345ms	_4,386ms	_{p=0.005 n=6}
_{Req 3 - references}	_{283ms (± 1.09%)}	_{348ms (± 1.13%)}	_{🔻+65ms (+23.09%)}	_345ms	_356ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{226ms (± 0.28%)}	_{279ms (± 2.48%)}	_{🔻+53ms (+23.53%)}	_265ms	_282ms	_{p=0.003 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 5.60%)}	_{79ms (± 4.95%)}	_~	_76ms	_87ms	_{p=0.285 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,221ms (± 0.26%)}	_{6,536ms (± 0.47%)}	_{🔻+1,316ms (+25.21%)}	_6,492ms	_6,585ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,151ms (± 1.20%)}	_{1,114ms (± 0.56%)}	_{🟩-37ms (- 3.17%)}	_1,106ms	_1,124ms	_{p=0.005 n=6}
_{Req 3 - references}	_{80ms (± 4.76%)}	_{93ms (± 0.44%)}	_{🔻+13ms (+15.56%)}	_92ms	_93ms	_{p=0.003 n=6}
_{Req 4 - navto}	_{449ms (± 0.36%)}	_{403ms (± 1.41%)}	_{🟩-46ms (-10.24%)}	_397ms	_409ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_3,450	_3,450	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{843ms (± 0.79%)}	_{896ms (± 1.58%)}	_{🔻+53ms (+ 6.27%)}	_881ms	_910ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{160.06ms (± 0.17%)}	_{167.64ms (± 0.15%)}	_{🔻+7.58ms (+ 4.74%)}	_166.68ms	_171.44ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{234.30ms (± 0.15%)}	_{258.73ms (± 0.13%)}	_{🔻+24.43ms (+10.43%)}	_257.26ms	_264.12ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.16ms (± 0.15%)}	_{246.96ms (± 0.13%)}	_{🔻+17.80ms (+ 7.77%)}	_245.35ms	_250.81ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.58ms (± 0.16%)}	_{246.43ms (± 0.16%)}	_{🔻+17.85ms (+ 7.81%)}	_244.83ms	_250.49ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

rbuckton · 2024-10-03T19:30:28Z

@typescript-bot perf test faster

typescript-bot · 2024-10-03T19:30:31Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test faster`	✅ Started	👀 Results

typescript-bot · 2024-10-03T20:14:46Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,794k (± 0.71%)}	_{282,919k (± 0.05%)}	_{🔻+87,125k (+44.50%)}	_282,686k	_283,088k	_{p=0.005 n=6}
_{Parse Time}	_{1.61s (± 1.20%)}	_{1.70s (± 2.44%)}	_{🔻+0.09s (+ 5.48%)}	_1.65s	_1.76s	_{p=0.005 n=6}
_{Bind Time}	_{0.87s (± 1.03%)}	_{1.54s (± 0.89%)}	_{🔻+0.67s (+77.59%)}	_1.53s	_1.57s	_{p=0.005 n=6}
_{Check Time}	_{11.76s (± 0.61%)}	_{13.21s (± 1.38%)}	_{🔻+1.45s (+12.36%)}	_13.03s	_13.41s	_{p=0.005 n=6}
_{Emit Time}	_{3.36s (± 3.25%)}	_{4.49s (± 4.91%)}	_{🔻+1.13s (+33.68%)}	_4.08s	_4.71s	_{p=0.005 n=6}
_{Total Time}	_{17.60s (± 0.40%)}	_{20.95s (± 1.59%)}	_{🔻+3.35s (+19.02%)}	_20.35s	_21.32s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,612k (± 0.00%)}	_{1,811,305k (± 0.00%)}	_{🔻+586,694k (+47.91%)}	_1,811,260k	_1,811,340k	_{p=0.005 n=6}
_{Parse Time}	_{6.63s (± 0.49%)}	_{8.23s (± 0.77%)}	_{🔻+1.60s (+24.19%)}	_8.17s	_8.31s	_{p=0.005 n=6}
_{Bind Time}	_{1.89s (± 0.29%)}	_{3.96s (± 0.84%)}	_{🔻+2.07s (+109.90%)}	_3.92s	_4.01s	_{p=0.004 n=6}
_{Check Time}	_{31.76s (± 0.26%)}	_{36.03s (± 0.33%)}	_{🔻+4.26s (+13.42%)}	_35.86s	_36.15s	_{p=0.005 n=6}
_{Emit Time}	_{15.23s (± 0.53%)}	_{16.38s (± 0.26%)}	_{🔻+1.15s (+ 7.54%)}	_16.30s	_16.41s	_{p=0.005 n=6}
_{Total Time}	_{55.50s (± 0.24%)}	_{64.59s (± 0.23%)}	_{🔻+9.08s (+16.36%)}	_64.35s	_64.81s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,537,362	_2,537,362	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,789	_935,789	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,371,723k (± 0.00%)}	_{3,073,324k (± 0.00%)}	_{🔻+701,601k (+29.58%)}	_3,073,244k	_3,073,430k	_{p=0.005 n=6}
_{Parse Time}	_{9.49s (± 0.14%)}	_{11.08s (± 0.17%)}	_{🔻+1.60s (+16.81%)}	_11.05s	_11.10s	_{p=0.005 n=6}
_{Bind Time}	_{2.19s (± 0.55%)}	_{4.09s (± 0.51%)}	_{🔻+1.90s (+86.70%)}	_4.07s	_4.12s	_{p=0.004 n=6}
_{Check Time}	_{76.26s (± 0.52%)}	_{97.91s (± 0.92%)}	_{🔻+21.64s (+28.38%)}	_97.08s	_99.65s	_{p=0.005 n=6}
_{Emit Time}	_{0.28s (± 2.88%)}	_{0.30s (± 1.70%)}	_{🔻+0.02s (+ 7.06%)}	_0.30s	_0.31s	_{p=0.004 n=6}
_{Total Time}	_{88.23s (± 0.45%)}	_{113.39s (± 0.79%)}	_{🔻+25.16s (+28.51%)}	_112.55s	_115.11s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,646,954	_{🔻+388,848 (+30.91%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_304,305	_{🔻+38,039 (+14.29%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,381k (± 0.02%)}	_{4,085,849k (± 9.23%)}	_{🔻+1,663,468k (+68.67%)}	_3,841,962k	_4,573,342k	_{p=0.005 n=6}
_{Parse Time}	_{5.21s (± 0.81%)}	_{6.72s (± 0.82%)}	_{🔻+1.50s (+28.80%)}	_6.64s	_6.78s	_{p=0.005 n=6}
_{Bind Time}	_{1.94s (± 0.42%)}	_{4.12s (± 0.79%)}	_{🔻+2.18s (+112.56%)}	_4.07s	_4.16s	_{p=0.005 n=6}
_{Check Time}	_{35.57s (± 0.62%)}	_{45.03s (± 0.67%)}	_{🔻+9.46s (+26.59%)}	_44.63s	_45.35s	_{p=0.005 n=6}
_{Emit Time}	_{3.02s (± 1.59%)}	_{4.60s (± 0.37%)}	_{🔻+1.58s (+52.21%)}	_4.58s	_4.63s	_{p=0.005 n=6}
_{Total Time}	_{45.75s (± 0.38%)}	_{60.46s (± 0.49%)}	_{🔻+14.71s (+32.16%)}	_60.09s	_60.80s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,646,954	_{🔻+388,848 (+30.91%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_304,305	_{🔻+38,039 (+14.29%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,495,992k (± 0.02%)}	_{4,031,833k (± 7.28%)}	_{🔻+1,535,841k (+61.53%)}	_3,907,491k	_4,631,789k	_{p=0.005 n=6}
_{Parse Time}	_{5.36s (± 0.69%)}	_{6.87s (± 0.89%)}	_{🔻+1.51s (+28.20%)}	_6.82s	_6.99s	_{p=0.005 n=6}
_{Bind Time}	_{1.74s (± 0.43%)}	_{4.08s (± 0.40%)}	_{🔻+2.34s (+134.90%)}	_4.06s	_4.11s	_{p=0.004 n=6}
_{Check Time}	_{35.90s (± 0.15%)}	_{45.47s (± 0.50%)}	_{🔻+9.57s (+26.66%)}	_45.08s	_45.66s	_{p=0.005 n=6}
_{Emit Time}	_{3.05s (± 0.83%)}	_{4.74s (± 2.64%)}	_{🔻+1.69s (+55.30%)}	_4.60s	_4.91s	_{p=0.005 n=6}
_{Total Time}	_{46.06s (± 0.16%)}	_{61.16s (± 0.25%)}	_{🔻+15.10s (+32.80%)}	_60.91s	_61.31s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,785	_485,416	_{🔻+223,631 (+85.43%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_136,330	_{🔻+29,822 (+28.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,734k (± 0.01%)}	_{839,197k (± 0.02%)}	_{🔻+400,463k (+91.28%)}	_838,963k	_839,416k	_{p=0.005 n=6}
_{Parse Time}	_{3.53s (± 1.18%)}	_{4.50s (± 0.75%)}	_{🔻+0.98s (+27.69%)}	_4.46s	_4.56s	_{p=0.005 n=6}
_{Bind Time}	_{1.31s (± 1.15%)}	_{2.53s (± 0.82%)}	_{🔻+1.22s (+93.02%)}	_2.50s	_2.56s	_{p=0.005 n=6}
_{Check Time}	_{18.88s (± 0.41%)}	_{27.55s (± 1.83%)}	_{🔻+8.67s (+45.91%)}	_27.23s	_28.57s	_{p=0.005 n=6}
_{Emit Time}	_{1.53s (± 1.12%)}	_{3.31s (± 0.88%)}	_{🔻+1.78s (+116.21%)}	_3.28s	_3.36s	_{p=0.005 n=6}
_{Total Time}	_{25.25s (± 0.39%)}	_{37.90s (± 1.30%)}	_{🔻+12.65s (+50.10%)}	_37.55s	_38.89s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,174k (± 0.03%)}	_{532,076k (± 0.01%)}	_{🔻+160,903k (+43.35%)}	_531,999k	_532,198k	_{p=0.005 n=6}
_{Parse Time}	_{3.64s (± 0.64%)}	_{4.20s (± 1.10%)}	_{🔻+0.56s (+15.35%)}	_4.12s	_4.26s	_{p=0.005 n=6}
_{Bind Time}	_{1.97s (± 1.26%)}	_{3.23s (± 0.46%)}	_{🔻+1.26s (+64.18%)}	_3.21s	_3.25s	_{p=0.005 n=6}
_{Check Time}	_{20.35s (± 0.30%)}	_{22.46s (± 0.30%)}	_{🔻+2.11s (+10.36%)}	_22.39s	_22.58s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.95s (± 0.32%)}	_{29.89s (± 0.32%)}	_{🔻+3.93s (+15.15%)}	_29.80s	_30.06s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Symbols	_3,110,921	₀	_~	_~	_~	_{p=1.000 n=6+0}
_Types	_1,072,486	₀	_~	_~	_~	_{p=1.000 n=6+0}
_{Memory used}	_{3,203,828k (± 0.01%)}	_0k	_~	_~	_~	_{p=1.000 n=6+0}
_{Parse Time}	_{14.03s (± 0.17%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Bind Time}	_{4.52s (± 2.76%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Check Time}	_{85.57s (± 1.51%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Emit Time}	_{23.41s (± 7.49%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{Total Time}	_{127.53s (± 2.31%)}	_0s	_~	_~	_~	_{p=1.000 n=6+0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,146	_285,146	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,776	_115,776	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{434,827k (± 0.01%)}	_{600,285k (± 0.01%)}	_{🔻+165,458k (+38.05%)}	_600,237k	_600,353k	_{p=0.005 n=6}
_{Parse Time}	_{4.05s (± 0.46%)}	_{4.72s (± 0.56%)}	_{🔻+0.67s (+16.44%)}	_4.70s	_4.77s	_{p=0.005 n=6}
_{Bind Time}	_{1.72s (± 1.66%)}	_{2.71s (± 1.13%)}	_{🔻+0.99s (+57.31%)}	_2.67s	_2.75s	_{p=0.005 n=6}
_{Check Time}	_{18.27s (± 0.45%)}	_{20.22s (± 0.25%)}	_{🔻+1.94s (+10.63%)}	_20.13s	_20.28s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.05s (± 0.44%)}	_{27.64s (± 0.27%)}	_{🔻+3.59s (+14.93%)}	_27.57s	_27.78s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,897k (± 0.01%)}	_{629,406k (± 0.00%)}	_{🔻+145,509k (+30.07%)}	_629,373k	_629,446k	_{p=0.005 n=6}
_{Parse Time}	_{4.17s (± 0.68%)}	_{4.73s (± 0.70%)}	_{🔻+0.56s (+13.35%)}	_4.68s	_4.77s	_{p=0.005 n=6}
_{Bind Time}	_{1.46s (± 1.35%)}	_{2.75s (± 0.32%)}	_{🔻+1.29s (+88.79%)}	_2.74s	_2.76s	_{p=0.005 n=6}
_{Check Time}	_{23.64s (± 0.36%)}	_{26.09s (± 0.22%)}	_{🔻+2.45s (+10.38%)}	_25.99s	_26.16s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.26s (± 0.32%)}	_{33.56s (± 0.19%)}	_{🔻+4.30s (+14.70%)}	_33.45s	_33.63s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot assigned rbuckton Sep 17, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 17, 2024

Add initial slim AstNode API

5d99110

rbuckton force-pushed the slim-ast-node branch from a4bf1eb to 5d99110 Compare September 17, 2024 19:23

rbuckton added 2 commits September 17, 2024 16:12

Merge branch 'main' into slim-ast-node

37746fd

formatting

7e2f1bb

Less aggressive use of optional chaining

85e91cb

rbuckton force-pushed the slim-ast-node branch from 26d4107 to 85e91cb Compare September 18, 2024 17:14

migrate majority of parser to slim ast node

648e4a9

Add slim variant of forEachChild

014214a

rbuckton added 2 commits September 20, 2024 01:33

Unify types

0f2a20f

Monomorphic flag calculation and property access for name/jsDoc

aaf7906

Temporary monomorphic Node projection

2598c94

Merge branch 'main' into slim-ast-node

58e7fa6

Temporary monomorphic Node projection

6418f9c

rbuckton force-pushed the slim-ast-node branch from d6c6746 to fa46571 Compare October 3, 2024 19:18

Partial migration of utilities.ts, data property dispatch

29d90a6

rbuckton force-pushed the slim-ast-node branch from fa46571 to 29d90a6 Compare October 3, 2024 19:30

microsoft deleted a comment from typescript-bot Oct 3, 2024

DanielRosenwasser mentioned this pull request Oct 18, 2024

Design Meeting Notes, 10/11/2024 #60286

Open

[WIP] Experimental Slim AstNode API #59992

Are you sure you want to change the base?

[WIP] Experimental Slim AstNode API #59992

Conversation

rbuckton commented Sep 17, 2024 • edited Loading

TODO

typescript-bot commented Sep 17, 2024

rbuckton commented Sep 17, 2024

typescript-bot commented Sep 17, 2024

rbuckton commented Sep 17, 2024

typescript-bot commented Sep 17, 2024 • edited Loading

typescript-bot commented Sep 17, 2024

typescript-bot commented Sep 17, 2024

typescript-bot commented Sep 17, 2024

tsc

tsserver

startup

rbuckton commented Sep 17, 2024

typescript-bot commented Sep 17, 2024

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

Last few requests

Repro steps

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

typescript-bot commented Sep 17, 2024

rbuckton commented Sep 18, 2024

typescript-bot commented Sep 18, 2024 • edited Loading

typescript-bot commented Sep 18, 2024

tsc

tsserver

startup

rbuckton commented Sep 18, 2024

rbuckton commented Sep 18, 2024

typescript-bot commented Sep 18, 2024 • edited Loading

typescript-bot commented Sep 18, 2024

tsc

tsserver

startup

rbuckton commented Sep 18, 2024

typescript-bot commented Sep 18, 2024 • edited Loading

typescript-bot commented Sep 18, 2024

tsc

tsserver

startup

rbuckton commented Sep 20, 2024

typescript-bot commented Sep 20, 2024 • edited Loading

typescript-bot commented Sep 20, 2024

tsc

tsserver

startup

rbuckton commented Oct 1, 2024

typescript-bot commented Oct 1, 2024

rbuckton commented Oct 1, 2024

typescript-bot commented Oct 1, 2024 • edited Loading

typescript-bot commented Oct 1, 2024

tsc

tsserver

startup

rbuckton commented Oct 2, 2024

typescript-bot commented Oct 2, 2024 • edited Loading

typescript-bot commented Oct 2, 2024

tsc

tsserver

startup

rbuckton commented Oct 3, 2024

typescript-bot commented Oct 3, 2024 • edited Loading

typescript-bot commented Oct 3, 2024

[WIP] Experimental Slim `AstNode` API #59992

[WIP] Experimental Slim `AstNode` API #59992

rbuckton commented Sep 17, 2024 •

edited

Loading

typescript-bot commented Sep 17, 2024 •

edited

Loading

typescript-bot commented Sep 18, 2024 •

edited

Loading

typescript-bot commented Sep 18, 2024 •

edited

Loading

typescript-bot commented Sep 18, 2024 •

edited

Loading

typescript-bot commented Sep 20, 2024 •

edited

Loading

typescript-bot commented Oct 1, 2024 •

edited

Loading

typescript-bot commented Oct 2, 2024 •

edited

Loading

typescript-bot commented Oct 3, 2024 •

edited

Loading