-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underline type nodes without position mappings in .types baselines #57963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underling code seems fine to me; I can't think of a better way to do it.
Of course, the rest of the change is HugeMcLarge and we're going to have to fix all PRs, but I think we were okay with it just to get this coverage.
Unfortunately, due to the number of baselines that changed there are too many files in the diff view and it's crashing the browser tab when I try to comment. I provided some feedback to @weswigham offline. Otherwise, LGTM. |
The underlines themselves, we've talked about in general already, but the underlining logic should get a proper look-over - I think it's pretty good, but I wrote it 😄