Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AssertEntry and AssertClause interfaces #56485

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Make AssertEntry and AssertClause interfaces #56485

merged 1 commit into from
Nov 21, 2023

Conversation

andrewbranch
Copy link
Member

Fixes #56477

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 21, 2023
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@fatcerberus
Copy link

Ugh. I get that this is to fix a real-world break, but interface Foo extends Bar {} is just… yuck.

@andrewbranch
Copy link
Member Author

Getting in the weeds with DefinitelyTyped has conditioned me to see interface Foo extends SomeInterface {} as beautiful and type Foo = SomeInterface as unsettling

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIHI

@andrewbranch
Copy link
Member Author

🤔

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.3] Deprecated types (AssertEntry, AssertClause) redefined as type aliases, rather than interfaces
5 participants