Fixed accidental possibility to create `Infinity`/`-Infinity` number literal types #56301

Andarist · 2023-11-03T08:45:29Z

While there are some issues open about allowing those in some form, I think that - for the time being - the fact that they can be constructed (somewhat) should be considered a bug.

…literal types

typescript-bot · 2023-11-03T08:45:41Z

The TypeScript team hasn't accepted the linked issue #56272. If you can get it accepted, this PR will have a better chance of being reviewed.

jakebailey · 2023-11-13T18:31:43Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-11-13T18:31:48Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at e56d3c9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-13T18:31:48Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at e56d3c9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-13T18:31:48Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at e56d3c9. You can monitor the build here.

typescript-bot · 2023-11-13T18:31:48Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at e56d3c9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-13T18:31:48Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at e56d3c9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-13T18:33:55Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158562/artifacts?artifactName=tgz&fileId=9871919655992580B3C2C5C2A0869800491FAAC90E99AFFD7550D5FCCA784BAE02&fileName=/typescript-5.4.0-insiders.20231113.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-11-13T18:51:37Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56301/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-13T18:52:15Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,164k (± 0.01%)}	_{295,173k (± 0.02%)}	_~	_295,127k	_295,245k	_{p=1.000 n=6}
_{Parse Time}	_{2.63s (± 0.47%)}	_{2.64s (± 0.46%)}	_~	_2.62s	_2.65s	_{p=0.187 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.84s (± 0.97%)}	_~	_0.83s	_0.85s	_{p=0.523 n=6}
_{Check Time}	_{8.03s (± 0.27%)}	_{8.02s (± 0.21%)}	_~	_7.99s	_8.04s	_{p=0.460 n=6}
_{Emit Time}	_{7.09s (± 0.19%)}	_{7.08s (± 0.30%)}	_~	_7.05s	_7.11s	_{p=0.568 n=6}
_{Total Time}	_{18.58s (± 0.17%)}	_{18.57s (± 0.15%)}	_~	_18.53s	_18.60s	_{p=0.518 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,594k (± 1.64%)}	_{192,649k (± 1.56%)}	_~	_190,668k	_196,557k	_{p=1.000 n=6}
_{Parse Time}	_{1.35s (± 0.73%)}	_{1.34s (± 1.02%)}	_~	_1.32s	_1.36s	_{p=0.720 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.16s (± 0.16%)}	_{9.18s (± 0.15%)}	_~	_9.16s	_9.19s	_{p=0.161 n=6}
_{Emit Time}	_{2.63s (± 0.67%)}	_{2.62s (± 0.61%)}	_~	_2.61s	_2.65s	_{p=0.506 n=6}
_{Total Time}	_{13.87s (± 0.12%)}	_{13.88s (± 0.19%)}	_~	_13.83s	_13.90s	_{p=0.258 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,343k (± 0.00%)}	_{347,364k (± 0.00%)}	_{+21k (+ 0.01%)}	_347,355k	_347,374k	_{p=0.031 n=6}
_{Parse Time}	_{2.45s (± 0.92%)}	_{2.47s (± 0.34%)}	_~	_2.45s	_2.47s	_{p=0.458 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.55%)}	_~	_0.94s	_0.95s	_{p=0.595 n=6}
_{Check Time}	_{6.93s (± 0.53%)}	_{6.93s (± 0.37%)}	_~	_6.89s	_6.96s	_{p=0.809 n=6}
_{Emit Time}	_{4.04s (± 0.21%)}	_{4.04s (± 0.00%)}	_~	_4.04s	_4.04s	_{p=0.121 n=6}
_{Total Time}	_{14.37s (± 0.24%)}	_{14.37s (± 0.17%)}	_~	_14.34s	_14.40s	_{p=0.936 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,581k (± 0.01%)}	_{302,608k (± 0.01%)}	_~	_302,581k	_302,672k	_{p=0.066 n=6}
_{Parse Time}	_{2.01s (± 0.49%)}	_{2.00s (± 0.97%)}	_~	_1.97s	_2.03s	_{p=0.548 n=6}
_{Bind Time}	_{1.00s (± 0.41%)}	_{1.00s (± 1.03%)}	_~	_0.99s	_1.02s	_{p=0.924 n=6}
_{Check Time}	_{6.25s (± 0.43%)}	_{6.27s (± 0.25%)}	_~	_6.25s	_6.29s	_{p=0.328 n=6}
_{Emit Time}	_{3.58s (± 0.38%)}	_{3.59s (± 0.64%)}	_~	_3.56s	_3.62s	_{p=0.807 n=6}
_{Total Time}	_{12.85s (± 0.20%)}	_{12.86s (± 0.26%)}	_~	_12.82s	_12.90s	_{p=0.466 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,570k (± 0.00%)}	_{470,577k (± 0.00%)}	_~	_470,558k	_470,590k	_{p=0.514 n=6}
_{Parse Time}	_{2.56s (± 0.38%)}	_{2.57s (± 0.29%)}	_~	_2.56s	_2.58s	_{p=0.300 n=6}
_{Bind Time}	_{0.99s (± 1.05%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.063 n=6}
_{Check Time}	_{16.64s (± 0.30%)}	_{16.66s (± 0.43%)}	_~	_16.56s	_16.77s	_{p=0.521 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.22%)}	_{20.23s (± 0.34%)}	_~	_20.13s	_20.33s	_{p=0.230 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,817k (± 0.01%)}	_{512,811k (± 0.01%)}	_~	_512,759k	_512,863k	_{p=0.688 n=6}
_{Parse Time}	_{3.27s (± 0.46%)}	_{3.27s (± 0.42%)}	_~	_3.25s	_3.29s	_{p=0.933 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.55s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=0.311 n=6}
_{Check Time}	_{2.86s (± 0.14%)}	_{2.86s (± 0.78%)}	_~	_2.83s	_2.89s	_{p=1.000 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 6.19%)}	_~	_0.08s	_0.09s	_{p=0.595 n=6}
_{Total Time}	_{7.75s (± 0.11%)}	_{7.75s (± 0.49%)}	_~	_7.69s	_7.80s	_{p=0.745 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,383ms (± 1.19%)}	_{2,374ms (± 0.50%)}	_~	_2,357ms	_2,390ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{5,378ms (± 1.43%)}	_{5,424ms (± 1.35%)}	_~	_5,317ms	_5,481ms	_{p=0.471 n=6}
_{Req 3 - references}	_{328ms (± 0.69%)}	_{327ms (± 0.47%)}	_~	_325ms	_329ms	_{p=0.807 n=6}
_{Req 4 - navto}	_{277ms (± 1.06%)}	_{275ms (± 1.09%)}	_~	_273ms	_279ms	_{p=0.546 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.49%)}	_{85ms (± 8.79%)}	_~	_75ms	_90ms	_{p=0.315 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,508ms (± 0.67%)}	_{2,509ms (± 1.44%)}	_~	_2,458ms	_2,556ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{4,082ms (± 1.92%)}	_{4,134ms (± 1.92%)}	_~	_4,031ms	_4,193ms	_{p=0.173 n=6}
_{Req 3 - references}	_{342ms (± 1.19%)}	_{337ms (± 1.58%)}	_~	_333ms	_344ms	_{p=0.123 n=6}
_{Req 4 - navto}	_{282ms (± 0.29%)}	_{282ms (± 0.29%)}	_~	_281ms	_283ms	_{p=0.204 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 5.50%)}	_{82ms (± 7.23%)}	_~	_78ms	_90ms	_{p=0.262 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,602ms (± 0.41%)}	_{2,591ms (± 0.18%)}	_~	_2,583ms	_2,597ms	_{p=0.109 n=6}
_{Req 2 - geterr}	_{1,729ms (± 1.89%)}	_{1,713ms (± 2.42%)}	_~	_1,670ms	_1,772ms	_{p=0.810 n=6}
_{Req 3 - references}	_{111ms (± 8.51%)}	_{113ms (± 8.43%)}	_~	_100ms	_123ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{365ms (± 0.41%)}	_{366ms (± 0.56%)}	_~	_364ms	_369ms	_{p=0.510 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{316ms (± 1.13%)}	_{309ms (± 1.67%)}	_{-7ms (- 2.27%)}	_303ms	_315ms	_{p=0.019 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.31ms (± 0.22%)}	_{152.22ms (± 0.19%)}	_{-0.09ms (- 0.06%)}	_151.08ms	_154.28ms	_{p=0.001 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.30ms (± 0.16%)}	_{227.94ms (± 0.14%)}	_{-0.36ms (- 0.16%)}	_226.56ms	_230.50ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.21ms (± 0.17%)}	_{229.23ms (± 0.16%)}	_~	_227.80ms	_235.82ms	_{p=0.527 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.95ms (± 0.14%)}	_{228.92ms (± 0.15%)}	_~	_227.37ms	_231.91ms	_{p=0.165 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-13T19:23:17Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-11-13T20:44:06Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56301/merge:

Everything looks good!

Fixed accidental possibility to create Infinity/-Infinity number …

e56d3c9

…literal types

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 3, 2023

jakebailey approved these changes Nov 14, 2023

View reviewed changes

jakebailey mentioned this pull request Nov 15, 2023

Revert "Disallow numeric literals with negative numbers (#55268)" #56422

Merged

jakebailey closed this in #56422 Nov 15, 2023

DanielRosenwasser mentioned this pull request Nov 16, 2023

Design Meeting Notes, 11/15/2023 #56437

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed accidental possibility to create `Infinity`/`-Infinity` number literal types #56301

Fixed accidental possibility to create `Infinity`/`-Infinity` number literal types #56301

Andarist commented Nov 3, 2023

typescript-bot commented Nov 3, 2023

jakebailey commented Nov 13, 2023

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 13, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 13, 2023

typescript-bot commented Nov 13, 2023

Fixed accidental possibility to create Infinity/-Infinity number literal types #56301

Fixed accidental possibility to create Infinity/-Infinity number literal types #56301

Conversation

Andarist commented Nov 3, 2023

typescript-bot commented Nov 3, 2023

jakebailey commented Nov 13, 2023

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023 • edited Loading

typescript-bot commented Nov 13, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 13, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 13, 2023

typescript-bot commented Nov 13, 2023

Fixed accidental possibility to create `Infinity`/`-Infinity` number literal types #56301

Fixed accidental possibility to create `Infinity`/`-Infinity` number literal types #56301

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading

typescript-bot commented Nov 13, 2023 •

edited

Loading