Check callback parameters bivariantly if they result from instantiation #56218

ahejlsberg · 2023-10-25T15:58:38Z

This PR implements the fix described here.

ahejlsberg · 2023-10-25T15:59:13Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-10-25T15:59:16Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at aee645d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-25T15:59:16Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at aee645d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-25T15:59:16Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at aee645d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-25T15:59:16Z

Heya @ahejlsberg, I've started to run the tsc-only perf test suite on this PR at aee645d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-25T16:12:28Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,095k (± 0.01%)}	_{295,193k (± 0.01%)}	_{+98k (+ 0.03%)}	_295,156k	_295,270k	_{p=0.005 n=6}
_{Parse Time}	_{2.63s (± 0.29%)}	_{2.63s (± 0.31%)}	_~	_2.62s	_2.64s	_{p=0.729 n=6}
_{Bind Time}	_{0.84s (± 1.06%)}	_{0.84s (± 1.23%)}	_~	_0.83s	_0.85s	_{p=0.541 n=6}
_{Check Time}	_{8.05s (± 0.35%)}	_{8.09s (± 0.24%)}	_~	_8.06s	_8.12s	_{p=0.052 n=6}
_{Emit Time}	_{7.08s (± 0.39%)}	_{7.08s (± 0.27%)}	_~	_7.06s	_7.10s	_{p=1.000 n=6}
_{Total Time}	_{18.60s (± 0.17%)}	_{18.64s (± 0.14%)}	_~	_18.60s	_18.67s	_{p=0.054 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,656k (± 1.24%)}	_{192,202k (± 1.24%)}	_{+546k (+ 0.28%)}	_190,786k	_196,579k	_{p=0.045 n=6}
_{Parse Time}	_{1.35s (± 0.56%)}	_{1.34s (± 1.20%)}	_~	_1.32s	_1.36s	_{p=0.279 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.15s (± 0.25%)}	_{9.21s (± 0.39%)}	_{+0.06s (+ 0.62%)}	_9.17s	_9.25s	_{p=0.011 n=6}
_{Emit Time}	_{2.63s (± 0.56%)}	_{2.63s (± 0.61%)}	_~	_2.61s	_2.65s	_{p=1.000 n=6}
_{Total Time}	_{13.86s (± 0.23%)}	_{13.90s (± 0.32%)}	_~	_13.85s	_13.95s	_{p=0.147 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,363k (± 0.00%)}	_{347,382k (± 0.00%)}	_{+19k (+ 0.01%)}	_347,361k	_347,397k	_{p=0.031 n=6}
_{Parse Time}	_{2.46s (± 0.44%)}	_{2.45s (± 0.58%)}	_~	_2.43s	_2.47s	_{p=0.216 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.43%)}	_~	_0.94s	_0.95s	_{p=1.000 n=6}
_{Check Time}	_{6.91s (± 0.41%)}	_{6.93s (± 0.40%)}	_~	_6.89s	_6.96s	_{p=0.224 n=6}
_{Emit Time}	_{4.04s (± 0.48%)}	_{4.04s (± 0.43%)}	_~	_4.02s	_4.06s	_{p=1.000 n=6}
_{Total Time}	_{14.35s (± 0.23%)}	_{14.36s (± 0.24%)}	_~	_14.31s	_14.39s	_{p=0.746 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,589k (± 0.01%)}	_{302,613k (± 0.02%)}	_~	_302,572k	_302,687k	_{p=0.378 n=6}
_{Parse Time}	_{1.99s (± 0.88%)}	_{2.01s (± 0.93%)}	_{+0.03s (+ 1.43%)}	_1.99s	_2.04s	_{p=0.036 n=6}
_{Bind Time}	_{1.00s (± 1.17%)}	_{1.00s (± 0.83%)}	_~	_1.00s	_1.02s	_{p=0.547 n=6}
_{Check Time}	_{6.26s (± 0.52%)}	_{6.26s (± 0.52%)}	_~	_6.22s	_6.31s	_{p=0.935 n=6}
_{Emit Time}	_{3.58s (± 0.18%)}	_{3.57s (± 0.35%)}	_~	_3.55s	_3.58s	_{p=0.152 n=6}
_{Total Time}	_{12.83s (± 0.22%)}	_{12.85s (± 0.44%)}	_~	_12.79s	_12.93s	_{p=0.571 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,510k (± 0.01%)}	_{470,739k (± 0.01%)}	_{+229k (+ 0.05%)}	_470,690k	_470,765k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.45%)}	_{2.57s (± 0.64%)}	_~	_2.55s	_2.60s	_{p=0.681 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{1.00s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.206 n=6}
_{Check Time}	_{16.64s (± 0.47%)}	_{16.66s (± 0.36%)}	_~	_16.59s	_16.76s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.39%)}	_{20.23s (± 0.39%)}	_~	_20.13s	_20.36s	_{p=0.748 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,653k (± 0.02%)}	_{512,597k (± 0.01%)}	_~	_512,551k	_512,640k	_{p=0.378 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.19%)}	_~	_3.26s	_3.28s	_{p=0.654 n=6}
_{Bind Time}	_{1.55s (± 0.53%)}	_{1.55s (± 0.63%)}	_~	_1.54s	_1.56s	_{p=0.862 n=6}
_{Check Time}	_{2.84s (± 0.65%)}	_{2.86s (± 0.88%)}	_~	_2.84s	_2.90s	_{p=0.090 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.74s (± 0.15%)}	_{7.76s (± 0.36%)}	_~	_7.73s	_7.80s	_{p=0.195 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-10-25T16:17:34Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/56218/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2023-10-25T16:57:20Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-10-25T17:02:04Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/56218/merge:

Something interesting changed - please have a look.

Details

novuhq/novu

143 of 144 projects failed to build with the old tsc and were ignored

packages/notification-center-angular/projects/notification-center-angular/tsconfig.spec.json

error TS7016: Could not find a declaration file for module '@novu/notification-center'. '/mnt/ts_downloads/novu/packages/notification-center/dist/cjs/index.js' implicitly has an 'any' type.
- packages/notification-center-angular/projects/notification-center-angular/src/lib/notification-center.component.ts#L2

jakebailey · 2023-10-25T21:18:20Z

@typescript-bot pack this

typescript-bot · 2023-10-25T21:18:23Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at aee645d. You can monitor the build here.

typescript-bot · 2023-10-25T21:20:07Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158349/artifacts?artifactName=tgz&fileId=FA42913CBEB77CBB404E468255E16C4BCD9977D56309989D0E0BEAE6D7F6A3EF02&fileName=/typescript-5.3.0-insiders.20231025.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

ahejlsberg added 3 commits October 25, 2023 08:50

Exclude callback signatures that result from instantiation

05909c2

Accept new baselines

bff8927

Add regression tests

aee645d

typescript-bot assigned ahejlsberg Oct 25, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 25, 2023

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh October 25, 2023 16:01

RyanCavanaugh approved these changes Nov 30, 2023

View reviewed changes

ahejlsberg merged commit 8da01f3 into main Dec 1, 2023
19 checks passed

ahejlsberg deleted the fix51620 branch December 1, 2023 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check callback parameters bivariantly if they result from instantiation #56218

Check callback parameters bivariantly if they result from instantiation #56218

ahejlsberg commented Oct 25, 2023

ahejlsberg commented Oct 25, 2023

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023

Compiler

typescript-bot commented Oct 25, 2023

typescript-bot commented Oct 25, 2023

typescript-bot commented Oct 25, 2023

novuhq/novu

packages/notification-center-angular/projects/notification-center-angular/tsconfig.spec.json

jakebailey commented Oct 25, 2023

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

Check callback parameters bivariantly if they result from instantiation #56218

Check callback parameters bivariantly if they result from instantiation #56218

Conversation

ahejlsberg commented Oct 25, 2023

ahejlsberg commented Oct 25, 2023

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023

Compiler

typescript-bot commented Oct 25, 2023

typescript-bot commented Oct 25, 2023

typescript-bot commented Oct 25, 2023

novuhq/novu

packages/notification-center-angular/projects/notification-center-angular/tsconfig.spec.json

jakebailey commented Oct 25, 2023

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023 • edited Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading

typescript-bot commented Oct 25, 2023 •

edited

Loading