-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit declarations using alias chains #56100
base: main
Are you sure you want to change the base?
Emit declarations using alias chains #56100
Conversation
1f223aa
to
a9f6ea6
Compare
Obligatory: Is there a linked issue? AFAIK this is sensible, but probably expensive - I say that, but I'm also actively working on a replacement for I'd also say "we want to check the perf on this, at least", but declaration emit performance is still a bit of a blind spot in our perf suite. It's usually only lightly exercised by the error messages generated by the perf tests. 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, definitely see if this can be integrated into the normal getAccessibleSymbolChain
function. It has some inefficiencies that I'm looking into fixing, but so does this solution as-written, so better to keep them in one place.
Also linked (atm. unclear if this fixes it though): #55021 |
fixes #57415