Some of the test refactoring and readable baselining #56075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
jakebailey
reviewed
Oct 12, 2023
| @@ -3450,7 +3450,6 @@ declare namespace ts { | |||
| getLanguageService(): never; | |||
| getHostForAutoImportProvider(): never; | |||
| getProjectReferences(): readonly ts.ProjectReference[] | undefined; | |||
| getTypeAcquisition(): TypeAcquisition; | |||
There was a problem hiding this comment.
Is this an intentional change?
There was a problem hiding this comment.
It isnt test only change but i had done this as part of #56074 first and since it has no impact, left it there
jakebailey
reviewed
Oct 12, 2023
sheetalkamat
commented
Oct 12, 2023
| @@ -211,37 +214,37 @@ export function discoverTypings( | |||
| ); | |||
| addInferredTypings(module, "Inferred typings from unresolved imports"); | |||
| } | |||
| // Remove typings that the user has added to the exclude list | |||
There was a problem hiding this comment.
This is order change and shouldnt have any impact as such on functionality a359540
sheetalkamat
commented
Oct 12, 2023
| @@ -2640,10 +2640,6 @@ export class AutoImportProviderProject extends Project { | |||
| return PackageJsonAutoImportPreference.Off; | |||
| } | |||
|
|
|||
| override getTypeAcquisition(): TypeAcquisition { | |||
There was a problem hiding this comment.
This shouldnt be needed since default typeAcquisition is always disabled ae1b510
jakebailey
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #56074