Move @typescript-eslint/no-namespace to disabled list #55180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule fires for these:
The first three are functions which are canonically empty (which we'd exempt). It's possible that we'd always use
noop
when we wanted an empty function, so it would seem like this rule is fine to keep things consistent.However, the last file's errors are in a test which checks that the shape of things is correct, such that it's not really a problem that they are empty, but there's no way we could use
noop
to achieve the same goals, only throw or something to say "this is intentionally empty".I'm not sure if this rule gets us much; if anything it'd just be an annoyance in the editor when we are working on the code, similarly to my thoughts on
no-empty-interface
.