Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of decorator-injected initializers #54269

Merged
merged 1 commit into from
May 17, 2023

Conversation

rbuckton
Copy link
Member

NOTE: We will also need to make the same change to tslib.

Fixes #54267

@rbuckton rbuckton requested review from sandersn and andrewbranch May 16, 2023 19:07
@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 16, 2023
@rbuckton rbuckton merged commit b14264a into main May 17, 2023
@rbuckton rbuckton deleted the accessor-field-decorator-init-order branch May 17, 2023 21:12
@rbuckton
Copy link
Member Author

@DanielRosenwasser do you want to cherry-pick this for the RC, or wait until after RC?

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-5.1 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 17, 2023

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.1 on this PR at 163ade8. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.1 manually.

nberlette added a commit to nberlette/TypeScript that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change evaluation order of decorator-injected initializers
4 participants