Remove declares in sys, core, evaluatorImpl #53176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Mar 9, 2023
| @@ -1507,7 +1501,7 @@ export let sys: System = (() => { | |||
| getAccessibleSortedChildDirectories: path => getAccessibleFileSystemEntries(path).directories, | |||
| realpath, | |||
| tscWatchFile: process.env.TSC_WATCHFILE, | |||
| useNonPollingWatchers: process.env.TSC_NONPOLLING_WATCHER, | |||
| useNonPollingWatchers: !!process.env.TSC_NONPOLLING_WATCHER, | |||
There was a problem hiding this comment.
This one is really suspicious; should we be parsing this rather than checking for truthiness? I made it !! to match current behavior, but, it seems unexpected.
There was a problem hiding this comment.
@sheetalkamat Do you have any advice for this particular place? Is this "fine" or was it intended that we let you set TSC_NONPOLLING_WATCHER=false or TSC_NONPOLLING_WATCHER=0 or TSC_NONPOLLING_WATCHER=off or similar?
There was a problem hiding this comment.
I think its fine to fix it this way. This is from way back... given we have watchOptions now i dont think it matters. We probably should deprecate these environment variable options.
sheetalkamat
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all don't need to be there.
compilerreferences the node types, so we can dosys.tsandcore.tssafely, which exposes some unsafety / redundant casts.