Do not resolve apparent type of mapped types with a tuple constraint

[Andarist]

fixes #52650

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at be33c06. You can monitor the build here.

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52651/merge:

Everything looks good!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52651/merge:

Everything looks good!

[typescript-bot]

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52651

Metric	main	52651	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	359,797k (± 0.02%)	359,805k (± 0.02%)	~	359,726k	359,907k	p=1.000 n=6
Parse Time	3.93s (± 0.90%)	3.94s (± 1.30%)	~	3.86s	4.00s	p=0.687 n=6
Bind Time	1.17s (± 0.64%)	1.18s (± 0.44%)	+0.01s (+ 1.00%)	1.18s	1.19s	p=0.020 n=6
Check Time	8.71s (± 0.72%)	8.70s (± 0.44%)	~	8.63s	8.74s	p=0.810 n=6
Emit Time	7.61s (± 0.87%)	7.60s (± 0.52%)	~	7.55s	7.67s	p=0.808 n=6
Total Time	21.42s (± 0.68%)	21.42s (± 0.24%)	~	21.33s	21.48s	p=0.629 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	193,220k (± 1.19%)	195,050k (± 1.55%)	~	192,216k	197,982k	p=0.378 n=6
Parse Time	1.63s (± 1.32%)	1.62s (± 1.63%)	~	1.59s	1.65s	p=0.220 n=6
Bind Time	0.80s (± 0.65%)	0.80s (± 0.51%)	~	0.80s	0.81s	p=0.114 n=6
Check Time	9.75s (± 0.52%)	9.75s (± 0.84%)	~	9.69s	9.91s	p=0.936 n=6
Emit Time	2.80s (± 1.01%)	2.87s (± 4.68%)	~	2.78s	3.14s	p=0.197 n=6
Total Time	14.98s (± 0.46%)	15.04s (± 0.98%)	~	14.89s	15.30s	p=0.422 n=6
Monaco - node (v18.10.0, x64)
Memory used	343,965k (± 0.01%)	343,958k (± 0.02%)	~	343,865k	344,050k	p=0.810 n=6
Parse Time	2.94s (± 0.84%)	2.94s (± 0.88%)	~	2.89s	2.96s	p=1.000 n=6
Bind Time	1.04s (± 1.32%)	1.04s (± 1.12%)	~	1.03s	1.06s	p=0.506 n=6
Check Time	7.07s (± 0.47%)	7.04s (± 0.50%)	~	7.02s	7.11s	p=0.126 n=6
Emit Time	4.33s (± 1.22%)	4.32s (± 0.53%)	~	4.30s	4.36s	p=0.573 n=6
Total Time	15.37s (± 0.45%)	15.34s (± 0.40%)	~	15.25s	15.41s	p=0.374 n=6
TFS - node (v18.10.0, x64)
Memory used	300,377k (± 0.01%)	300,362k (± 0.01%)	~	300,336k	300,392k	p=0.298 n=6
Parse Time	2.27s (± 1.71%)	2.27s (± 1.84%)	~	2.20s	2.32s	p=1.000 n=6
Bind Time	1.17s (± 0.44%)	1.18s (± 0.64%)	+0.01s (+ 1.00%)	1.17s	1.19s	p=0.020 n=6
Check Time	6.54s (± 0.65%)	6.55s (± 0.66%)	~	6.51s	6.63s	p=1.000 n=6
Emit Time	3.93s (± 1.01%)	3.93s (± 0.75%)	~	3.90s	3.96s	p=1.000 n=6
Total Time	13.92s (± 0.51%)	13.93s (± 0.49%)	~	13.84s	14.03s	p=0.936 n=6
material-ui - node (v18.10.0, x64)
Memory used	476,782k (± 0.01%)	476,787k (± 0.00%)	~	476,760k	476,822k	p=0.810 n=6
Parse Time	3.53s (± 0.46%)	3.52s (± 0.62%)	~	3.50s	3.56s	p=0.406 n=6
Bind Time	0.97s (± 0.53%)	0.97s (± 0.78%)	~	0.96s	0.98s	p=0.784 n=6
Check Time	17.12s (± 0.55%)	17.20s (± 0.42%)	~	17.10s	17.26s	p=0.126 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.61s (± 0.38%)	21.68s (± 0.39%)	~	21.57s	21.76s	p=0.227 n=6
xstate - node (v18.10.0, x64)
Memory used	549,092k (± 0.03%)	549,137k (± 0.02%)	~	548,872k	549,224k	p=0.575 n=6
Parse Time	4.58s (± 0.67%)	4.58s (± 0.69%)	~	4.52s	4.61s	p=0.629 n=6
Bind Time	1.71s (± 1.26%)	1.71s (± 0.57%)	~	1.69s	1.72s	p=0.864 n=6
Check Time	2.81s (± 0.54%)	2.82s (± 0.39%)	~	2.80s	2.83s	p=0.415 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	9.20s (± 0.25%)	9.19s (± 0.36%)	~	9.13s	9.22s	p=0.747 n=6
Angular - node (v16.17.1, x64)
Memory used	359,144k (± 0.01%)	359,159k (± 0.00%)	~	359,146k	359,175k	p=0.199 n=6
Parse Time	4.17s (± 0.45%)	4.18s (± 0.61%)	~	4.16s	4.23s	p=0.222 n=6
Bind Time	1.24s (± 0.41%)	1.23s (± 0.33%)	-0.01s (- 0.94%)	1.23s	1.24s	p=0.007 n=6
Check Time	9.49s (± 0.19%)	9.49s (± 0.52%)	~	9.40s	9.55s	p=0.745 n=6
Emit Time	8.06s (± 0.35%)	8.05s (± 0.37%)	~	8.01s	8.09s	p=0.739 n=6
Total Time	22.96s (± 0.23%)	22.96s (± 0.29%)	~	22.89s	23.04s	p=1.000 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	193,814k (± 0.04%)	193,887k (± 0.05%)	~	193,780k	194,016k	p=0.109 n=6
Parse Time	1.80s (± 0.93%)	1.81s (± 0.42%)	~	1.80s	1.82s	p=0.155 n=6
Bind Time	0.84s (± 0.00%)	0.84s (± 0.61%)	~	0.84s	0.85s	p=0.174 n=6
Check Time	10.42s (± 0.35%)	10.49s (± 0.44%)	+0.07s (+ 0.62%)	10.43s	10.54s	p=0.035 n=6
Emit Time	3.10s (± 4.70%)	3.06s (± 0.80%)	~	3.03s	3.10s	p=0.747 n=6
Total Time	16.17s (± 1.07%)	16.20s (± 0.33%)	~	16.13s	16.25s	p=0.229 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,232k (± 0.01%)	343,219k (± 0.01%)	~	343,189k	343,268k	p=0.748 n=6
Parse Time	3.14s (± 1.50%)	3.13s (± 1.08%)	~	3.10s	3.19s	p=0.746 n=6
Bind Time	1.11s (± 1.51%)	1.11s (± 0.46%)	~	1.11s	1.12s	p=0.928 n=6
Check Time	7.73s (± 0.25%)	7.74s (± 0.58%)	~	7.68s	7.80s	p=0.629 n=6
Emit Time	4.54s (± 0.46%)	4.51s (± 0.87%)	~	4.46s	4.56s	p=0.466 n=6
Total Time	16.51s (± 0.50%)	16.50s (± 0.68%)	~	16.34s	16.66s	p=0.687 n=6
TFS - node (v16.17.1, x64)
Memory used	299,706k (± 0.01%)	299,711k (± 0.01%)	~	299,678k	299,745k	p=0.936 n=6
Parse Time	2.46s (± 0.99%)	2.45s (± 0.83%)	~	2.42s	2.47s	p=0.570 n=6
Bind Time	1.26s (± 0.82%)	1.25s (± 0.67%)	~	1.24s	1.26s	p=0.788 n=6
Check Time	7.21s (± 0.39%)	7.20s (± 0.31%)	~	7.16s	7.22s	p=0.226 n=6
Emit Time	4.22s (± 0.21%)	4.24s (± 0.80%)	~	4.21s	4.30s	p=0.363 n=6
Total Time	15.15s (± 0.23%)	15.14s (± 0.32%)	~	15.08s	15.19s	p=0.686 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,012k (± 0.01%)	476,025k (± 0.00%)	~	475,999k	476,065k	p=0.575 n=6
Parse Time	3.68s (± 0.14%)	3.67s (± 0.76%)	~	3.62s	3.70s	p=1.000 n=6
Bind Time	1.02s (± 0.40%)	1.02s (± 0.40%)	~	1.02s	1.03s	p=0.218 n=6
Check Time	18.21s (± 0.67%)	18.23s (± 0.44%)	~	18.12s	18.35s	p=0.575 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.91s (± 0.54%)	22.92s (± 0.34%)	~	22.85s	23.06s	p=0.630 n=6
xstate - node (v16.17.1, x64)
Memory used	546,665k (± 0.01%)	546,643k (± 0.01%)	~	546,558k	546,746k	p=0.575 n=6
Parse Time	4.77s (± 0.22%)	4.78s (± 0.60%)	~	4.75s	4.83s	p=0.224 n=6
Bind Time	1.84s (± 0.28%)	1.86s (± 0.44%)	+0.01s (+ 0.72%)	1.85s	1.87s	p=0.014 n=6
Check Time	3.06s (± 0.65%)	3.06s (± 0.76%)	~	3.03s	3.08s	p=0.669 n=6
Emit Time	0.09s (± 4.45%)	0.09s (± 4.45%)	~	0.09s	0.10s	p=1.000 n=6
Total Time	9.76s (± 0.29%)	9.80s (± 0.36%)	~	9.74s	9.84s	p=0.093 n=6
Angular - node (v14.15.1, x64)
Memory used	352,818k (± 0.01%)	352,771k (± 0.03%)	~	352,540k	352,848k	p=0.810 n=6
Parse Time	4.23s (± 0.35%)	4.22s (± 0.45%)	~	4.20s	4.25s	p=0.417 n=6
Bind Time	1.28s (± 0.80%)	1.28s (± 0.85%)	~	1.26s	1.29s	p=0.863 n=6
Check Time	9.74s (± 0.71%)	9.75s (± 0.53%)	~	9.69s	9.82s	p=0.872 n=6
Emit Time	8.37s (± 0.54%)	8.49s (± 2.94%)	~	8.32s	8.99s	p=0.259 n=6
Total Time	23.61s (± 0.42%)	23.73s (± 1.00%)	~	23.52s	24.17s	p=0.471 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	188,784k (± 0.05%)	188,775k (± 0.05%)	~	188,697k	188,969k	p=0.689 n=6
Parse Time	1.83s (± 0.41%)	1.83s (± 0.82%)	~	1.82s	1.86s	p=0.933 n=6
Bind Time	0.87s (± 0.97%)	0.87s (± 0.63%)	~	0.86s	0.87s	p=0.855 n=6
Check Time	10.50s (± 0.59%)	10.54s (± 0.56%)	~	10.44s	10.62s	p=0.377 n=6
Emit Time	3.39s (± 3.89%)	3.42s (± 4.16%)	~	3.13s	3.50s	p=0.374 n=6
Total Time	16.59s (± 1.03%)	16.65s (± 0.90%)	~	16.39s	16.83s	p=0.688 n=6
Monaco - node (v14.15.1, x64)
Memory used	337,993k (± 0.00%)	337,986k (± 0.01%)	~	337,954k	338,013k	p=0.689 n=6
Parse Time	3.20s (± 0.67%)	3.20s (± 0.70%)	~	3.17s	3.23s	p=1.000 n=6
Bind Time	1.11s (± 0.46%)	1.12s (± 0.49%)	~	1.11s	1.12s	p=0.640 n=6
Check Time	8.11s (± 0.56%)	8.09s (± 0.57%)	~	8.02s	8.12s	p=0.125 n=6
Emit Time	4.80s (± 0.83%)	4.77s (± 0.44%)	~	4.75s	4.80s	p=0.106 n=6
Total Time	17.23s (± 0.34%)	17.17s (± 0.48%)	~	17.06s	17.25s	p=0.423 n=6
TFS - node (v14.15.1, x64)
Memory used	294,575k (± 0.01%)	294,567k (± 0.01%)	~	294,545k	294,595k	p=0.521 n=6
Parse Time	2.74s (± 0.68%)	2.74s (± 0.30%)	~	2.73s	2.75s	p=0.459 n=6
Bind Time	1.11s (± 0.95%)	1.11s (± 0.37%)	~	1.11s	1.12s	p=0.209 n=6
Check Time	7.51s (± 0.47%)	7.55s (± 0.43%)	~	7.51s	7.61s	p=0.090 n=6
Emit Time	4.63s (± 1.03%)	4.66s (± 0.53%)	~	4.63s	4.69s	p=0.291 n=6
Total Time	15.99s (± 0.44%)	16.06s (± 0.21%)	~	16.01s	16.10s	p=0.109 n=6
material-ui - node (v14.15.1, x64)
Memory used	471,622k (± 0.00%)	471,616k (± 0.01%)	~	471,561k	471,649k	p=0.810 n=6
Parse Time	3.88s (± 0.72%)	3.86s (± 0.56%)	~	3.83s	3.89s	p=0.223 n=6
Bind Time	1.05s (± 0.00%)	1.05s (± 0.49%)	~	1.04s	1.05s	p=0.174 n=6
Check Time	19.14s (± 0.77%)	19.19s (± 0.82%)	~	18.96s	19.43s	p=0.575 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	24.07s (± 0.57%)	24.10s (± 0.72%)	~	23.86s	24.36s	p=0.689 n=6
xstate - node (v14.15.1, x64)
Memory used	534,749k (± 0.00%)	534,722k (± 0.01%)	~	534,656k	534,758k	p=0.261 n=6
Parse Time	5.12s (± 0.82%)	5.12s (± 0.52%)	~	5.10s	5.16s	p=1.000 n=6
Bind Time	1.71s (± 0.60%)	1.71s (± 0.68%)	~	1.69s	1.72s	p=0.801 n=6
Check Time	3.13s (± 0.48%)	3.14s (± 0.51%)	~	3.12s	3.16s	p=0.285 n=6
Emit Time	0.10s (± 4.01%)	0.10s (± 0.00%)	~	0.10s	0.10s	p=0.405 n=6
Total Time	10.06s (± 0.36%)	10.08s (± 0.33%)	~	10.03s	10.12s	p=0.520 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52651	6
Baseline	main	6

TSServer

Comparison Report - main..52651

Metric	main	52651	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,496ms (± 1.28%)	2,519ms (± 1.79%)	~	2,467ms	2,587ms	p=0.575 n=6
Req 2 - geterr	5,511ms (± 0.57%)	5,592ms (± 0.41%)	+82ms (+ 1.48%)	5,564ms	5,622ms	p=0.005 n=6
Req 3 - references	370ms (± 1.13%)	367ms (± 0.79%)	~	364ms	371ms	p=0.293 n=6
Req 4 - navto	284ms (± 0.99%)	285ms (± 0.56%)	~	283ms	287ms	p=0.629 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	73ms (± 1.03%)	73ms (± 1.94%)	~	71ms	75ms	p=0.867 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,739ms (± 0.79%)	2,748ms (± 0.67%)	~	2,714ms	2,768ms	p=0.873 n=6
Req 2 - geterr	4,059ms (± 0.64%)	4,058ms (± 0.37%)	~	4,040ms	4,076ms	p=0.575 n=6
Req 3 - references	368ms (± 0.72%)	367ms (± 1.45%)	~	359ms	374ms	p=1.000 n=6
Req 4 - navto	293ms (± 0.88%)	294ms (± 0.76%)	~	292ms	298ms	p=0.871 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	66ms (± 0.79%)	66ms (± 1.48%)	~	65ms	67ms	p=0.348 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,490ms (± 0.82%)	3,495ms (± 0.53%)	~	3,476ms	3,518ms	p=1.000 n=6
Req 2 - geterr	1,648ms (± 0.66%)	1,653ms (± 0.73%)	~	1,635ms	1,668ms	p=0.261 n=6
Req 3 - references	104ms (± 1.05%)	105ms (± 1.40%)	~	103ms	106ms	p=0.403 n=6
Req 4 - navto	355ms (± 0.53%)	356ms (± 1.22%)	~	353ms	364ms	p=1.000 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	450ms (± 0.90%)	447ms (± 1.72%)	~	433ms	454ms	p=0.572 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,770ms (± 0.58%)	2,764ms (± 0.49%)	~	2,744ms	2,778ms	p=0.423 n=6
Req 2 - geterr	5,930ms (± 0.53%)	5,929ms (± 0.64%)	~	5,878ms	5,991ms	p=0.810 n=6
Req 3 - references	377ms (± 0.76%)	375ms (± 0.90%)	~	370ms	378ms	p=0.220 n=6
Req 4 - navto	277ms (± 0.91%)	279ms (± 0.64%)	~	276ms	281ms	p=0.142 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	79ms (± 2.70%)	82ms (± 4.45%)	~	77ms	85ms	p=0.195 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,924ms (± 0.37%)	2,915ms (± 0.57%)	~	2,897ms	2,940ms	p=0.378 n=6
Req 2 - geterr	4,412ms (± 0.53%)	4,405ms (± 0.47%)	~	4,386ms	4,441ms	p=0.873 n=6
Req 3 - references	382ms (± 1.07%)	380ms (± 1.10%)	~	375ms	386ms	p=0.519 n=6
Req 4 - navto	287ms (± 0.56%)	287ms (± 0.60%)	~	284ms	289ms	p=1.000 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	71ms (± 0.57%)	71ms (± 0.00%)	~	71ms	71ms	p=0.405 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,626ms (± 0.35%)	3,630ms (± 0.51%)	~	3,597ms	3,647ms	p=0.471 n=6
Req 2 - geterr	1,825ms (± 1.51%)	1,810ms (± 0.99%)	~	1,785ms	1,837ms	p=0.377 n=6
Req 3 - references	113ms (± 1.42%)	112ms (± 1.49%)	~	109ms	113ms	p=0.277 n=6
Req 4 - navto	344ms (± 1.02%)	344ms (± 1.36%)	~	337ms	350ms	p=0.868 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	457ms (± 0.99%)	457ms (± 0.97%)	~	452ms	463ms	p=0.627 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,884ms (± 0.28%)	2,884ms (± 0.29%)	~	2,874ms	2,895ms	p=1.000 n=6
Req 2 - geterr	6,277ms (± 0.73%)	6,331ms (± 0.74%)	~	6,260ms	6,399ms	p=0.066 n=6
Req 3 - references	391ms (± 0.53%)	391ms (± 0.95%)	~	386ms	396ms	p=1.000 n=6
Req 4 - navto	280ms (± 1.31%)	288ms (± 2.25%)	+7ms (+ 2.56%)	279ms	298ms	p=0.044 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	99ms (± 1.69%)	90ms (± 9.83%)	~	80ms	100ms	p=0.167 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,038ms (± 0.96%)	3,046ms (± 0.62%)	~	3,031ms	3,082ms	p=0.376 n=6
Req 2 - geterr	4,695ms (± 0.40%)	4,709ms (± 0.44%)	~	4,682ms	4,736ms	p=0.336 n=6
Req 3 - references	404ms (± 0.43%)	403ms (± 0.66%)	~	400ms	408ms	p=0.293 n=6
Req 4 - navto	293ms (± 1.30%)	294ms (± 1.27%)	~	289ms	299ms	p=0.624 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	82ms (± 3.84%)	82ms (± 3.84%)	~	80ms	88ms	p=1.000 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,955ms (± 0.60%)	3,945ms (± 0.46%)	~	3,927ms	3,970ms	p=0.378 n=6
Req 2 - geterr	1,776ms (± 1.68%)	1,822ms (± 1.74%)	+45ms (+ 2.55%)	1,785ms	1,856ms	p=0.020 n=6
Req 3 - references	133ms (± 1.99%)	130ms (± 3.34%)	~	124ms	135ms	p=0.075 n=6
Req 4 - navto	375ms (± 0.95%)	375ms (± 0.54%)	~	372ms	378ms	p=0.745 n=6
Req 5 - completionInfo count	3,175 (± 0.00%)	3,175 (± 0.00%)	~	3,175	3,175	p=1.000 n=6
Req 5 - completionInfo	470ms (± 2.40%)	471ms (± 2.13%)	~	457ms	480ms	p=0.810 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	52651	6
Baseline	main	6

Startup

Comparison Report - main..52651

Metric	main	52651	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	142.53ms (± 0.21%)	142.82ms (± 0.20%)	+0.30ms (+ 0.21%)	141.85ms	147.47ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	227.47ms (± 0.18%)	231.85ms (± 0.35%)	+4.39ms (+ 1.93%)	226.75ms	238.12ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	228.98ms (± 0.13%)	233.36ms (± 0.18%)	+4.38ms (+ 1.91%)	229.89ms	239.09ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	209.74ms (± 0.15%)	211.88ms (± 0.38%)	+2.14ms (+ 1.02%)	208.73ms	218.01ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52651	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52651/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

{"seq":6466,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":335,"offset":22}}
{"seq":6467,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":400,"offset":25,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":6468,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":400,"offset":25,"entryNames":["applyDatabaseMigrations"]}}
{"seq":6469,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":580,"offset":35}}

Repro Steps

1. git clone https://github.com/backstage/backstage --recurse-submodules
2. In dir backstage, run git reset --hard 2db93700fe9cc19a7db4f0711544b0c189aefeba
3. Install packages (exact steps are below, but it might be easier to follow the repo readme)

   1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
   2. In dir backstage/microsite-next, run yarn install --no-immutable --mode=skip-build
   3. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
   4. In dir backstage, run yarn install --no-immutable --mode=skip-build
   5. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
4. Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
5. npm install --no-save @typescript/server-replay
6. npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

codex-team/editor.js

⚠️ Note that built also had errors ⚠️

Req #4391 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-main/built/local/tsserver.js:140793:13)
    at /typescript-main/built/local/tsserver.js:146513:38
    at importSymbols (/typescript-main/built/local/tsserver.js:146513:11)
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145946:11)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148372:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176789:43)
    at /typescript-main/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180728:14)

Req #4391 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-52651/built/local/tsserver.js:140793:13)
    at /typescript-52651/built/local/tsserver.js:146513:38
    at importSymbols (/typescript-52651/built/local/tsserver.js:146513:11)
    at Object.addNewNodeForMemberSymbol (/typescript-52651/built/local/tsserver.js:145946:11)
    at getEntryForMemberCompletion (/typescript-52651/built/local/tsserver.js:148372:22)
    at createCompletionEntry (/typescript-52651/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-52651/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-52651/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-52651/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52651/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-52651/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-52651/built/local/tsserver.js:176789:43)
    at /typescript-52651/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-52651/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-52651/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-52651/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-52651/built/local/tsserver.js:180728:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/codex-team.editor.js.rawError.txt in the artifact folder

Last few requests

{"seq":4388,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":331,"offset":1,"entryNames":["_"]}}
{"seq":4389,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":391,"offset":14,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":4390,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":391,"offset":14,"entryNames":["_"]}}
{"seq":4391,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":425,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

1. git clone https://github.com/codex-team/editor.js --recurse-submodules
2. In dir editor.js, run git reset --hard 551e3f10b92cf5f5bb4fbd95ac504a815526dc18
3. Install packages (exact steps are below, but it might be easier to follow the repo readme)

   1. In dir editor.js/example/tools/checklist, run yarn install --ignore-engines --ignore-scripts --silent
   2. In dir editor.js/example/tools/code, run yarn install --ignore-engines --ignore-scripts --silent
   3. In dir editor.js/example/tools/delimiter, run yarn install --ignore-engines --ignore-scripts --silent
   4. In dir editor.js/example/tools/embed, run yarn install --ignore-engines --ignore-scripts --silent
   5. In dir editor.js/example/tools/header, run yarn install --ignore-engines --ignore-scripts --silent
   6. In dir editor.js/example/tools/image, run yarn install --ignore-engines --ignore-scripts --silent
   7. In dir editor.js/example/tools/inline-code, run yarn install --ignore-engines --ignore-scripts --silent
   8. In dir editor.js/example/tools/link, run yarn install --ignore-engines --ignore-scripts --silent
   9. In dir editor.js/example/tools/list, run yarn install --ignore-engines --ignore-scripts --silent
   10. In dir editor.js/example/tools/marker, run yarn install --ignore-engines --ignore-scripts --silent
   11. In dir editor.js/example/tools/nested-list, run yarn install --ignore-engines --ignore-scripts --silent
   12. In dir editor.js/example/tools/quote, run yarn install --ignore-engines --ignore-scripts --silent
   13. In dir editor.js/example/tools/raw, run yarn install --ignore-engines --ignore-scripts --silent
   14. In dir editor.js/example/tools/simple-image, run yarn install --ignore-engines --ignore-scripts --silent
   15. In dir editor.js/example/tools/table, run yarn install --ignore-engines --ignore-scripts --silent
   16. In dir editor.js/example/tools/text-variant-tune, run yarn install --ignore-engines --ignore-scripts --silent
   17. In dir editor.js/example/tools/warning, run yarn install --ignore-engines --ignore-scripts --silent
   18. In dir editor.js, run yarn install --ignore-engines --ignore-scripts --silent
   19. In dir editor.js/src/tools/paragraph, run yarn install --ignore-engines --ignore-scripts --silent
4. Back in the initial folder, download RepoResults4/codex-team.editor.js.replay.txt from the artifact folder
5. npm install --no-save @typescript/server-replay
6. npx tsreplay ./editor.js ./codex-team.editor.js.replay.txt path/to/tsserver.js
7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typeorm/typeorm

⚠️ Note that built also had errors ⚠️

Req #2194 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-main/built/local/tsserver.js:165944:13)
    at processChildNode (/typescript-main/built/local/tsserver.js:165853:9)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29427:133)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInArrayType (/typescript-main/built/local/tsserver.js:29402:12)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInConditionalType (/typescript-main/built/local/tsserver.js:29410:90)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-main/built/local/tsserver.js:29748:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29427:175)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInParameter (/typescript-main/built/local/tsserver.js:29334:177)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInMethodDeclaration (/typescript-main/built/local/tsserver.js:29363:273)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at formatSpanWorker (/typescript-main/built/local/tsserver.js:165597:5)
    at /typescript-main/built/local/tsserver.js:165537:105
    at getFormattingScanner (/typescript-main/built/local/tsserver.js:164353:15)
    at Object.formatNodeGivenIndentation (/typescript-main/built/local/tsserver.js:165537:10)
    at /typescript-main/built/local/tsserver.js:148640:36
    at flatMap (/typescript-main/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-main/built/local/tsserver.js:148638:21)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148408:28)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176789:43)
    at /typescript-main/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180728:14)

Req #2194 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-52651/built/local/tsserver.js:165944:13)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165853:9)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-52651/built/local/tsserver.js:29427:133)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInArrayType (/typescript-52651/built/local/tsserver.js:29402:12)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInConditionalType (/typescript-52651/built/local/tsserver.js:29410:90)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-52651/built/local/tsserver.js:29748:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52651/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-52651/built/local/tsserver.js:29427:175)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52651/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInParameter (/typescript-52651/built/local/tsserver.js:29334:177)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInMethodDeclaration (/typescript-52651/built/local/tsserver.js:29363:273)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at formatSpanWorker (/typescript-52651/built/local/tsserver.js:165597:5)
    at /typescript-52651/built/local/tsserver.js:165537:105
    at getFormattingScanner (/typescript-52651/built/local/tsserver.js:164353:15)
    at Object.formatNodeGivenIndentation (/typescript-52651/built/local/tsserver.js:165537:10)
    at /typescript-52651/built/local/tsserver.js:148640:36
    at flatMap (/typescript-52651/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-52651/built/local/tsserver.js:148638:21)
    at getEntryForMemberCompletion (/typescript-52651/built/local/tsserver.js:148408:28)
    at createCompletionEntry (/typescript-52651/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-52651/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-52651/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-52651/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52651/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-52651/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-52651/built/local/tsserver.js:176789:43)
    at /typescript-52651/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-52651/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-52651/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-52651/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-52651/built/local/tsserver.js:180728:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/typeorm.typeorm.rawError.txt in the artifact folder

Last few requests

{"seq":2191,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts"}},"skipDestructiveCodeActions":true}}
{"seq":2192,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts"}}
{"seq":2193,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":19,"offset":15}}
{"seq":2194,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":37,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

1. git clone https://github.com/typeorm/typeorm --recurse-submodules
2. In dir typeorm, run git reset --hard adce6985d899dac29f174e6c828e3042cbea6bdc
3. Back in the initial folder, download RepoResults2/typeorm.typeorm.replay.txt from the artifact folder
4. npm install --no-save @typescript/server-replay
5. npx tsreplay ./typeorm ./typeorm.typeorm.replay.txt path/to/tsserver.js
6. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52651/merge:

Everything looks good!

[weswigham]

@typescript-bot run dt but new and improved with more response post-backs

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

[Andarist]

How can I see those failures?

[jakebailey]

It's nothing you did; just a timeout.

@typescript-bot run dt

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[weswigham]

Since DT says this is good, I'm inclined to take it. Since we just shipped 5.0, we have a full release cycle to see if this has any unintended consequences (though I can't think of any offhand, and obvious our tests don't either). :)