Allow allowImportingTsExtensions to be set in any module resolution mode
#52230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
requested review from
weswigham,
DanielRosenwasser and
jakebailey
andrewbranch
commented
Jan 13, 2023
| @@ -1089,7 +1089,7 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [ | |||
| { | |||
| name: "allowImportingTsExtensions", | |||
| type: "boolean", | |||
| affectsModuleResolution: true, | |||
| affectsSemanticDiagnostics: true, | |||
There was a problem hiding this comment.
This was a mistake—the option has very intentionally never affected how module resolution works, only whether an error is raised. I’m not sure whether it caused the issue we observed during the bug bash, but I added a unit test that shows the error disappearing when updating this option.
jakebailey
approved these changes
Jan 15, 2023
DanielRosenwasser
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #51669 landed,
bundlerwas the only module resolution mode capable of resolving TS files via.ts-extensioned imports. But since #51435 was merged, every module resolution mode resolves these imports, so there’s no reason to predicateallowImportingTsExtensionson module resolution mode anymore. In fact, allowing.ts-extensioned imports can be useful in--moduleResolution nodenextfor users who are targeting Node with a TypeScript-transpiling loader like https://github.com/esbuild-kit/esm-loader.