[wip] Remove objectAllocator concept

.gitignore

@@ -63,4 +63,6 @@ TEST-results.xml
 package-lock.json
 .eslintcache
 *v8.log
+*.heapsnapshot
+*.heapprofile
 /lib/

.vscode/launch.template.json

@@ -49,16 +49,14 @@
             "sourceMaps": true,
             "smartStep": true,
             "preLaunchTask": "npm: build:tests",
-            "console": "integratedTerminal",
-            "customDescriptionGenerator": "'__tsDebuggerDisplay' in this ? this.__tsDebuggerDisplay(defaultValue) : defaultValue"
+            "console": "integratedTerminal"
         },
         {
             // See: https://github.com/microsoft/TypeScript/wiki/Debugging-Language-Service-in-VS-Code
             "type": "node",
             "request": "attach",
             "name": "Attach to VS Code TS Server via Port",
-            "processId": "${command:PickProcess}",
-            "customDescriptionGenerator": "'__tsDebuggerDisplay' in this ? this.__tsDebuggerDisplay(defaultValue) : defaultValue"
+            "processId": "${command:PickProcess}"
         }
     ]
 }

scripts/build/options.mjs

@@ -4,7 +4,7 @@ import os from "os";
 const ci = ["1", "true"].includes(process.env.CI ?? "");
 
 const parsed = minimist(process.argv.slice(2), {
-    boolean: ["dirty", "light", "colors", "lkg", "soft", "fix", "failed", "keepFailed", "force", "built", "ci", "bundle", "typecheck", "lint", "coverage"],
+    boolean: ["dirty", "light", "colors", "lkg", "soft", "fix", "failed", "keepFailed", "force", "built", "ci", "bundle", "typecheck", "lint", "coverage", "bail"],
     string: ["browser", "tests", "break", "host", "reporter", "stackTraceLimit", "timeout", "shards", "shardId"],
     alias: {
         b: "browser",
@@ -41,6 +41,7 @@ const parsed = minimist(process.argv.slice(2), {
         typecheck: true,
         lint: true,
         coverage: false,
+        bail: false,
     },
 });
 
@@ -86,5 +87,6 @@ export default options;
  * @property {boolean} typecheck
  * @property {boolean} lint
  * @property {boolean} coverage
+ * @property {boolean} bail
  */
 void 0;

scripts/build/tests.mjs

@@ -41,6 +41,7 @@ export async function runConsoleTests(runJs, defaultReporter, runInParallel, opt
     const shards = +cmdLineOptions.shards || undefined;
     const shardId = +cmdLineOptions.shardId || undefined;
     const coverage = cmdLineOptions.coverage;
+    const bail = cmdLineOptions.bail;
     if (!cmdLineOptions.dirty) {
         if (options.watching) {
             console.log(chalk.yellowBright(`[watch] cleaning test directories...`));
@@ -90,6 +91,9 @@ export async function runConsoleTests(runJs, defaultReporter, runInParallel, opt
         args.push(mochaJs);
         args.push("-R", findUpFile("scripts/failed-tests.cjs"));
         args.push("-O", '"reporter=' + reporter + (keepFailed ? ",keepFailed=true" : "") + '"');
+        if (bail) {
+            args.push("--bail");
+        }
         if (tests) {
             args.push("-g", `"${tests}"`);
         }

src/compiler/_namespaces/ts.ts

@@ -14,7 +14,6 @@ export * from "../diagnosticInformationMap.generated";
 export * from "../scanner";
 export * from "../utilitiesPublic";
 export * from "../utilities";
-export * from "../factory/baseNodeFactory";
 export * from "../factory/parenthesizerRules";
 export * from "../factory/nodeConverters";
 export * from "../factory/nodeFactory";

src/compiler/binder.ts

@@ -261,7 +261,6 @@ import {
     nodeIsPresent,
     NonNullChain,
     NonNullExpression,
-    objectAllocator,
     ObjectLiteralExpression,
     OptionalChain,
     ParameterDeclaration,
@@ -322,6 +321,7 @@ import {
     WithStatement,
 } from "./_namespaces/ts";
 import * as performance from "./_namespaces/ts.performance";
+import { SymbolObject } from "./objectConstructors";
 
 /** @internal */
 export const enum ModuleInstanceState {
@@ -559,7 +559,6 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
 
     var symbolCount = 0;
 
-    var Symbol: new (flags: SymbolFlags, name: __String) => Symbol;
     var classifiableNames: Set<__String>;
 
     var unreachableFlow = createFlowNode(FlowFlags.Unreachable, /*node*/ undefined, /*antecedent*/ undefined);
@@ -586,8 +585,6 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
         classifiableNames = new Set();
         symbolCount = 0;
 
-        Symbol = objectAllocator.getSymbolConstructor();
-
         // Attach debugging information if necessary
         Debug.attachFlowNodeDebugInfo(unreachableFlow);
         Debug.attachFlowNodeDebugInfo(reportedUnreachableFlow);
@@ -639,7 +636,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
 
     function createSymbol(flags: SymbolFlags, name: __String): Symbol {
         symbolCount++;
-        return new Symbol(flags, name);
+        return new SymbolObject(flags, name);
     }
 
     function addDeclarationToSymbol(symbol: Symbol, node: Declaration, symbolFlags: SymbolFlags) {

src/compiler/checker.ts

@@ -887,7 +887,6 @@ import {
     noTruncationMaximumTruncationLength,
     NumberLiteralType,
     NumericLiteral,
-    objectAllocator,
     ObjectBindingPattern,
     ObjectFlags,
     ObjectFlagsType,
@@ -1100,6 +1099,11 @@ import {
 } from "./_namespaces/ts";
 import * as moduleSpecifiers from "./_namespaces/ts.moduleSpecifiers";
 import * as performance from "./_namespaces/ts.performance";
+import {
+    SignatureObject,
+    SymbolObject,
+    TypeObject,
+} from "./objectConstructors";
 
 const ambientModuleSymbolRegex = /^".+"$/;
 const anon = "(anonymous)" as __String & string;
@@ -1445,10 +1449,6 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     var requestedExternalEmitHelpers: ExternalEmitHelpers;
     var externalHelpersModule: Symbol;
 
-    var Symbol = objectAllocator.getSymbolConstructor();
-    var Type = objectAllocator.getTypeConstructor();
-    var Signature = objectAllocator.getSignatureConstructor();
-
     var typeCount = 0;
     var symbolCount = 0;
     var totalInstantiationCount = 0;
@@ -2510,7 +2510,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 
     function createSymbol(flags: SymbolFlags, name: __String, checkFlags?: CheckFlags) {
         symbolCount++;
-        const symbol = new Symbol(flags | SymbolFlags.Transient, name) as TransientSymbol;
+        const symbol = new SymbolObject(flags | SymbolFlags.Transient, name) as Symbol as TransientSymbol;
         symbol.links = new SymbolLinks() as TransientSymbolLinks;
         symbol.links.checkFlags = checkFlags || CheckFlags.None;
         return symbol;
@@ -5291,7 +5291,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     }
 
     function createType(flags: TypeFlags): Type {
-        const result = new Type(checker, flags);
+        const result = new TypeObject(checker, flags);
         typeCount++;
         result.id = typeCount;
         tracing?.recordType(result);
@@ -5305,7 +5305,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     }
 
     function createOriginType(flags: TypeFlags): Type {
-        return new Type(checker, flags);
+        return new TypeObject(checker, flags);
     }
 
     function createIntrinsicType(kind: TypeFlags, intrinsicName: string, objectFlags = ObjectFlags.None, debugIntrinsicName?: string): IntrinsicType {
@@ -13016,7 +13016,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         minArgumentCount: number,
         flags: SignatureFlags,
     ): Signature {
-        const sig = new Signature(checker, flags);
+        const sig = new SignatureObject(checker, flags);
         sig.declaration = declaration;
         sig.typeParameters = typeParameters;
         sig.parameters = parameters;