Don't leak EvolvingArray out of code flow #49943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
jakebailey
commented
Jul 18, 2022
| } | ||
| else if (type.flags & TypeFlags.Union) { | ||
| resolveUnionTypeMembers(type as UnionType); | ||
| } | ||
| else if (type.flags & TypeFlags.Intersection) { | ||
| resolveIntersectionTypeMembers(type as IntersectionType); | ||
| } | ||
| else { | ||
| Debug.fail("Unhandled type " + Debug.formatTypeFlags(type.flags)); | ||
| } | ||
| } | ||
| return type as ResolvedType; |
There was a problem hiding this comment.
Maybe this should assert each of the things that ResolvedType is assuming are defined, but I don't know how expensive that would be.
DanielRosenwasser
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49942
(I have no idea what I'm doing in the code flow engine)