Set Error.prototype.cause type to unknown (#70) #49639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdul-Azeez Lawal <[email protected]>
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
|
typescript-bot
added
For Backlog Bug
voxpelli
approved these changes
Jun 23, 2022
ljharb
approved these changes
Jun 23, 2022
|
@iamharbie @mkubilayk @dragomirtitian What's needed to get the CLA signed? My guess is that Bloomberg already has a signed CLA, just that @iamharbie hasn't been added to it and thus that the bot doesn't pick it up? |
|
Oh, apparently the Bloomberg CLA thing is being worked on by @RyanCavanaugh: #49675 (comment) |
DanielRosenwasser
added
the
Breaking Change
8 tasks
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jul 20, 2022
…error` on TS `4.8` by @voxpelli This commit fixes the following error, which appears when running TS `^4.8.0-dev.20220707` with eg. ` npx tsc --lib es2020,es2022.error,es2021.promise` or ` npx tsc --lib esnext` > error TS2425: Class 'Error' defines instance member property 'cause', but extended class 'VError' defines it as instance member function. Discovered in voxpelli/pony-cause#41 when looking to extend the tests for voxpelli/pony-cause#35 to detect whether the nightly of `4.8.0` now correctly fixes that, following the merge of microsoft/TypeScript#49639
7 tasks
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes #45167 which changes the type of
Error.prototype.causefromErrortoUnknownTesting performed
I added new tests to ensure that unknown type is recognised
Additional context
Could also potentially resolve #48098. @DanielRosenwasser's suggested being more restrictive with the type of the
causeproperty of the options param. I am open to discussions on this.Fixes #45167
Credits to Bloomberg colleagues who helped with reviews @mkubilayk @dragomirtitian