Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check in isMappedTypeGenericIndexedAccess #49341

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix check in isMappedTypeGenericIndexedAccess #49341

merged 2 commits into from
Jun 1, 2022

Conversation

ahejlsberg
Copy link
Member

Fixes #49242.
Fixes #49338.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 1, 2022
@ahejlsberg ahejlsberg requested a review from RyanCavanaugh June 1, 2022 16:40
@ahejlsberg
Copy link
Member Author

@RyanCavanaugh @DanielRosenwasser We probably want this fix in 4.7.2.

@RyanCavanaugh
Copy link
Member

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 1, 2022

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.7 on this PR at e24c6f6. You can monitor the build here.

@ahejlsberg ahejlsberg merged commit 1beb103 into main Jun 1, 2022
@ahejlsberg ahejlsberg deleted the fix49242 branch June 1, 2022 17:01
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jun 1, 2022
Component commits:
d347d87 Fix check in isMappedTypeGenericIndexedAccess

e24c6f6 Add regression tests
@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, I've opened #49342 for you.

@ahejlsberg ahejlsberg added this to the TypeScript 4.7.3 milestone Jun 1, 2022
DanielRosenwasser added a commit that referenced this pull request Jun 1, 2022
…e-4.7 (#49342)

* Cherry-pick PR #49341 into release-4.7

Component commits:
d347d87 Fix check in isMappedTypeGenericIndexedAccess

e24c6f6 Add regression tests

* Update baselines.

Co-authored-by: Anders Hejlsberg <[email protected]>
Co-authored-by: Daniel Rosenwasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some code became broken in 4.7 Error using indexed access types with mapped types
3 participants