Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(49306): Missing Compiler API predicate functions: isImportTypeAssertionContainer #49313

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix(49306): Missing Compiler API predicate functions: isImportTypeAssertionContainer #49313

merged 1 commit into from
Jun 2, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #49306

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 30, 2022
@DanielRosenwasser
Copy link
Member

Should we be adding this if technically resolution-mode on an import(...) type should be an error?

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 1, 2022
@DanielRosenwasser
Copy link
Member

Should we be adding this if technically resolution-mode on an import(...) type should be an error?

I think we can if #49354 is addressed.

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 2, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at 00b7574. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser merged commit c6447f9 into microsoft:main Jun 2, 2022
@typescript-bot typescript-bot mentioned this pull request Jun 2, 2022
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #49359 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jun 2, 2022
@a-tarasyuk @typescript-bot
Cherry-pick PR microsoft#49313 into release-4.7
4cfc59b 
Component commits:
00b7574 fix(49306): add isImportTypeAssertionContainer helper
DanielRosenwasser pushed a commit that referenced this pull request Jun 2, 2022
@a-tarasyuk
Cherry-pick PR #49313 into release-4.7 (#49359)
c07d883 
Component commits:
00b7574 fix(49306): add isImportTypeAssertionContainer helper

Co-authored-by: Oleksandr T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

@weswigham weswigham Awaiting requested review from weswigham

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Compiler API predicate functions: isImportTypeAssertionContainer
4 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @Andarist